Skip to contentSkip to conversation

eal: fix random device arguments in device iterator

PATCH Applied Xueming Li 2 participants 2 messages Oct 27, 2021 – Nov 4, 2021

lore
Share & tools
lore

Xueming Li

author
#0 lore raw

PATCH 1/1 eal: fix random device arguments in device iterator

Devargs used in device iterator initialization wasn't set to zero, random data like bus string lead to invalid address access.

This patch initializes devargs.

Fixes c99a2d4c6b7f ("eal: implement device iteration initialization")
Cc Gaetan Rivet <[email protected]>
---
 lib/eal/common/eal_common_dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/eal/common/eal_common_dev.c +1 -1
index 148a23830ab..e1e9976d8dc 100644
@@ -573,7 +573,7 @@ int
 rte_dev_iterator_init(struct rte_dev_iterator *it,
 		      const char *dev_str)
 {
-	struct rte_devargs devargs;
+	struct rte_devargs devargs = { .bus = NULL };
 	struct rte_class *cls = NULL;
 	struct rte_bus *bus = NULL;
 
Signature · 1 line
2.33.0
#1 lore raw
Quoted 10 lines · Xueming Li

Devargs used in device iterator initialization wasn't set to zero, random data like bus string lead to invalid address access.

This patch initializes devargs.

Fixes c99a2d4c6b7f ("eal: implement device iteration initialization")

Applied, thanks.

It seems a basic issue, could it be caught with a unit test? Thanks.

Signature · 1 line
David Marchand