Skip to contentSkip to conversation

evm: mark evm_fixmode as __ro_after_init

PATCH In review Austin Kim 2 participants 2 messages Oct 28, 2021 – Oct 29, 2021

Subsystems (4)
lore
Share & tools
lore

Austin Kim

author
#0 lore raw

PATCH 1/1 evm: mark evm_fixmode as __ro_after_init

From: Austin Kim <[email protected]>

The evm_fixmode is only configurable by command-line option and it is never modified outside initcalls, so declaring it with __ro_after_init is better.

---
 security/integrity/evm/evm_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
security/integrity/evm/evm_main.c +1 -1
index 1c8435dfabee..08f907382c61 100644
@@ -78,7 +78,7 @@ static struct xattr_list evm_config_default_xattrnames[] = {
 
 LIST_HEAD(evm_config_xattrnames);
 
-static int evm_fixmode;
+static int evm_fixmode __ro_after_init;
 static int __init evm_set_fixmode(char *str)
 {
 	if (strncmp(str, "fix", 3) == 0)
Signature · 1 line
2.20.1
maintainer
#1 lore raw
Quoted 6 lines · Austin Kim

From: Austin Kim <[email protected]>

The evm_fixmode is only configurable by command-line option and it is never modified outside initcalls, so declaring it with __ro_after_init is better.

Thanks, Austin. This patch set is now applied to the next-integrity branch.

Mimi