writeback: Fix some comment errors
Subsystems (4)
PATCH 1/1 writeback: Fix some comment errors
Signed-off-by Quanfa Fu <[email protected]>
--- mm/khugepaged.c | 2 +- mm/memory-failure.c | 4 ++-- mm/slab_common.c | 2 +- mm/swap.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-)
mm/khugepaged.c +1 -1
@@ -1306,7 +1306,7 @@ static int khugepaged_scan_pmd(struct mm_struct *mm,/* * Record which node the original page is from and save this * information to khugepaged_node_load[]. -* Khupaged will allocate hugepage from the node has the max +* Khugepaged will allocate hugepage from the node has the max * hit record. */ node =page_to_nid (page);
mm/memory-failure.c +2 -2
@@ -1227,7 +1227,7 @@ static int get_any_page(struct page *p, unsigned long flags)* * get_hwpoison_page() takes a page refcount of an error page to handle memory * error on it, after checking that the error page is in a well-defined state -* (defined as a page-type we can successfully handle the memor error on it, +* (defined as a page-type we can successfully handle the memory error on it, * such as LRU page and hugetlb page). * * Memory error handling could be triggered at any time on any type of page,
@@ -1653,7 +1653,7 @@ int memory_failure(unsigned long pfn, int flags)/* * We need/can do nothing about count=0 pages. -* 1) it's a free page, and therefore in safe hand: +* 1) it's a freed page, and therefore in safe hand: * prep_new_page() will be the gate keeper. * 2) it's part of a non-compound high order page. * Implies some kernel user: cannot stop them from
mm/slab_common.c +1 -1
@@ -832,7 +832,7 @@ void __init setup_kmalloc_cache_index_table(void)if (KMALLOC_MIN_SIZE >=64 ) {/* -* The 96 byte size cache is not used if the alignment +* The 96 byte sized cache is not used if the alignment * is 64 byte. */ for (i =64 +8 ; i <=96 ; i +=8 )
mm/swap.c +1 -1
@@ -866,7 +866,7 @@ void lru_cache_disable(void)* all online CPUs so any calls of lru_cache_disabled wrapped by * local_lock or preemption disabled would be ordered by that. * The atomic operation doesn't need to have stronger ordering -* requirements because that is enforeced by the scheduling +* requirements because that is enforced by the scheduling * guarantees. */ __lru_add_drain_all (true);
Signature · 1 line
2.25.1
Hi Quanfa,
mm/memory-failure.c int memory_failure(unsigned long pfn, int flags) · line 1659
Quoted 9 lines
mm/memory-failure.c +1
-1@@ -1653,7 +1653,7 @@ int memory_failure(unsigned long pfn, int flags)/* * We need/can do nothing about count=0 pages. -* 1) it's a free page, and therefore in safe hand: +* 1) it's a freed page, and therefore in safe hand: * prep_new_page() will be the gate keeper. * 2) it's part of a non-compound high order page. * Implies some kernel user: cannot stop them from
I think that the word "free page" is common enough and you can find it in many other files, so it makes little sense to fix it as a typo?
Thanks,
Naoya Horiguchi
Yes, I agree.
I will make a new patch.
Thanks.
Quoted 18 lines · HORIGUCHI NAOYA(堀口 直也) <[email protected]> 于2021年11月1日周一 上午7:53写道:
Hi Quanfa,
mm/memory-failure.c int memory_failure(unsigned long pfn, int flags) · line 1659
Quoted 9 lines
mm/memory-failure.c +1
-1@@ -1653,7 +1653,7 @@ int memory_failure(unsigned long pfn, int flags)/* * We need/can do nothing about count=0 pages. -* 1) it's a free page, and therefore in safe hand: +* 1) it's a freed page, and therefore in safe hand: * prep_new_page() will be the gate keeper. * 2) it's part of a non-compound high order page. * Implies some kernel user: cannot stop them from I think that the word "free page" is common enough and you can find it in many other files, so it makes little sense to fix it as a typo?
Thanks,
Naoya Horiguchi