Skip to contentSkip to conversation

pinctrl: ralink: include 'ralink_regs.h' in 'pinctrl-mt7620.c'

PATCH In review Sergio Paracuellos 3 participants 5 messages Oct 31, 2021 – Nov 9, 2021

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 pinctrl: ralink: include 'ralink_regs.h' in 'pinctrl-mt7620.c'

mt7620.h, included by pinctrl-mt7620.c, mentions MT762X_SOC_MT7628AN declared in ralink_regs.h.

Fixes 745ec436de72 ("pinctrl: ralink: move MT7620 SoC pinmux config into a new 'pinctrl-mt7620.c' file")

---
Changes in v2:
- Original patch from Luiz.
- I have added Fixes tag and CC Linus Walleij and stable and sent v2.

 drivers/pinctrl/ralink/pinctrl-mt7620.c | 1 +
 1 file changed, 1 insertion(+)
drivers/pinctrl/ralink/pinctrl-mt7620.c +1 -0
index 425d55a2ee19..6853b5b8b0fe 100644
@@ -1,5 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0-only
 
+#include <asm/mach-ralink/ralink_regs.h>
 #include <asm/mach-ralink/mt7620.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
Signature · 1 line
2.33.0
#1 lore raw
Quoted 10 lines · Sergio Paracuellos

mt7620.h, included by pinctrl-mt7620.c, mentions MT762X_SOC_MT7628AN declared in ralink_regs.h.

Fixes 745ec436de72 ("pinctrl: ralink: move MT7620 SoC pinmux config into a new 'pinctrl-mt7620.c' file")

Tag blocks mustn't have blank lines.

...

Quoted 4 lines

+#include <asm/mach-ralink/ralink_regs.h>
#include <asm/mach-ralink/mt7620.h>
#include <linux/module.h>
#include <linux/platform_device.h>

Actually the rule of thumb is to start from more generic definitions / inclusions to more particular. Thus, asm/* usually goes after linux/*. Any Specific reason why here is not the case?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw

Hi Andy,

Quoted 7 lines · Andy Shevchenko
Quoted 4 lines · Sergio Paracuellos

mt7620.h, included by pinctrl-mt7620.c, mentions MT762X_SOC_MT7628AN declared in ralink_regs.h.

Quoted 8 lines
Quoted 6 lines
Fixes 745ec436de72 ("pinctrl: ralink: move MT7620 SoC pinmux config into a new 'pinctrl-mt7620.c' file")

Tag blocks mustn't have blank lines.

Ok, thanks for letting me know.

Quoted 11 lines

...

Quoted 4 lines

+#include <asm/mach-ralink/ralink_regs.h>
#include <asm/mach-ralink/mt7620.h>
#include <linux/module.h>
#include <linux/platform_device.h>

Actually the rule of thumb is to start from more generic definitions / inclusions to more particular. Thus, asm/* usually goes after linux/*. Any Specific reason why here is not the case?

I just respect the order that was already in the files, I guess when I moved all of this from arch/mips into drivers/pinctrl. All files inside follows the same order.

Best regards,
Sergio Paracuellos

Quoted 4 lines

--
With Best Regards,
Andy Shevchenko

#3 lore raw
In reply to Sergio Paracuellos
Quoted 7 lines · Sergio Paracuellos

mt7620.h, included by pinctrl-mt7620.c, mentions MT762X_SOC_MT7628AN declared in ralink_regs.h.

Fixes 745ec436de72 ("pinctrl: ralink: move MT7620 SoC pinmux config into a new 'pinctrl-mt7620.c' file")
Quoted 6 lines

---
Changes in v2:
- Original patch from Luiz.
- I have added Fixes tag and CC Linus Walleij and stable and sent v2.

Fixed up headers and applied for fixes.

Yours,
Linus Walleij

#4 lore raw
Quoted 11 lines · Linus Walleij
Quoted 7 lines · Sergio Paracuellos

mt7620.h, included by pinctrl-mt7620.c, mentions MT762X_SOC_MT7628AN declared in ralink_regs.h.

Fixes 745ec436de72 ("pinctrl: ralink: move MT7620 SoC pinmux config into a new 'pinctrl-mt7620.c' file")
Quoted 8 lines
Quoted 6 lines

---
Changes in v2:
- Original patch from Luiz.
- I have added Fixes tag and CC Linus Walleij and stable and sent v2.

Fixed up headers and applied for fixes.

Thanks!

Best regards,
Sergio Paracuellos

Quoted 3 lines

Yours,
Linus Walleij