pinctrl: ralink: include 'ralink_regs.h' in 'pinctrl-mt7620.c'
Subsystems (4)
PATCH v2 1/1 pinctrl: ralink: include 'ralink_regs.h' in 'pinctrl-mt7620.c'
mt7620.h, included by pinctrl-mt7620.c, mentions MT762X_SOC_MT7628AN declared in ralink_regs.h.
---
Changes in v2:
- Original patch from Luiz.
- I have added Fixes tag and CC Linus Walleij and stable and sent v2.
drivers/pinctrl/ralink/pinctrl-mt7620.c | 1 + 1 file changed, 1 insertion(+)
drivers/pinctrl/ralink/pinctrl-mt7620.c +1 -0
@@ -1,5 +1,6 @@// SPDX-License-Identifier: GPL-2.0-only +#include <asm/mach-ralink/ralink_regs.h> #include <asm/mach-ralink/mt7620.h> #include <linux/module.h> #include <linux/platform_device.h>
Signature · 1 line
2.33.0
Quoted 10 lines · Sergio Paracuellos
mt7620.h, included bypinctrl-mt7620.c, mentionsMT762X_SOC_MT7628ANdeclared inralink_regs.h.Fixes 745ec436de72 ("pinctrl: ralink: move MT7620 SoC pinmux config into a new 'pinctrl-mt7620.c' file")Signed-off-by Luiz Angelo Daros de Luca <[email protected]>Signed-off-by Sergio Paracuellos <[email protected]>
Tag blocks mustn't have blank lines.
...
Quoted 4 lines
+#include <
asm/mach-ralink/ralink_regs.h>
#include <asm/mach-ralink/mt7620.h>
#include <linux/module.h>
#include <linux/platform_device.h>
Actually the rule of thumb is to start from more generic definitions / inclusions to more particular. Thus, asm/* usually goes after linux/*. Any Specific reason why here is not the case?
Signature · 2 lines
With Best Regards, Andy Shevchenko
Hi Andy,
Quoted 7 lines · Andy Shevchenko
Quoted 4 lines · Sergio Paracuellos
mt7620.h, included bypinctrl-mt7620.c, mentionsMT762X_SOC_MT7628ANdeclared inralink_regs.h.
Quoted 8 lines
Quoted 6 lines
Fixes 745ec436de72 ("pinctrl: ralink: move MT7620 SoC pinmux config into a new 'pinctrl-mt7620.c' file")Signed-off-by Luiz Angelo Daros de Luca <[email protected]>Signed-off-by Sergio Paracuellos <[email protected]>Tag blocks mustn't have blank lines.
Ok, thanks for letting me know.
Quoted 11 lines
...
Quoted 4 lines
+#include <
asm/mach-ralink/ralink_regs.h>
#include <asm/mach-ralink/mt7620.h>
#include <linux/module.h>
#include <linux/platform_device.h>Actually the rule of thumb is to start from more generic definitions / inclusions to more particular. Thus, asm/* usually goes after linux/*. Any Specific reason why here is not the case?
I just respect the order that was already in the files, I guess when I moved all of this from arch/mips into drivers/pinctrl. All files inside follows the same order.
Best regards,
Sergio Paracuellos
Quoted 4 lines
--
With Best Regards,
Andy Shevchenko
Quoted 7 lines · Sergio Paracuellos
mt7620.h, included bypinctrl-mt7620.c, mentionsMT762X_SOC_MT7628ANdeclared inralink_regs.h.Fixes 745ec436de72 ("pinctrl: ralink: move MT7620 SoC pinmux config into a new 'pinctrl-mt7620.c' file")
Quoted 6 lines
Signed-off-by Luiz Angelo Daros de Luca <[email protected]>Signed-off-by Sergio Paracuellos <[email protected]>---
Changes in v2:
- Original patch from Luiz.
- I have added Fixes tag and CC Linus Walleij and stable and sent v2.
Fixed up headers and applied for fixes.
Yours,
Linus Walleij
Quoted 11 lines · Linus Walleij
Quoted 7 lines · Sergio Paracuellos
mt7620.h, included bypinctrl-mt7620.c, mentionsMT762X_SOC_MT7628ANdeclared inralink_regs.h.Fixes 745ec436de72 ("pinctrl: ralink: move MT7620 SoC pinmux config into a new 'pinctrl-mt7620.c' file")
Quoted 8 lines
Quoted 6 lines
Signed-off-by Luiz Angelo Daros de Luca <[email protected]>Signed-off-by Sergio Paracuellos <[email protected]>---
Changes in v2:
- Original patch from Luiz.
- I have added Fixes tag and CC Linus Walleij and stable and sent v2.Fixed up headers and applied for fixes.
Thanks!
Best regards,
Sergio Paracuellos
Quoted 3 lines
Yours,
Linus Walleij