Skip to contentSkip to conversation

max96712: Select VIDEO_V4L2

PATCH In review Sakari Ailus 3 participants 7 messages Nov 1, 2021 – Nov 26, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 max96712: Select VIDEO_V4L2

Select VIDEO_V4L2 for the driver actually depends on it, failing to compile otherwise.

Fixes 51758f8b32134bacbf30bd217f7c2074e9b4b51e ("media: staging: max96712: Add basic support for MAX96712 GMSL2 deserializer")
---
 drivers/staging/media/max96712/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/media/max96712/Kconfig +1 -0
index 258d47644cbd..492a7ff70dd8 100644
@@ -6,6 +6,7 @@ config VIDEO_MAX96712
 	select V4L2_FWNODE
 	select VIDEO_V4L2_SUBDEV_API
 	select MEDIA_CONTROLLER
+	select VIDEO_V4L2
 	help
 	  This driver supports the Maxim MAX96712 Quad GMSL2 Deserializer.
 
Signature · 1 line
2.30.2
Reviewed-by on v1 1/1
#1 lore raw

Hi Sakari,

Thanks for your patch.

Quoted 6 lines · Sakari Ailus

Select VIDEO_V4L2 for the driver actually depends on it, failing to compile otherwise.

Fixes 51758f8b32134bacbf30bd217f7c2074e9b4b51e ("media: staging: max96712: Add basic support for MAX96712 GMSL2 deserializer")
Quoted 19 lines
---
 drivers/staging/media/max96712/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/media/max96712/Kconfig +1 -0
index 258d47644cbd..492a7ff70dd8 100644
@@ -6,6 +6,7 @@ config VIDEO_MAX96712
 	select V4L2_FWNODE
 	select VIDEO_V4L2_SUBDEV_API
 	select MEDIA_CONTROLLER
+	select VIDEO_V4L2
 	help
 	  This driver supports the Maxim MAX96712 Quad GMSL2 Deserializer.
 
Signature · 1 line
2.30.2
Signature · 2 lines
Regards,
Niklas Söderlund
#2 lore raw
In reply to Sakari Ailus

Hi Sakari,

Quoting Sakari Ailus (2021-11-01 13:25:02)

Quoted 4 lines

Select VIDEO_V4L2 for the driver actually depends on it, failing to compile otherwise.

Fixes 51758f8b32134bacbf30bd217f7c2074e9b4b51e ("media: staging: max96712: Add basic support for MAX96712 GMSL2 deserializer")

I guess this is a local commit in your tree so far, I can't identify it.

Quoted 11 lines
---
 drivers/staging/media/max96712/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/media/max96712/Kconfig +0 -0
index 258d47644cbd..492a7ff70dd8 100644

drivers/staging/media/max96712/Kconfig config VIDEO_MAX96712 · line 9

Quoted 4 lines
drivers/staging/media/max96712/Kconfig +1 -0
@@ -6,6 +6,7 @@ config VIDEO_MAX96712
        select V4L2_FWNODE
        select VIDEO_V4L2_SUBDEV_API
        select MEDIA_CONTROLLER
+       select VIDEO_V4L2

I don't see any other driver 'select' VIDEO_V4L2... Most 'depend' on VIDEO_V4L2 instead.

And curiously, I already see
- Add 'depends on VIDEO_V4L2'

in Niklas' v4.

Is this one a special case that 'needs' to select it? --
Kieran

Quoted 6 lines
drivers/staging/media/max96712/Kconfig +0 -0
        help
          This driver supports the Maxim MAX96712 Quad GMSL2 Deserializer.
 
Signature · 1 line
2.30.2
#3 lore raw

Hi Kieran,

Quoted 29 lines · Kieran Bingham

Hi Sakari,

Quoting Sakari Ailus (2021-11-01 13:25:02)

Quoted 4 lines

Select VIDEO_V4L2 for the driver actually depends on it, failing to compile otherwise.

Fixes 51758f8b32134bacbf30bd217f7c2074e9b4b51e ("media: staging: max96712: Add basic support for MAX96712 GMSL2 deserializer")

I guess this is a local commit in your tree so far, I can't identify it.

Quoted 11 lines
---
 drivers/staging/media/max96712/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/media/max96712/Kconfig +0 -0
index 258d47644cbd..492a7ff70dd8 100644

drivers/staging/media/max96712/Kconfig config VIDEO_MAX96712 · line 9

Quoted 4 lines
drivers/staging/media/max96712/Kconfig +1 -0
@@ -6,6 +6,7 @@ config VIDEO_MAX96712
        select V4L2_FWNODE
        select VIDEO_V4L2_SUBDEV_API
        select MEDIA_CONTROLLER
+       select VIDEO_V4L2

I don't see any other driver 'select' VIDEO_V4L2... Most 'depend' on VIDEO_V4L2 instead.

Quoted 4 lines

And curiously, I already see
- Add 'depends on VIDEO_V4L2'

in Niklas' v4.

I noticed too late that v3 was already in the media staging tree so I submitted a v4 with this fix. I should probably have submitted a Fixes patch like this one instead of a v4 if I knew it was already picked-up.

Quoted 2 lines

Is this one a special case that 'needs' to select it?

Both 'select' and 'depends on' solves the problem reported by the bot, which one is more correct I do not know.

Quoted 11 lines

--
Kieran

Quoted 6 lines
drivers/staging/media/max96712/Kconfig +0 -0
        help
          This driver supports the Maxim MAX96712 Quad GMSL2 Deserializer.
 
Signature · 1 line
2.30.2
Signature · 2 lines
Regards,
Niklas Söderlund
#4 lore raw

Quoting Niklas Söderlund (2021-11-01 16:55:02)

Quoted 42 lines

Hi Kieran,

Quoted 29 lines · Kieran Bingham

Hi Sakari,

Quoting Sakari Ailus (2021-11-01 13:25:02)

Quoted 4 lines

Select VIDEO_V4L2 for the driver actually depends on it, failing to compile otherwise.

Fixes 51758f8b32134bacbf30bd217f7c2074e9b4b51e ("media: staging: max96712: Add basic support for MAX96712 GMSL2 deserializer")

I guess this is a local commit in your tree so far, I can't identify it.

Quoted 11 lines
---
 drivers/staging/media/max96712/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/media/max96712/Kconfig +0 -0
index 258d47644cbd..492a7ff70dd8 100644

drivers/staging/media/max96712/Kconfig config VIDEO_MAX96712 · line 9

Quoted 4 lines
drivers/staging/media/max96712/Kconfig +1 -0
@@ -6,6 +6,7 @@ config VIDEO_MAX96712
        select V4L2_FWNODE
        select VIDEO_V4L2_SUBDEV_API
        select MEDIA_CONTROLLER
+       select VIDEO_V4L2

I don't see any other driver 'select' VIDEO_V4L2... Most 'depend' on VIDEO_V4L2 instead.

Quoted 4 lines

And curiously, I already see
- Add 'depends on VIDEO_V4L2'

in Niklas' v4.

I noticed too late that v3 was already in the media staging tree so I submitted a v4 with this fix. I should probably have submitted a Fixes patch like this one instead of a v4 if I knew it was already picked-up.

Quoted 1 line
Quoted 4 lines
Quoted 1 line

Is this one a special case that 'needs' to select it?

Both 'select' and 'depends on' solves the problem reported by the bot, which one is more correct I do not know.

Aha, I see. Well - consistency would tell me that 'depends on' would match almost every other driver.

I notice that the MAX9286 suffers the same problem. I'll send a patch. --
Kieran

Quoted 15 lines
Quoted 11 lines

--
Kieran

Quoted 6 lines
drivers/staging/media/max96712/Kconfig +0 -0
        help
          This driver supports the Maxim MAX96712 Quad GMSL2 Deserializer.
 
Signature · 1 line
2.30.2
Signature · 2 lines
Regards,
Niklas Söderlund
#5 lore raw
In reply to Sakari Ailus

Hi Sakari,

I noticed this patch is marked as Rejected in patchwork, but it's still needed. Will you resurrect this patch?

Quoted 25 lines · Sakari Ailus

Select VIDEO_V4L2 for the driver actually depends on it, failing to compile otherwise.

Fixes 51758f8b32134bacbf30bd217f7c2074e9b4b51e ("media: staging: max96712: Add basic support for MAX96712 GMSL2 deserializer")
---
 drivers/staging/media/max96712/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/media/max96712/Kconfig +1 -0
index 258d47644cbd..492a7ff70dd8 100644
@@ -6,6 +6,7 @@ config VIDEO_MAX96712
 	select V4L2_FWNODE
 	select VIDEO_V4L2_SUBDEV_API
 	select MEDIA_CONTROLLER
+	select VIDEO_V4L2
 	help
 	  This driver supports the Maxim MAX96712 Quad GMSL2 Deserializer.
 
Signature · 1 line
2.30.2
Signature · 2 lines
Kind Regards,
Niklas Söderlund
#6 lore raw

Hi Niklas,

Quoted 4 lines · Niklas Söderlund

Hi Sakari,

I noticed this patch is marked as Rejected in patchwork, but it's still needed. Will you resurrect this patch?

Good point.

I noticed Kieran submitted something alike but it seems to have been for a different driver.

I'll send one that uses depends instead.

Signature · 3 lines
Regards,

Sakari Ailus