Drivers: hv: balloon: Use VMBUS_RING_SIZE() wrapper for dm_ring_size
PATCH 1/1 Drivers: hv: balloon: Use VMBUS_RING_SIZE() wrapper for dm_ring_size
Baihua reported an error when boot an ARM64 guest with PAGE_SIZE=64k and BALLOON is enabled:
hv_vmbus: registering driver hv_balloon hv_vmbus: probe failed for device 1eccfd72-4b41-45ef-b73a-4a6e44c12924 (-22)
The cause of this is that the ringbuffer size for hv_balloon is not adjusted with VMBUS_RING_SIZE(), which makes the size not large enough for ringbuffers on guest with PAGE_SIZE=64k. Therefore use VMBUS_RING_SIZE() to calculate the ringbuffer size. Note that the old size (20 * 1024) counts a 4k header in the total size, while VMBUS_RING_SIZE() expects the parameter as the payload size, so use 16 * 1024.
--- drivers/hv/hv_balloon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hv/hv_balloon.c +1 -1
@@ -480,7 +480,7 @@ module_param(pressure_report_delay, uint, (S_IRUGO | S_IWUSR));MODULE_PARM_DESC (pressure_report_delay,"Delay in secs in reporting pressure" );static atomic_t trans_id =ATOMIC_INIT (0 ); -static int dm_ring_size =20 *1024 ; +static int dm_ring_size =VMBUS_RING_SIZE (16 *1024 );/* * Driver specific state.
Signature · 1 line
2.33.0
Quoted 26 lines · Boqun Feng
Baihua reported an error when boot an ARM64 guest with PAGE_SIZE=64k and BALLOON is enabled:
hv_vmbus: registering driver hv_balloon hv_vmbus: probe failed for device 1eccfd72-4b41-45ef-b73a-4a6e44c12924 (-22)The cause of this is that the ringbuffer size for
hv_balloonis not adjusted withVMBUS_RING_SIZE(), which makes the size not large enough for ringbuffers on guest with PAGE_SIZE=64k. Therefore useVMBUS_RING_SIZE()to calculate the ringbuffer size. Note that the old size (20 * 1024) counts a 4k header in the total size, whileVMBUS_RING_SIZE()expects the parameter as the payload size, so use 16 * 1024.Cc <[email protected]> # 5.15.xReported-by Baihua Lu <[email protected]>Signed-off-by Boqun Feng <[email protected]>--- drivers/hv/hv_balloon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/hv/hv_balloon.c +0
-0
drivers/hv/hv_balloon.c module_param(pressure_report_delay, uint, (S_IRUGO | S_IWUSR)); · line 486
Quoted 8 lines
drivers/hv/hv_balloon.c +1
-1@@ -480,7 +480,7 @@ module_param(pressure_report_delay, uint, (S_IRUGO | S_IWUSR));MODULE_PARM_DESC (pressure_report_delay,"Delay in secs in reporting pressure" );static atomic_t trans_id =ATOMIC_INIT (0 ); -static int dm_ring_size =20 *1024 ; +static int dm_ring_size =VMBUS_RING_SIZE (16 *1024 );/* * Driver specific state.
Thanks!
Signature · 1 line
Vitaly
Quoted 1 line · Vitaly Kuznetsov
Boqun Feng <[email protected]> writes:
[...]
Quoted 3 lines
Tested-by Vitaly Kuznetsov <[email protected]>
Applied to hyperv-fixes. Thanks.
Quoted 5 lines
Thanks!
Signature · 1 line
Vitaly