Skip to contentSkip to conversation

ftrace/samples: Add missing prototype for my_direct_func

PATCH New Jiri Olsa 1 participant 1 message Nov 1, 2021 ftrace

lore
Share & tools
lore

Jiri Olsa

author
#0 lore raw

PATCH v2 1/1 ftrace/samples: Add missing prototype for my_direct_func

There's compilation fail reported kernel test robot for W=1 build:

Quoted 1 line
Quoted 1 line

samples/ftrace/ftrace-direct-multi.c:8:6: warning: no previous

prototype for function 'my_direct_func' [-Wmissing-prototypes]
void my_direct_func(unsigned long ip)

The inlined assembly is used outside function, so we can't make my_direct_func static and pass it as asm input argument.

However my_tramp is already extern so I think there's no problem keeping my_direct_func extern as well and just add its prototype.

Fixes 5fae941b9a6f ("ftrace/samples: Add multi direct interface test module")
---
 samples/ftrace/ftrace-direct-multi.c | 2 ++
 1 file changed, 2 insertions(+)
samples/ftrace/ftrace-direct-multi.c +2 -0
index 2a5b1fb7ac14..b6d7806b400e 100644
@@ -5,6 +5,8 @@
 #include <linux/ftrace.h>
 #include <linux/sched/stat.h>
 
+extern void my_direct_func(unsigned long ip);
+
 void my_direct_func(unsigned long ip)
 {
 	trace_printk("ip %lx\n", ip);
Signature · 1 line
2.32.0