Skip to contentSkip to conversation

tests/core_hotunplug: apply audio unload for all i915 hw

PATCH In review Kai Vehmanen 4 participants 6 messages Nov 1, 2021 – Apr 7, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/core_hotunplug: apply audio unload for all i915 hw

The HDA audio driver does not support dynamic hotplug of a HDA codec and that applies also to the display HDA codec.

To test unbind of i915, audio driver must be first unbound and/or unloaded. This is the only way to ensure clean unbind, and possibility to cleanly reestablish connection between audio and i915.

Without this fix, the core_hotunplug test only works if the audio controller is runtime suspended when the test is run. This is very brittle and subject to timing races, differences in system configuration and so forth. A more predictable test is to explicitly unload the audio and in case some entity is using the audio driver, this is flagged with a clear, easily understandable error.

References: https://gitlab.freedesktop.org/drm/intel/-/issues/1602

Cc Uma Shankar <[email protected]>
Cc Janusz Krzysztofik <[email protected]>
---
 tests/core_hotunplug.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

Hello,
I'm from the audio driver team and this is my first contribution to i-g-t. Apologies beforehand for any omissions in following the patch submission, but all guidance in CONTRIBUTING.md should be covered.

For background, this patch addresses a pretty fundamental issue in the unbind test. As of now, the audio driver using DRM component framework (e.g. snd-hda-intel and related), do not support the codec hotplug. This was discussed with audio maintainers in:
https://mailman.alsa-project.org/pipermail/alsa-devel/2021-September/190279.html

.. and the outcome is that this is not supported now, and as some fundamental pieces are missing, this won't be fully supported any time soon.

So to align with current reality, and to make test execution more predictable, this patch adds a audio driver unload for all i915 platforms.

Looking forward to your feedback.

Br, Kai

tests/core_hotunplug.c +6 -7
index b366166888cd..900d4886bd13 100644
@@ -621,13 +621,12 @@ igt_main
 		igt_skip_on_f(fd_drm < 0, "No known DRM device found\n");
 
 		if (is_i915_device(fd_drm)) {
-			uint32_t devid = intel_get_drm_devid(fd_drm);
-
-			if ((IS_HASWELL(devid) || IS_BROADWELL(devid) ||
-			     IS_DG1(devid)) && (igt_kmod_is_loaded("snd_hda_intel"))) {
-				igt_debug("Enable WA to unload snd driver\n");
-				priv.snd_unload = true;
-			}
+			/*
+			 * Audio driver does not support hot unplug via DRM
+			 * audio component framework, so driver must be unloaded
+			 * explicitly for i915 unbind tests.
+			 */
+			priv.snd_unload = true;
 
 			gem_quiescent_gpu(fd_drm);
 			igt_require_gem(fd_drm);

base-commit: 3458490c14afe3cb8aa873fa9e520e1c815ea068

Signature · 1 line
2.33.0
#1 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for tests/core_hotunplug: apply audio unload for all i915 hw

== Series Details ==

== Series Details ==

Series: tests/core_hotunplug: apply audio unload for all i915 hw
URL : https://patchwork.freedesktop.org/series/96465/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10824 -> IGTPW_6366
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/index.html

Participating hosts (40 -> 37)
------------------------------

Additional (1): fi-pnv-d510
Missing (4): fi-bsw-cyan bat-adlp-4 bat-dg1-6 fi-hsw-4200u

Known issues
------------

Here are the changes found in IGTPW_6366 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@core_hotunplug@unbind-rebind:
- fi-kbl-x1275: [PASS][1] -> [SKIP][2] ([fdo#109271])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/fi-kbl-x1275/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/fi-kbl-x1275/igt@[email protected]

* igt@i915_selftest@live@execlists:
- fi-bsw-kefka: [PASS][3] -> [INCOMPLETE][4] ([i915#2940])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/fi-bsw-kefka/igt@i915_selftest@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/fi-bsw-kefka/igt@i915_selftest@[email protected]

* igt@kms_frontbuffer_tracking@basic:
- fi-cml-u2: [PASS][5] -> [DMESG-WARN][6] ([i915#4269])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/fi-cml-u2/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/fi-cml-u2/igt@[email protected]

* igt@prime_vgem@basic-userptr:
- fi-pnv-d510: NOTRUN -> [SKIP][7] ([fdo#109271]) +53 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/fi-pnv-d510/igt@[email protected]

* igt@runner@aborted:
- fi-bsw-kefka: NOTRUN -> [FAIL][8] ([fdo#109271] / [i915#1436] / [i915#3428] / [i915#4312])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/fi-bsw-kefka/igt@[email protected]

#### Possible fixes ####

* igt@kms_frontbuffer_tracking@basic:
- {fi-hsw-gt1}: [DMESG-WARN][9] ([i915#4290]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/fi-hsw-gt1/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/fi-hsw-gt1/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#3428]: https://gitlab.freedesktop.org/drm/intel/issues/3428
[i915#4269]: https://gitlab.freedesktop.org/drm/intel/issues/4269
[i915#4290]: https://gitlab.freedesktop.org/drm/intel/issues/4290
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6265 -> IGTPW_6366

CI-20190529: 20190529
CI_DRM_10824: ad79191290568b948a3bf99ba99fad4023ed2ab4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6366: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/index.html
IGT_6265: 5004c6cf2ad4a72423b4cf0cd42686925bcb80fe @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/index.html

#2 lore raw

[igt-dev] ✗ Fi.CI.IGT: failure for tests/core_hotunplug: apply audio unload for all i915 hw

In reply to Kai Vehmanen
== Series Details ==

== Series Details ==

Series: tests/core_hotunplug: apply audio unload for all i915 hw
URL : https://patchwork.freedesktop.org/series/96465/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_10824_full -> IGTPW_6366_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_6366_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_6366_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/index.html

Participating hosts (10 -> 7)
------------------------------

Missing (3): pig-skl-6260u pig-kbl-iris pig-glk-j5005

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_6366_full:

### IGT changes ###

#### Possible regressions ####

* igt@gem_workarounds@reset-fd:
- shard-snb: [PASS][1] -> [TIMEOUT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/shard-snb4/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-snb5/igt@[email protected]

Known issues
------------

Here are the changes found in IGTPW_6366_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_create@create-massive:
- shard-tglb: NOTRUN -> [DMESG-WARN][3] ([i915#3002])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb8/igt@[email protected]

* igt@gem_ctx_sseu@invalid-args:
- shard-tglb: NOTRUN -> [SKIP][4] ([i915#280])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb3/igt@[email protected]

* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [PASS][5] -> [FAIL][6] ([i915#2842]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/shard-tglb1/igt@gem_exec_fair@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb7/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-glk: [PASS][7] -> [FAIL][8] ([i915#2842])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/shard-glk5/igt@gem_exec_fair@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-glk6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-kbl: [PASS][9] -> [FAIL][10] ([i915#2842])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/shard-kbl2/igt@gem_exec_fair@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-kbl7/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vecs0:
- shard-kbl: NOTRUN -> [FAIL][11] ([i915#2842])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-kbl4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-glk: NOTRUN -> [FAIL][12] ([i915#2842])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-glk8/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][13] ([i915#2842]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-iclb2/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [PASS][14] -> [FAIL][15] ([i915#2849])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/shard-iclb4/igt@gem_exec_fair@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-iclb4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_params@no-vebox:
- shard-tglb: NOTRUN -> [SKIP][16] ([fdo#109283])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb6/igt@[email protected]

* igt@gem_pread@exhaustion:
- shard-tglb: NOTRUN -> [WARN][17] ([i915#2658])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb3/igt@[email protected]

* igt@gem_pxp@reject-modify-context-protection-off-1:
- shard-iclb: NOTRUN -> [SKIP][18] ([i915#4270])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-iclb2/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][19] ([i915#4270])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb5/igt@[email protected]

* igt@gem_softpin@noreloc-s3:
- shard-kbl: NOTRUN -> [DMESG-WARN][20] ([i915#180])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-kbl4/igt@[email protected]

* igt@gem_userptr_blits@unsync-overlap:
- shard-tglb: NOTRUN -> [SKIP][21] ([i915#3297])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb2/igt@[email protected]

* igt@gen9_exec_parse@bb-large:
- shard-tglb: NOTRUN -> [SKIP][22] ([i915#2856]) +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb6/igt@[email protected]

* igt@i915_pm_backlight@bad-brightness:
- shard-glk: NOTRUN -> [SKIP][23] ([fdo#109271]) +50 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-glk4/igt@[email protected]

* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-kbl: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#1937])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-kbl2/igt@i915_pm_lpsp@[email protected]

* igt@i915_pm_rpm@modeset-non-lpsp-stress:
- shard-tglb: NOTRUN -> [SKIP][25] ([fdo#111644] / [i915#1397] / [i915#2411])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb3/igt@[email protected]

* igt@i915_suspend@sysfs-reader:
- shard-tglb: [PASS][26] -> [INCOMPLETE][27] ([i915#456])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/shard-tglb6/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb7/igt@[email protected]

* igt@kms_big_fb@x-tiled-8bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][28] ([fdo#110725] / [fdo#111614])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-iclb4/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][29] ([fdo#111614]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb3/igt@[email protected]

* igt@kms_big_fb@yf-tiled-addfb-size-overflow:
- shard-tglb: NOTRUN -> [SKIP][30] ([fdo#111615]) +6 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb3/igt@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-glk: NOTRUN -> [SKIP][31] ([fdo#109271] / [i915#3777])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-glk3/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][32] ([fdo#109271] / [i915#3777])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-kbl6/igt@[email protected]

* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][33] ([fdo#109271] / [i915#3886]) +5 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-apl3/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][34] ([fdo#109271] / [i915#3886]) +10 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-kbl1/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][35] ([i915#3689] / [i915#3886]) +2 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb8/igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_mc_ccs:
- shard-iclb: NOTRUN -> [SKIP][36] ([fdo#109278] / [i915#3886])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-iclb7/igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-d-bad-rotation-90-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][37] ([i915#3689]) +8 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb5/igt@kms_ccs@pipe-d-bad-rotation-90-yf_tiled_ccs.html

* igt@kms_chamelium@dp-crc-single:
- shard-snb: NOTRUN -> [SKIP][38] ([fdo#109271] / [fdo#111827]) +2 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-snb6/igt@[email protected]

* igt@kms_chamelium@dp-mode-timings:
- shard-glk: NOTRUN -> [SKIP][39] ([fdo#109271] / [fdo#111827]) +4 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-glk8/igt@[email protected]

* igt@kms_chamelium@hdmi-mode-timings:
- shard-kbl: NOTRUN -> [SKIP][40] ([fdo#109271] / [fdo#111827]) +13 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-kbl6/igt@[email protected]

* igt@kms_chamelium@vga-hpd:
- shard-apl: NOTRUN -> [SKIP][41] ([fdo#109271] / [fdo#111827]) +4 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-apl6/igt@[email protected]

* igt@kms_color@pipe-d-gamma:
- shard-iclb: NOTRUN -> [SKIP][42] ([fdo#109278] / [i915#1149])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-iclb1/igt@[email protected]

* igt@kms_color_chamelium@pipe-d-ctm-limited-range:
- shard-tglb: NOTRUN -> [SKIP][43] ([fdo#109284] / [fdo#111827]) +9 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb7/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-tglb: [PASS][44] -> [INCOMPLETE][45] ([i915#2828] / [i915#456])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/shard-tglb2/igt@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb7/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-32x32-onscreen:
- shard-tglb: NOTRUN -> [SKIP][46] ([i915#3319]) +2 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb2/igt@[email protected]

* igt@kms_cursor_crc@pipe-d-cursor-512x170-offscreen:
- shard-tglb: NOTRUN -> [SKIP][47] ([fdo#109279] / [i915#3359]) +5 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb8/igt@[email protected]

* igt@kms_cursor_crc@pipe-d-cursor-512x170-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][48] ([i915#3359]) +3 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb8/igt@[email protected]

* igt@kms_cursor_crc@pipe-d-cursor-64x21-random:
- shard-iclb: NOTRUN -> [SKIP][49] ([fdo#109278]) +7 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-iclb4/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-toggle:
- shard-iclb: [PASS][50] -> [FAIL][51] ([i915#2346])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/shard-iclb8/igt@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-iclb7/igt@[email protected]

* igt@kms_flip@2x-plain-flip:
- shard-iclb: NOTRUN -> [SKIP][52] ([fdo#109274])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-iclb8/igt@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
- shard-glk: NOTRUN -> [SKIP][53] ([fdo#109271] / [i915#2672])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-glk8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move:
- shard-iclb: NOTRUN -> [SKIP][54] ([fdo#109280]) +3 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-iclb1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-pwrite:
- shard-snb: NOTRUN -> [SKIP][55] ([fdo#109271]) +55 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-snb2/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-pwrite.html

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-wc:
- shard-apl: NOTRUN -> [SKIP][56] ([fdo#109271]) +70 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-apl8/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-wc.html

* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-tglb: NOTRUN -> [SKIP][57] ([fdo#111825]) +29 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-mmap-gtt.html

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-kbl: NOTRUN -> [SKIP][58] ([fdo#109271]) +175 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-kbl1/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-cpu.html

* igt@kms_hdr@bpc-switch-suspend:
- shard-kbl: [PASS][59] -> [DMESG-WARN][60] ([i915#180]) +4 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/shard-kbl2/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-kbl3/igt@[email protected]

* igt@kms_hdr@static-toggle:
- shard-tglb: NOTRUN -> [SKIP][61] ([i915#1187])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb6/igt@[email protected]

* igt@kms_pipe_crc_basic@hang-read-crc-pipe-d:
- shard-kbl: NOTRUN -> [SKIP][62] ([fdo#109271] / [i915#533])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-kbl2/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes:
- shard-tglb: [PASS][63] -> [INCOMPLETE][64] ([i915#4182])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/shard-tglb7/igt@kms_plane@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb7/igt@kms_plane@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes:
- shard-apl: [PASS][65] -> [DMESG-WARN][66] ([i915#180]) +2 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/shard-apl2/igt@kms_plane@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-apl3/igt@kms_plane@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-apl: NOTRUN -> [FAIL][67] ([fdo#108145] / [i915#265])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-apl1/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-kbl: NOTRUN -> [FAIL][68] ([fdo#108145] / [i915#265]) +2 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-kbl7/igt@[email protected]

* igt@kms_plane_lowres@pipe-b-tiling-yf:
- shard-tglb: NOTRUN -> [SKIP][69] ([fdo#112054]) +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb3/igt@[email protected]

* igt@kms_plane_lowres@pipe-c-tiling-y:
- shard-tglb: NOTRUN -> [SKIP][70] ([i915#3536])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb8/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3:
- shard-tglb: NOTRUN -> [SKIP][71] ([i915#2920]) +1 similar issue
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb8/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][72] ([fdo#109271] / [i915#658]) +1 similar issue
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-apl7/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][73] ([fdo#109271] / [i915#658]) +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-glk9/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4:
- shard-iclb: NOTRUN -> [SKIP][74] ([i915#658]) +1 similar issue
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-iclb1/igt@[email protected]

* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3:
- shard-kbl: NOTRUN -> [SKIP][75] ([fdo#109271] / [i915#658]) +5 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-kbl1/igt@[email protected]

* igt@kms_psr@psr2_cursor_mmap_gtt:
- shard-tglb: NOTRUN -> [FAIL][76] ([i915#132] / [i915#3467]) +3 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb2/igt@kms_psr@psr2_cursor_mmap_gtt.html

* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [PASS][77] -> [SKIP][78] ([fdo#109441]) +2 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-iclb3/igt@kms_psr@psr2_primary_mmap_cpu.html

* igt@kms_setmode@basic:
- shard-apl: [PASS][79] -> [FAIL][80] ([i915#31])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/shard-apl1/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-apl2/igt@[email protected]

* igt@kms_sysfs_edid_timing:
- shard-kbl: NOTRUN -> [FAIL][81] ([IGT#2])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-kbl3/igt@kms_sysfs_edid_timing.html

* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: NOTRUN -> [DMESG-WARN][82] ([i915#180] / [i915#295])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-kbl4/igt@[email protected]

* igt@kms_vrr@flip-dpms:
- shard-tglb: NOTRUN -> [SKIP][83] ([fdo#109502])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb3/igt@[email protected]

* igt@kms_writeback@writeback-fb-id:
- shard-kbl: NOTRUN -> [SKIP][84] ([fdo#109271] / [i915#2437])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-kbl1/igt@[email protected]

* igt@nouveau_crc@pipe-a-ctx-flip-detection:
- shard-iclb: NOTRUN -> [SKIP][85] ([i915#2530]) +1 similar issue
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-iclb7/igt@[email protected]

* igt@nouveau_crc@pipe-d-source-outp-inactive:
- shard-tglb: NOTRUN -> [SKIP][86] ([i915#2530]) +3 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb6/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][87] ([fdo#109278] / [i915#2530])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-iclb3/igt@[email protected]

* igt@prime_nv_api@i915_nv_import_twice_check_flink_name:
- shard-iclb: NOTRUN -> [SKIP][88] ([fdo#109291])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-iclb8/igt@prime_nv_api@i915_nv_import_twice_check_flink_name.html

* igt@prime_nv_pcopy@test3_1:
- shard-tglb: NOTRUN -> [SKIP][89] ([fdo#109291]) +3 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb5/igt@prime_nv_pcopy@test3_1.html

* igt@prime_vgem@fence-flip-hang:
- shard-iclb: NOTRUN -> [SKIP][90] ([fdo#109295])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-iclb2/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][91] ([fdo#109295])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb5/igt@[email protected]

* igt@sysfs_clients@recycle-many:
- shard-kbl: NOTRUN -> [SKIP][92] ([fdo#109271] / [i915#2994]) +2 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-kbl4/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][93] ([i915#2994])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb1/igt@[email protected]

* igt@sysfs_clients@sema-50:
- shard-glk: NOTRUN -> [SKIP][94] ([fdo#109271] / [i915#2994])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-glk1/igt@[email protected]

#### Possible fixes ####

* igt@gem_ctx_exec@basic-close-race:
- shard-tglb: [INCOMPLETE][95] ([i915#750]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/shard-tglb5/igt@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb7/igt@[email protected]

* igt@gem_ctx_isolation@preservation-s3@vecs0:
- shard-apl: [DMESG-WARN][97] ([i915#180]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/shard-apl8/igt@gem_ctx_isolation@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-apl3/igt@gem_ctx_isolation@[email protected]

* igt@gem_eio@unwedge-stress:
- shard-tglb: [TIMEOUT][99] ([i915#2369] / [i915#3063] / [i915#3648]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/shard-tglb8/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb7/igt@[email protected]

* igt@gem_exec_fair@basic-deadline:
- shard-glk: [FAIL][101] ([i915#2846]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/shard-glk8/igt@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-glk5/igt@[email protected]

* igt@gem_exec_fair@basic-none@vcs0:
- shard-apl: [FAIL][103] ([i915#2842]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/shard-apl6/igt@gem_exec_fair@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-apl8/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@rcs0:
- shard-tglb: [FAIL][105] ([i915#2842]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/shard-tglb8/igt@gem_exec_fair@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb5/igt@gem_exec_fair@[email protected]

* igt@kms_big_fb@linear-32bpp-rotate-180:
- shard-glk: [DMESG-WARN][107] ([i915#118]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/shard-glk8/igt@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-glk2/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [DMESG-WARN][109] ([i915#180]) -> [PASS][110] +4 similar issues
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/shard-kbl7/igt@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-kbl1/igt@[email protected]

* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [INCOMPLETE][111] ([i915#180]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/shard-apl8/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-apl3/igt@[email protected]

* igt@kms_flip@flip-vs-suspend@a-edp1:
- shard-tglb: [INCOMPLETE][113] ([i915#2411] / [i915#456]) -> [PASS][114] +1 similar issue
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/shard-tglb7/igt@kms_flip@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb2/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile:
- shard-iclb: [SKIP][115] ([i915#3701]) -> [PASS][116] +1 similar issue
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/shard-iclb2/igt@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-iclb4/igt@[email protected]

* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [SKIP][117] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/shard-iclb4/igt@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-iclb2/igt@[email protected]

* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [SKIP][119] ([fdo#109441]) -> [PASS][120]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/shard-iclb4/igt@kms_psr@psr2_primary_page_flip.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html

* igt@kms_setmode@basic:
- shard-glk: [FAIL][121] ([i915#31]) -> [PASS][122]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/shard-glk1/igt@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-glk6/igt@[email protected]

* igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
- shard-tglb: [INCOMPLETE][123] ([i915#456]) -> [PASS][124]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/shard-tglb7/igt@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb2/igt@[email protected]

* igt@kms_vblank@pipe-d-ts-continuation-suspend:
- shard-tglb: [INCOMPLETE][125] ([i915#3896]) -> [PASS][126]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/shard-tglb7/igt@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-tglb2/igt@[email protected]

#### Warnings ####

* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-iclb: [FAIL][127] ([i915#2852]) -> [FAIL][128] ([i915#2842])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/shard-iclb5/igt@gem_exec_fair@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-iclb4/igt@gem_exec_fair@[email protected]

* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][129] ([i915#1804] / [i915#2684]) -> [WARN][130] ([i915#2684])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/shard-iclb7/igt@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-iclb5/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-5:
- shard-iclb: [SKIP][131] ([i915#658]) -> [SKIP][132] ([i915#2920])
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/shard-iclb1/igt@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-iclb2/igt@[email protected]

* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1:
- shard-iclb: [SKIP][133] ([i915#2920]) -> [SKIP][134] ([i915#658])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/shard-iclb2/igt@[email protected]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-iclb7/igt@[email protected]

* igt@kms_psr2_su@page_flip:
- shard-iclb: [SKIP][135] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [FAIL][136] ([i915#4148])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10824/shard-iclb3/igt@kms_psr2_su@page_flip.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/shard-iclb2/igt@kms_psr2_su@page_flip.html

* igt@runner@aborted:
- shard-kbl: ([FAIL][137], [FAIL][138], [FAIL][139], [FAIL][140], [FAIL][141], [FAIL][142], [FAIL][143], [FAIL][144], [FAIL][145], [FAIL][146], [FAIL][147]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#3002] / [i915#3363] / [i915#4312] / [i915#92]) -> ([FAIL][148], [FAIL][149], [FAIL][150], [FAIL][151], [FAIL][152], [FAIL][153], [FAIL][154], [FAIL][155], [FAIL][156], [FAIL][157], [FAIL][158]) ([i915#180] / [i915#1814] / [i915#3002] / [i915#3363] / [i915#431

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6366/index.html

#3 lore raw
In reply to Kai Vehmanen

Hi Kai,

Quoted 34 lines · On Monday, 1 November 2021 17:55:43 CET Kai Vehmanen wrote:

The HDA audio driver does not support dynamic hotplug of a HDA codec and that applies also to the display HDA codec.

To test unbind of i915, audio driver must be first unbound and/or unloaded. This is the only way to ensure clean unbind, and possibility to cleanly reestablish connection between audio and i915.

Without this fix, the core_hotunplug test only works if the audio controller is runtime suspended when the test is run. This is very brittle and subject to timing races, differences in system configuration and so forth. A more predictable test is to explicitly unload the audio and in case some entity is using the audio driver, this is flagged with a clear, easily understandable error.

References: https://gitlab.freedesktop.org/drm/intel/-/issues/1602

Cc Uma Shankar <[email protected]>
Cc Janusz Krzysztofik <[email protected]>
---
 tests/core_hotunplug.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

Hello,
I'm from the audio driver team and this is my first contribution to i-g-t. Apologies beforehand for any omissions in following the patch submission, but all guidance in CONTRIBUTING.md should be covered.

For background, this patch addresses a pretty fundamental issue in the unbind test. As of now, the audio driver using DRM component framework (e.g. snd-hda-intel and related), do not support the codec hotplug. This was discussed with audio maintainers in:
https://mailman.alsa-project.org/pipermail/alsa-devel/2021-September/190279.html

Quoted 7 lines

.. and the outcome is that this is not supported now, and as some fundamental pieces are missing, this won't be fully supported any time soon.

So to align with current reality, and to make test execution more predictable, this patch adds a audio driver unload for all i915 platforms.

Before any workaround was introduced to this test, it was triggering a kernel WARN / taint on i915 unbind, but only on selected platforms. Since the test was included into BAT scope, it was affecting badly significant parts of BAT runs, reducing their test coverage. To make the test mode friendly to BAT policy, a workaround was added for affected platforms, and subsequently extended over new platforms as they appeared vulnerable. We also switched from initially selected audio suspend method to audio module unload on your advice. Now your change extends the scope of the current workaround over all platforms. Why do you think we should unload the audio driver on all possible platforms, even on those which didn't suffer from the original issue? Can we have response from current version of the i915 driver to unbind operation tested on trybot with the workaround reverted before we decide if that extension of the workaround scope you propose is really needed?

On the other hand, having platform IDs harcoded into the test is not the best approach. Can we define exact conditions under which the audio driver should be unloaded before i915 unbind and how a test can detect those conditions?

Thanks
Janusz

Quoted 32 lines

Looking forward to your feedback.

Br, Kai

tests/core_hotunplug.c +6 -7
index b366166888cd..900d4886bd13 100644
@@ -621,13 +621,12 @@ igt_main
 		igt_skip_on_f(fd_drm < 0, "No known DRM device found\n");
 
 		if (is_i915_device(fd_drm)) {
-			uint32_t devid = intel_get_drm_devid(fd_drm);
-
-			if ((IS_HASWELL(devid) || IS_BROADWELL(devid) ||
-			     IS_DG1(devid)) && (igt_kmod_is_loaded("snd_hda_intel"))) {
-				igt_debug("Enable WA to unload snd driver\n");
-				priv.snd_unload = true;
-			}
+			/*
+			 * Audio driver does not support hot unplug via DRM
+			 * audio component framework, so driver must be unloaded
+			 * explicitly for i915 unbind tests.
+			 */
+			priv.snd_unload = true;
 
 			gem_quiescent_gpu(fd_drm);
 			igt_require_gem(fd_drm);

base-commit: 3458490c14afe3cb8aa873fa9e520e1c815ea068

#4 lore raw

Hi,

Quoted 8 lines · Janusz Krzysztofik
Quoted 2 lines · On Monday, 1 November 2021 17:55:43 CET Kai Vehmanen wrote:

The HDA audio driver does not support dynamic hotplug of a HDA codec and that applies also to the display HDA codec.

Before any workaround was introduced to this test, it was triggering a kernel WARN / taint on i915 unbind, but only on selected platforms. Since the test was included into BAT scope, it was affecting badly significant parts of BAT runs, reducing their test coverage. To make the test mode friendly to BAT

ack. This issue surfaced on platforms like DG1 where audio controller is on the GPU. Audio driver doesn't support i915 dynamically disappearing, and in case of these hw, failure was easy to hit.

Quoted 3 lines

advice. Now your change extends the scope of the current workaround over all platforms. Why do you think we should unload the audio driver on all possible platforms, even on those which didn't suffer from the original issue? Can we

Even if the symptoms are less severe, the fundamental problem remains. The HDA audio driver is not designed to handle individual codecs (display audio is one of possibly many codecs) disappearing in hotplug fashion. Audio stack does support hotplug for USB and Firewire, but not for individual HDA codecs. This makes sense as the hardware connections are fixed for HDA.

So this creates unnecessary fragility to the test. If any entity in the system uses the audio controller during the i-g-t test, the test can fail -- either a warning about dangling wakeref or something worse. If a distribution changes runtime suspend defaults for audio controller, you will get different results. And you need to maintain a list of PCI IDs where the controller is part of the display hardware (and yo must do the unload).

If we always unload:
- if audio is used by some application -> test is skipped with igt_skip()
- as audio driver us unloaded, no application can start using audio

     while test is running -> more predictable test runs
Quoted 2 lines

approach. Can we define exact conditions under which the audio driver should be unloaded before i915 unbind and how a test can detect those conditions?

I'd say currently the reverse is easier -- if i915 has audio capability, audio driver should be unloaded. And given the priv.snd_unload==true is a no-op on systems with no display audio capability, this simple approach seems to do the job.

I don't say this is perfect, but this would be a more stable baseline to build on.

Br, Kai

Reviewed-by
#5 lore raw
Quoted 44 lines · Kai Vehmanen

Hi,

Quoted 8 lines · Janusz Krzysztofik
Quoted 2 lines · On Monday, 1 November 2021 17:55:43 CET Kai Vehmanen wrote:

The HDA audio driver does not support dynamic hotplug of a HDA codec and that applies also to the display HDA codec.

Before any workaround was introduced to this test, it was triggering a kernel WARN / taint on i915 unbind, but only on selected platforms. Since the test was included into BAT scope, it was affecting badly significant parts of BAT runs, reducing their test coverage. To make the test mode friendly to BAT

ack. This issue surfaced on platforms like DG1 where audio controller is on the GPU. Audio driver doesn't support i915 dynamically disappearing, and in case of these hw, failure was easy to hit.

Quoted 3 lines

advice. Now your change extends the scope of the current workaround over all platforms. Why do you think we should unload the audio driver on all possible platforms, even on those which didn't suffer from the original issue? Can we

Even if the symptoms are less severe, the fundamental problem remains. The HDA audio driver is not designed to handle individual codecs (display audio is one of possibly many codecs) disappearing in hotplug fashion. Audio stack does support hotplug for USB and Firewire, but not for individual HDA codecs. This makes sense as the hardware connections are fixed for HDA.

So this creates unnecessary fragility to the test. If any entity in the system uses the audio controller during the i-g-t test, the test can fail -- either a warning about dangling wakeref or something worse. If a distribution changes runtime suspend defaults for audio controller, you will get different results. And you need to maintain a list of PCI IDs where the controller is part of the display hardware (and yo must do the unload).

If we always unload:
- if audio is used by some application -> test is skipped with igt_skip()
- as audio driver us unloaded, no application can start using audio

    while test is running -> more predictable test runs
Quoted 2 lines

approach. Can we define exact conditions under which the audio driver should be unloaded before i915 unbind and how a test can detect those conditions?

Quoted 7 lines

I'd say currently the reverse is easier -- if i915 has audio capability, audio driver should be unloaded. And given the priv.snd_unload==true is a no-op on systems with no display audio capability, this simple approach seems to do the job.

I don't say this is perfect, but this would be a more stable baseline to build on.

And now we have this issue on almost all platforms because I moved gem_lmem_swapping just before core_hotunplug, and gem_lmem_swapping unloads i915 on exit.

Lucas De Marchi

Quoted 2 lines

Br, Kai