Skip to contentSkip to conversation

main.conf: Fix Privacy modes

PATCH In review Luiz Augusto von Dentz 2 participants 2 messages Nov 1, 2021 Bluetooth drivers

lore
Share & tools
lore

Luiz Augusto von Dentz

author maintainer
#0 lore raw

PATCH 1/1 main.conf: Fix Privacy modes

From: Luiz Augusto von Dentz <[email protected]>

Device privacy 0x01 uses RPA regardless of the discoverable setting thus it conforms to network mode not device mode.

Also this improves documentation to state what is the expectation of each mode since it may not have been very clear by just using the terms from the spec.

---
 src/main.c    |  4 +++-
 src/main.conf | 10 ++++++++--
 2 files changed, 11 insertions(+), 3 deletions(-)
src/main.c +3 -1
index 5ca8d5644..3c9ab231e 100644
@@ -666,8 +666,10 @@ static void parse_config(GKeyFile *config)
 	} else {
 		DBG("privacy=%s", str);
 
-		if (!strcmp(str, "device"))
+		if (!strcmp(str, "network") || !strcmp(str, "on"))
 			btd_opts.privacy = 0x01;
+		if (!strcmp(str, "device"))
+			btd_opts.privacy = 0x02;
 		else if (!strcmp(str, "off"))
 			btd_opts.privacy = 0x00;
 		else {
src/main.conf +8 -2
index e05291d8e..919675185 100644
@@ -67,8 +67,14 @@
 
 # Default privacy setting.
 # Enables use of private address.
-# Possible values: "off", "device", "network"
-# "network" option not supported currently
+# Possible values: "off", "network/on", "device"
+# "network": a device will only accept advertising packets from peer devices
+# that contain private addresses. It may not be compatible with some legacy
+# devices since it requires the use of RPA(s) all the time.
+# "device": A device in device privacy mode is only concerned about the privacy
+# of the device and will accept advertising packets from peer devices that
+# contain their Identity Address as well as ones that contain a private address,
+# even if the peer device has distributed its IRK in the past.
 # Defaults to "off"
 #Privacy = off
 
Signature · 1 line
2.31.1
#1 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=573749

---Test result---

Test Summary:

CheckPatch                    PASS      1.35 seconds
GitLint                       PASS      0.92 seconds
Prep - Setup ELL              PASS      48.90 seconds
Build - Prep                  PASS      0.52 seconds
Build - Configure             PASS      9.21 seconds
Build - Make                  PASS      207.74 seconds
Make Check                    PASS      9.64 seconds
Make Distcheck                PASS      253.13 seconds
Build w/ext ELL - Configure   PASS      9.16 seconds
Build w/ext ELL - Make        PASS      197.45 seconds

---
Regards,
Linux Bluetooth