Skip to contentSkip to conversation

advertising-api: Clarify Duration property

PATCH In review Luiz Augusto von Dentz 2 participants 4 messages Nov 1, 2021 Bluetooth drivers

lore
Share & tools
lore

Luiz Augusto von Dentz

author maintainer
#0 lore raw

PATCH 1/1 advertising-api: Clarify Duration property

From: Luiz Augusto von Dentz <[email protected]>

Duration property refers to the rotation duration not the actual lifetime of the advertising which is controlled by the Timeout property.

---
 doc/advertising-api.txt | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
doc/advertising-api.txt +3 -3
index 6c0e52358..c6ee93450 100644
@@ -120,9 +120,9 @@ Properties	string Type
 
 		uint16_t Duration
 
-			Duration of the advertisement in seconds. If there are
-			other applications advertising no duration is set the
-			default is 2 seconds.
+			Rotation duration of the advertisement in seconds. If
+			there are other applications advertising no duration is
+			set the default is 2 seconds.
 
 		uint16_t Timeout
 
Signature · 1 line
2.31.1
author maintainer
#1 lore raw

PATCH 1/1 mgmt-tester: Add test for Limited/Device Privacy

From: Luiz Augusto von Dentz <[email protected]>

This adds a test for Limited/Device Privacy (0x02):

@ MGMT Command: Set Privacy (0x002f) plen 17

        Privacy: Limited (0x02)
        Key: 01020304050607080102030405060708
@ MGMT Event: Command Complete (0x0001) plen 7
      Set Privacy (0x002f) plen 4
        Status: Success (0x00)
        Current settings: 0x00002080
          BR/EDR
          Privacy
@ MGMT Event: New Settings (0x0006) plen 4
        Current settings: 0x00002080
          BR/EDR
          Privacy
---
 tools/mgmt-tester.c | 33 +++++++++++++++++++++++++--------
 1 file changed, 25 insertions(+), 8 deletions(-)
tools/mgmt-tester.c +25 -8
index 207168291..e9fcb2602 100644
@@ -4136,15 +4136,29 @@ static const struct generic_data load_irks_not_supported_test = {
 	.expect_status = MGMT_STATUS_NOT_SUPPORTED,
 };
 
-static const char set_privacy_valid_param[] = { 0x01,
+static const char set_privacy_1_valid_param[] = { 0x01,
 			0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08,
 			0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08 };
 static const char set_privacy_settings_param[] = { 0x80, 0x20, 0x00, 0x00 };
 
-static const struct generic_data set_privacy_success_test = {
+static const struct generic_data set_privacy_success_1_test = {
 	.send_opcode = MGMT_OP_SET_PRIVACY,
-	.send_param = set_privacy_valid_param,
-	.send_len = sizeof(set_privacy_valid_param),
+	.send_param = set_privacy_1_valid_param,
+	.send_len = sizeof(set_privacy_1_valid_param),
+	.expect_status = MGMT_STATUS_SUCCESS,
+	.expect_param = set_privacy_settings_param,
+	.expect_len = sizeof(set_privacy_settings_param),
+	.expect_settings_set = MGMT_SETTING_PRIVACY,
+};
+
+static const char set_privacy_2_valid_param[] = { 0x02,
+			0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08,
+			0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08 };
+
+static const struct generic_data set_privacy_success_2_test = {
+	.send_opcode = MGMT_OP_SET_PRIVACY,
+	.send_param = set_privacy_2_valid_param,
+	.send_len = sizeof(set_privacy_2_valid_param),
 	.expect_status = MGMT_STATUS_SUCCESS,
 	.expect_param = set_privacy_settings_param,
 	.expect_len = sizeof(set_privacy_settings_param),
@@ -4154,8 +4168,8 @@ static const struct generic_data set_privacy_success_test = {
 static const struct generic_data set_privacy_powered_test = {
 	.setup_settings = settings_powered,
 	.send_opcode = MGMT_OP_SET_PRIVACY,
-	.send_param = set_privacy_valid_param,
-	.send_len = sizeof(set_privacy_valid_param),
+	.send_param = set_privacy_1_valid_param,
+	.send_len = sizeof(set_privacy_1_valid_param),
 	.expect_status = MGMT_STATUS_REJECTED,
 };
 
@@ -13063,8 +13077,11 @@ int main(int argc, char *argv[])
 				&load_irks_not_supported_test,
 				NULL, test_command_generic);
 
-	test_bredrle("Set Privacy - Success",
-				&set_privacy_success_test,
+	test_bredrle("Set Privacy - Success 1",
+				&set_privacy_success_1_test,
+				NULL, test_command_generic);
+	test_bredrle("Set Privacy - Success 2 (Device Mode)",
+				&set_privacy_success_2_test,
 				NULL, test_command_generic);
 	test_bredrle("Set Privacy - Rejected",
 				&set_privacy_powered_test,
Signature · 1 line
2.31.1
#2 lore raw

RE: [BlueZ] mgmt-tester: Add test for Limited/Device Privacy

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=573767

---Test result---

Test Summary:

CheckPatch                    PASS      0.53 seconds
GitLint                       PASS      0.33 seconds
Prep - Setup ELL              PASS      54.47 seconds
Build - Prep                  PASS      0.24 seconds
Build - Configure             PASS      9.89 seconds
Build - Make                  PASS      236.63 seconds
Make Check                    PASS      9.80 seconds
Make Distcheck                PASS      272.03 seconds
Build w/ext ELL - Configure   PASS      9.67 seconds
Build w/ext ELL - Make        PASS      217.11 seconds

---
Regards,
Linux Bluetooth

#3 lore raw
In reply to Luiz Augusto von Dentz

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=573769

---Test result---

Test Summary:

CheckPatch                    PASS      1.51 seconds
GitLint                       PASS      1.00 seconds
Prep - Setup ELL              PASS      41.58 seconds
Build - Prep                  PASS      0.49 seconds
Build - Configure             PASS      7.74 seconds
Build - Make                  PASS      179.29 seconds
Make Check                    PASS      9.63 seconds
Make Distcheck                PASS      213.46 seconds
Build w/ext ELL - Configure   PASS      7.87 seconds
Build w/ext ELL - Make        PASS      170.09 seconds

---
Regards,
Linux Bluetooth