doc: remove deprecation notice for vhost

PATCH Applied Chenbo Xia 3 participants 5 messages Nov 3, 2021

lore

Share & tools

lore

Chenbo Xia

author

2021-11-03 05:17 UTC #0 lore raw

PATCH 1/1 doc: remove deprecation notice for vhost

Ten vhost APIs were announced to be stable and promoted in below commit, so remove the related deprecation notice.

Fixes 945ef8a04098 ("vhost: promote some APIs to stable")

Signed-off-by Chenbo Xia <[email protected]>

Reported-by Maxime Coquelin <[email protected]>

---
 doc/guides/rel_notes/deprecation.rst | 8 --------
 1 file changed, 8 deletions(-)

doc/guides/rel_notes/deprecation.rst +0 -8

index 4366015b01..4f7e95f05f 100644
@@ -114,14 +114,6 @@ Deprecation Notices
 * vhost: rename ``struct vhost_device_ops`` to ``struct rte_vhost_device_ops``
   in DPDK v21.11.
 
-* vhost: The experimental tags of ``rte_vhost_driver_get_protocol_features``,
-  ``rte_vhost_driver_get_queue_num``, ``rte_vhost_crypto_create``,
-  ``rte_vhost_crypto_free``, ``rte_vhost_crypto_fetch_requests``,
-  ``rte_vhost_crypto_finalize_requests``, ``rte_vhost_crypto_set_zero_copy``,
-  ``rte_vhost_va_from_guest_pa``, ``rte_vhost_extern_callback_register``,
-  and ``rte_vhost_driver_set_protocol_features`` functions will be removed
-  and the API functions will be made stable in DPDK 21.11.
-
 * cryptodev: Hide structures ``rte_cryptodev_sym_session`` and
   ``rte_cryptodev_asym_session`` to remove unnecessary indirection between
   session and the private data of session. An opaque pointer can be exposed

Signature · 1 line

2.17.1

Xia, Chenbo

author

2021-11-03 05:25 UTC #1 lore raw

Hi,

I notice that from the start, I should not send the notice.. as the abi policy said:

For removing the experimental tag associated with an API, deprecation notice is not required.

Sorry for the mistake.
/Chenbo

Quoted 42 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Chenbo Xia
Sent: Wednesday, November 3, 2021 1:00 PM
To: [email protected]
Cc: Ray Kinsella <[email protected]>; Kevin Traynor <[email protected]>; Maxime Coquelin <[email protected]>
Subject: [dpdk-dev] [PATCH] doc: remove deprecation notice for vhost
Ten vhost APIs were announced to be stable and promoted in below commit, so remove the related deprecation notice.
Fixes 945ef8a04098 ("vhost: promote some APIs to stable")
Signed-off-by Chenbo Xia <[email protected]>
Reported-by Maxime Coquelin <[email protected]>
---
 doc/guides/rel_notes/deprecation.rst | 8 --------
 1 file changed, 8 deletions(-)
doc/guides/rel_notes/deprecation.rst +0 -0
index 4366015b01..4f7e95f05f 100644
@@ -114,14 +114,6 @@ Deprecation Notices
 * vhost: rename ``struct vhost_device_ops`` to ``struct
rte_vhost_device_ops``
in DPDK v21.11.
doc/guides/rel_notes/deprecation.rst +0 -9
-* vhost: The experimental tags of ``rte_vhost_driver_get_protocol_features``,
-  ``rte_vhost_driver_get_queue_num``, ``rte_vhost_crypto_create``,
-  ``rte_vhost_crypto_free``, ``rte_vhost_crypto_fetch_requests``,
-  ``rte_vhost_crypto_finalize_requests``, ``rte_vhost_crypto_set_zero_copy``,
-  ``rte_vhost_va_from_guest_pa``, ``rte_vhost_extern_callback_register``,
-  and ``rte_vhost_driver_set_protocol_features`` functions will be removed
-  and the API functions will be made stable in DPDK 21.11.
-
 * cryptodev: Hide structures ``rte_cryptodev_sym_session`` and
   ``rte_cryptodev_asym_session`` to remove unnecessary indirection between
   session and the private data of session. An opaque pointer can be exposed
--
2.17.1

David Marchand

2021-11-03 07:03 UTC #2 lore raw

Quoted 8 lines · Chenbo

Hi,
I notice that from the start, I should not send the notice.. as the abi policy said:
For removing the experimental tag associated with an API, deprecation notice is not required.
Sorry for the mistake.

It is not required, but announcing does not hurt.
A real issue would be the opposite :-).

Your patch lgtm, thanks Chenbo.

Signature · 1 line

David Marchand

Maxime Coquelin

Reviewed-by on v1 1/1

2021-11-03 08:08 UTC #3 lore raw

In reply to Chenbo Xia

Quoted 21 lines · Chenbo Xia

Ten vhost APIs were announced to be stable and promoted in below commit, so remove the related deprecation notice.
Fixes 945ef8a04098 ("vhost: promote some APIs to stable")
Signed-off-by Chenbo Xia <[email protected]>
Reported-by Maxime Coquelin <[email protected]>
---
  doc/guides/rel_notes/deprecation.rst | 8 --------
  1 file changed, 8 deletions(-)
doc/guides/rel_notes/deprecation.rst +0 -1
index 4366015b01..4f7e95f05f 100644
@@ -114,14 +114,6 @@ Deprecation Notices
  * vhost: rename ``struct vhost_device_ops`` to ``struct rte_vhost_device_ops``
    in DPDK v21.11.
 
-* vhost: The experimental tags of ``rte_vhost_driver_get_protocol_features``,

doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 119

Quoted 10 lines

doc/guides/rel_notes/deprecation.rst +0 -7

-  ``rte_vhost_driver_get_queue_num``, ``rte_vhost_crypto_create``,
-  ``rte_vhost_crypto_free``, ``rte_vhost_crypto_fetch_requests``,
-  ``rte_vhost_crypto_finalize_requests``, ``rte_vhost_crypto_set_zero_copy``,
-  ``rte_vhost_va_from_guest_pa``, ``rte_vhost_extern_callback_register``,
-  and ``rte_vhost_driver_set_protocol_features`` functions will be removed
-  and the API functions will be made stable in DPDK 21.11.
-
  * cryptodev: Hide structures ``rte_cryptodev_sym_session`` and
    ``rte_cryptodev_asym_session`` to remove unnecessary indirection between
    session and the private data of session. An opaque pointer can be exposed

Reviewed-by Maxime Coquelin <[email protected]>

Thanks,
Maxime

Maxime Coquelin

Applied

2021-11-03 13:47 UTC #4 lore raw

In reply to Chenbo Xia

Quoted 11 lines · Chenbo Xia

Ten vhost APIs were announced to be stable and promoted in below commit, so remove the related deprecation notice.
Fixes 945ef8a04098 ("vhost: promote some APIs to stable")
Signed-off-by Chenbo Xia <[email protected]>
Reported-by Maxime Coquelin <[email protected]>
---
  doc/guides/rel_notes/deprecation.rst | 8 --------
  1 file changed, 8 deletions(-)

Applied to dpdk-next-virtio/main.

Thanks,
Maxime