Skip to contentSkip to conversation

netns_netlink: Ensure tuntap is enabled in kernel

PATCH In review Bogdan Lezhepekov via ltp 2 participants 6 messages Nov 3, 2021 – Nov 4, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 netns_netlink: Ensure tuntap is enabled in kernel

---
 testcases/kernel/containers/netns/netns_netlink.c | 1 +
 1 file changed, 1 insertion(+)
testcases/kernel/containers/netns/netns_netlink.c +1 -0
index ddd8ce910..f9ae255f5 100644
@@ -120,6 +120,7 @@ static struct tst_test test = {
 	.forks_child = 1,
 	.needs_kconfigs = (const char *[]) {
 		"CONFIG_NET_NS=y",
+		"CONFIG_TUN=y",
 		NULL
 	},
 };
Signature · 5 lines
2.33.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw

Hi!

testcases/kernel/containers/netns/netns_netlink.c static struct tst_test test = { · line 123

Quoted 12 lines
 testcases/kernel/containers/netns/netns_netlink.c | 1 +
 1 file changed, 1 insertion(+)
testcases/kernel/containers/netns/netns_netlink.c +1 -0
index ddd8ce910..f9ae255f5 100644
@@ -120,6 +120,7 @@ static struct tst_test test = {
 	.forks_child = 1,
 	.needs_kconfigs = (const char *[]) {
 		"CONFIG_NET_NS=y",
+		"CONFIG_TUN=y",

Shouldn't that be just "CONFIG_TUN" as that would match both "CONFIG_TUN=y" and "CONFIG_TUN=m"?

Signature · 5 lines
Cyril Hrubis
[email protected]

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#2 lore raw

Hi Cyril,

I was missing that it's possible with the test API. Then of course it would be better.

Should I submit V2?

Thanks,
Bogdan

________________________________
From: Cyril Hrubis <[email protected]>
Sent: Thursday, November 4, 2021 15:26
To: Bogdan Lezhepekov <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: [LTP] [PATCH v1] netns_netlink: Ensure tuntap is enabled in kernel

Hi!

testcases/kernel/containers/netns/netns_netlink.c static struct tst_test test = { · line 123

Quoted 12 lines
 testcases/kernel/containers/netns/netns_netlink.c | 1 +
 1 file changed, 1 insertion(+)
testcases/kernel/containers/netns/netns_netlink.c +1 -0
index ddd8ce910..f9ae255f5 100644
@@ -120,6 +120,7 @@ static struct tst_test test = {
       .forks_child = 1,
       .needs_kconfigs = (const char *[]) {
               "CONFIG_NET_NS=y",
+             "CONFIG_TUN=y",

Shouldn't that be just "CONFIG_TUN" as that would match both "CONFIG_TUN=y" and "CONFIG_TUN=m"?

--
Cyril Hrubis
[email protected]

Signature · 2 lines
-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#3 lore raw

Hi!

Quoted 1 line

I was missing that it's possible with the test API. Then of course it would be better.

Actually the config parser implements full boolean expressions :-).

Quoted 1 line

Should I submit V2?

No need, I will remove the =y before applying.

Signature · 5 lines
Cyril Hrubis
[email protected]

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#5 lore raw

Hi,

Thanks a lot!

-Bogdan
________________________________
From: Cyril Hrubis <[email protected]>
Sent: Thursday, November 4, 2021 16:10
To: Bogdan Lezhepekov <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: [LTP] [PATCH v1] netns_netlink: Ensure tuntap is enabled in kernel

Hi!
I've fixed the kconfig line and also added your Signed-off-by and pushed, thanks.

Please make sure that you commit your patches with -s

--
Cyril Hrubis
[email protected]

Signature · 2 lines
-- 
Mailing list info: https://lists.linux.it/listinfo/ltp