clocksource/drivers/exynos_mct: Fix silly typo resulting in checkpatch warning
Subsystems (2)
PATCH 1/1 clocksource/drivers/exynos_mct: Fix silly typo resulting in checkpatch warning
Commit ae460fd9164b ("clocksource/drivers/exynos_mct: Prioritise Arm arch timer on arm64") changed the rating of the MCT clockevents device to be lower than the Arm architected timer and, in the process, replaced a semicolon with a comma thanks to a silly copy-paste error.
Put the semicolon back so that the code looks more idiomatic and resolve the SUSPECT_COMMA_SEMICOLON warning from checkpatch at the same time.
---
Although this doesn't have a functional impact and I'd normally not pay too much attention to checkpatch warnings, the code is pretty weird as-is and I didn't intend for that comma to be there!
drivers/clocksource/exynos_mct.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clocksource/exynos_mct.c +1 -1
@@ -467,7 +467,7 @@ static int exynos4_mct_starting_cpu(unsigned int cpu) evt->tick_resume = set_state_shutdown; evt->features =CLOCK_EVT_FEAT_PERIODIC |CLOCK_EVT_FEAT_ONESHOT |CLOCK_EVT_FEAT_PERCPU ; - evt->rating =MCT_CLKEVENTS_RATING , + evt->rating =MCT_CLKEVENTS_RATING ;exynos4_mct_write (TICK_BASE_CNT , mevt->base +MCT_L_TCNTB_OFFSET );
Signature · 1 line
2.34.0.rc0.344.g81b53c2807-goog
Quoted 11 lines · Will Deacon
Commit
ae460fd9164b("clocksource/drivers/exynos_mct: Prioritise Arm arch timer on arm64") changed the rating of the MCT clockevents device to be lower than the Arm architected timer and, in the process, replaced a semicolon with a comma thanks to a silly copy-paste error.Put the semicolon back so that the code looks more idiomatic and resolve the
SUSPECT_COMMA_SEMICOLONwarning from checkpatch at the same time.Cc Krzysztof Kozlowski <[email protected]>Cc Daniel Lezcano <[email protected]>Signed-off-by Will Deacon <[email protected]>
Quoted 9 lines
---
Although this doesn't have a functional impact and I'd normally not pay too much attention to checkpatch warnings, the code is pretty weird as-is and I didn't intend for that comma to be there!
drivers/clocksource/exynos_mct.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Best regards,
Krzysztof
The following commit has been merged into the timers/core branch of tip:
The following commit has been merged into the timers/core branch of tip:
Commit-ID: 410fbda49cc9b2165e80b87880f164d9644b460d Gitweb: https://git.kernel.org/tip/410fbda49cc9b2165e80b87880f164d9644b460d Author: Will Deacon <[email protected]> AuthorDate: Wed, 03 Nov 2021 16:48:04 Committer: Daniel Lezcano <[email protected]> CommitterDate: Thu, 09 Dec 2021 12:29:52 +01:00
clocksource/drivers/exynos_mct: Fix silly typo resulting in checkpatch warning
Commit ae460fd9164b ("clocksource/drivers/exynos_mct: Prioritise Arm arch timer on arm64") changed the rating of the MCT clockevents device to be lower than the Arm architected timer and, in the process, replaced a semicolon with a comma thanks to a silly copy-paste error.
Put the semicolon back so that the code looks more idiomatic and resolve the SUSPECT_COMMA_SEMICOLON warning from checkpatch at the same time.
--- drivers/clocksource/exynos_mct.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clocksource/exynos_mct.c +1 -1
@@ -467,7 +467,7 @@ static int exynos4_mct_starting_cpu(unsigned int cpu) evt->tick_resume = set_state_shutdown; evt->features =CLOCK_EVT_FEAT_PERIODIC |CLOCK_EVT_FEAT_ONESHOT |CLOCK_EVT_FEAT_PERCPU ; - evt->rating =MCT_CLKEVENTS_RATING , + evt->rating =MCT_CLKEVENTS_RATING ;exynos4_mct_write (TICK_BASE_CNT , mevt->base +MCT_L_TCNTB_OFFSET );