Skip to contentSkip to conversation

config/ppc: fix meson build failure with gcc 4.8.5 on RHEL/CENTOS7

PATCH Applied David Christensen 2 participants 2 messages Nov 3, 2021 – Nov 4, 2021 Arm/Amlogic Meson SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 config/ppc: fix meson build failure with gcc 4.8.5 on RHEL/CENTOS7

The POWER meson.build file incorrectly checks if the detected CPU is "greater than" POWER8 when it should actually test for "greater than or equal to" POWER8. Fixed the comparison operator.

Bugzilla ID: 875

Fixes 750196880843 ("config/ppc: select instruction set for IBM Power10")
---
 config/ppc/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
config/ppc/meson.build +1 -1
index cba8222163..1cba44011f 100644
@@ -89,7 +89,7 @@ int main() {
             else
                 error('Compiler does not support POWER@0@ platform'.format(cpu))
             endif
-            if cpu > 8
+            if cpu >= 8
                 cpu_instruction_set = 'power'+cpu.to_string()
             else
                 error('Compiler does not support POWER@0@ platform'.format(cpu))
Signature · 1 line
2.27.0
#1 lore raw
Quoted 9 lines · David Christensen

The POWER meson.build file incorrectly checks if the detected CPU is "greater than" POWER8 when it should actually test for "greater than or equal to" POWER8. Fixed the comparison operator.

Bugzilla ID: 875

Fixes 750196880843 ("config/ppc: select instruction set for IBM Power10")

Applied, thanks.

Signature · 1 line
David Marchand