Skip to contentSkip to conversation

pinctrl: qcom: sm8350: Correct UFS and SDC offsets

PATCH In review Bjorn Andersson 4 participants 4 messages Nov 4, 2021 – Nov 9, 2021

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pinctrl: qcom: sm8350: Correct UFS and SDC offsets

The downstream TLMM binding covers a group of TLMM-related hardware blocks, but the upstream binding only captures the particular block related to controlling the TLMM pins from an OS. In the translation of the driver from downstream, the offset of 0x100000 was lost for the UFS and SDC pingroups.

Fixes d5d348a3271f ("pinctrl: qcom: Add SM8350 pinctrl driver")
---
 drivers/pinctrl/qcom/pinctrl-sm8350.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/pinctrl/qcom/pinctrl-sm8350.c +4 -4
index 4d8f8636c2b3..1c042d39380c 100644
@@ -1597,10 +1597,10 @@ static const struct msm_pingroup sm8350_groups[] = {
 	[200] = PINGROUP(200, qdss_gpio, _, _, _, _, _, _, _, _),
 	[201] = PINGROUP(201, _, _, _, _, _, _, _, _, _),
 	[202] = PINGROUP(202, _, _, _, _, _, _, _, _, _),
-	[203] = UFS_RESET(ufs_reset, 0x1d8000),
-	[204] = SDC_PINGROUP(sdc2_clk, 0x1cf000, 14, 6),
-	[205] = SDC_PINGROUP(sdc2_cmd, 0x1cf000, 11, 3),
-	[206] = SDC_PINGROUP(sdc2_data, 0x1cf000, 9, 0),
+	[203] = UFS_RESET(ufs_reset, 0xd8000),
+	[204] = SDC_PINGROUP(sdc2_clk, 0xcf000, 14, 6),
+	[205] = SDC_PINGROUP(sdc2_cmd, 0xcf000, 11, 3),
+	[206] = SDC_PINGROUP(sdc2_data, 0xcf000, 9, 0),
 };
 
 static const struct msm_gpio_wakeirq_map sm8350_pdc_map[] = {
Signature · 1 line
2.33.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 22 lines · Bjorn Andersson

The downstream TLMM binding covers a group of TLMM-related hardware blocks, but the upstream binding only captures the particular block related to controlling the TLMM pins from an OS. In the translation of the driver from downstream, the offset of 0x100000 was lost for the UFS and SDC pingroups.

Fixes d5d348a3271f ("pinctrl: qcom: Add SM8350 pinctrl driver")
---
  drivers/pinctrl/qcom/pinctrl-sm8350.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)
drivers/pinctrl/qcom/pinctrl-sm8350.c +0 -1
index 4d8f8636c2b3..1c042d39380c 100644
@@ -1597,10 +1597,10 @@ static const struct msm_pingroup sm8350_groups[] = {
  	[200] = PINGROUP(200, qdss_gpio, _, _, _, _, _, _, _, _),
  	[201] = PINGROUP(201, _, _, _, _, _, _, _, _, _),
  	[202] = PINGROUP(202, _, _, _, _, _, _, _, _, _),
-	[203] = UFS_RESET(ufs_reset, 0x1d8000),

drivers/pinctrl/qcom/pinctrl-sm8350.c static const struct msm_pingroup sm8350_groups[] = { · line 1606

Quoted 10 lines
drivers/pinctrl/qcom/pinctrl-sm8350.c +4 -3
-	[204] = SDC_PINGROUP(sdc2_clk, 0x1cf000, 14, 6),
-	[205] = SDC_PINGROUP(sdc2_cmd, 0x1cf000, 11, 3),
-	[206] = SDC_PINGROUP(sdc2_data, 0x1cf000, 9, 0),
+	[203] = UFS_RESET(ufs_reset, 0xd8000),
+	[204] = SDC_PINGROUP(sdc2_clk, 0xcf000, 14, 6),
+	[205] = SDC_PINGROUP(sdc2_cmd, 0xcf000, 11, 3),
+	[206] = SDC_PINGROUP(sdc2_data, 0xcf000, 9, 0),
  };
 
  static const struct msm_gpio_wakeirq_map sm8350_pdc_map[] = {

--
Best wishes,
Vladimir

Reviewed-by on v1 1/1
#2 lore raw
In reply to Bjorn Andersson
Quoted 18 lines · Bjorn Andersson

The downstream TLMM binding covers a group of TLMM-related hardware blocks, but the upstream binding only captures the particular block related to controlling the TLMM pins from an OS. In the translation of the driver from downstream, the offset of 0x100000 was lost for the UFS and SDC pingroups.

Fixes d5d348a3271f ("pinctrl: qcom: Add SM8350 pinctrl driver")
---
 drivers/pinctrl/qcom/pinctrl-sm8350.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/pinctrl/qcom/pinctrl-sm8350.c +0 -0
index 4d8f8636c2b3..1c042d39380c 100644
@@ -1597,10 +1597,10 @@ static const struct msm_pingroup sm8350_groups[] = {
 	[200] = PINGROUP(200, qdss_gpio, _, _, _, _, _, _, _, _),

drivers/pinctrl/qcom/pinctrl-sm8350.c static const struct msm_pingroup sm8350_groups[] = { · line 1603

Quoted 10 lines
drivers/pinctrl/qcom/pinctrl-sm8350.c +4 -4
 	[201] = PINGROUP(201, _, _, _, _, _, _, _, _, _),
 	[202] = PINGROUP(202, _, _, _, _, _, _, _, _, _),
-	[203] = UFS_RESET(ufs_reset, 0x1d8000),
-	[204] = SDC_PINGROUP(sdc2_clk, 0x1cf000, 14, 6),
-	[205] = SDC_PINGROUP(sdc2_cmd, 0x1cf000, 11, 3),
-	[206] = SDC_PINGROUP(sdc2_data, 0x1cf000, 9, 0),
+	[203] = UFS_RESET(ufs_reset, 0xd8000),
+	[204] = SDC_PINGROUP(sdc2_clk, 0xcf000, 14, 6),
+	[205] = SDC_PINGROUP(sdc2_cmd, 0xcf000, 11, 3),
+	[206] = SDC_PINGROUP(sdc2_data, 0xcf000, 9, 0),

Right, these are the offsets defined in the the documentation, sorry to have missed updating here

Signature · 1 line
~Vinod
#3 lore raw
In reply to Bjorn Andersson
Quoted 8 lines · Bjorn Andersson

The downstream TLMM binding covers a group of TLMM-related hardware blocks, but the upstream binding only captures the particular block related to controlling the TLMM pins from an OS. In the translation of the driver from downstream, the offset of 0x100000 was lost for the UFS and SDC pingroups.

Fixes d5d348a3271f ("pinctrl: qcom: Add SM8350 pinctrl driver")

Patch applied for fixes.

Yours,
Linus Walleij