ci: enable ppc64le cross compilation in GHA

PATCH Superseded David Christensen 2 participants 4 messages Nov 5, 2021 – Nov 10, 2021

lore

Share & tools

lore

David Christensen

author

2021-11-05 20:40 UTC #0 lore raw

PATCH 1/1 ci: enable ppc64le cross compilation in GHA

Enable Github Actions to cross-compile code for POWER systems.

Signed-off-by David Christensen <[email protected]>

---
 .ci/linux-build.sh                      |  6 +++++-
 .github/workflows/build.yml             | 15 ++++++++++++++-
 config/ppc/ppc64le-power8-linux-gcc-GHA | 11 +++++++++++
 3 files changed, 30 insertions(+), 2 deletions(-)
 create mode 100644 config/ppc/ppc64le-power8-linux-gcc-GHA

.ci/linux-build.sh +5 -1

index e1f5255327..52766b3811 100755
@@ -64,6 +64,10 @@ if [ "$AARCH64" = "true" ]; then
     fi
 fi
 
+if [ "$PPC64LE" = "true" ]; then
+    OPTS="$OPTS --cross-file config/ppc/ppc64le-power8-linux-gcc-GHA"
+fi
+
 if [ "$BUILD_DOCS" = "true" ]; then
     OPTS="$OPTS -Denable_docs=true"
 fi

@@ -86,7 +90,7 @@ OPTS="$OPTS -Dcheck_includes=true"
 meson build --werror $OPTS
 ninja -C build
 
-if [ "$AARCH64" != "true" ]; then
+if [ "$AARCH64" != "true" ] && [ "$PPC64LE" != "true" ]; then
     failed=
     configure_coredump
     devtools/test-null.sh || failed="true"

.github/workflows/build.yml +14 -1

index 9cc96121b6..4151cafee7 100644
@@ -21,6 +21,7 @@ jobs:
       CC: ccache ${{ matrix.config.compiler }}
       DEF_LIB: ${{ matrix.config.library }}
       LIBABIGAIL_VERSION: libabigail-1.8
+      PPC64LE: ${{ matrix.config.cross == 'ppc64le' }}
       REF_GIT_TAG: none
       RUN_TESTS: ${{ contains(matrix.config.checks, 'tests') }}

@@ -56,6 +57,14 @@ jobs:
             compiler: gcc
             library: shared
             cross: aarch64
+          - os: ubuntu-18.04
+            compiler: gcc
+            library: static
+            cross: ppc64le
+          - os: ubuntu-18.04
+            compiler: gcc
+            library: shared
+            cross: ppc64le
 
     steps:
     - name: Checkout sources

@@ -107,8 +116,12 @@ jobs:
       if: env.AARCH64 == 'true'
       run: sudo apt install -y gcc-aarch64-linux-gnu libc6-dev-arm64-cross
         pkg-config-aarch64-linux-gnu
+    - name: Install ppc64le cross compiling packages
+      if: env.PPC64LE == 'true'
+      run: sudo apt install -y gcc-powerpc64le-linux-gnu libc6-dev-ppc64el-cross
+        pkg-config-powerpc-linux-gnu
     - name: Install test tools packages
-      if: env.AARCH64 != 'true' || env.RUN_TESTS == 'true'
+      if: env.AARCH64 != 'true' || env.PPC64LE != 'true' || env.RUN_TESTS == 'true'
       run: sudo apt install -y gdb
     - name: Install doc generation packages
       if: env.BUILD_DOCS == 'true'

config/ppc/ppc64le-power8-linux-gcc-GHA new file +11 -0

new file mode 100644
index 0000000000..803c612cbc
@@ -0,0 +1,11 @@
+[binaries]
+c = 'powerpc64le-linux-gnu-gcc'
+cpp = 'powerpc64le-linux-gnu-cpp'
+ar = 'powerpc64le-linux-gnu-ar'
+strip = 'powerpc64le-linux-gnu-strip'
+
+[host_machine]
+system = 'linux'
+cpu_family = 'ppc64'
+cpu = 'power8'
+endian = 'little'

Signature · 1 line

2.27.0

David Marchand

2021-11-08 12:06 UTC #1 lore raw

Quoted 94 lines · David Christensen

Enable Github Actions to cross-compile code for POWER systems.

Signed-off-by David Christensen <[email protected]>

---
 .ci/linux-build.sh                      |  6 +++++-
 .github/workflows/build.yml             | 15 ++++++++++++++-
 config/ppc/ppc64le-power8-linux-gcc-GHA | 11 +++++++++++
 3 files changed, 30 insertions(+), 2 deletions(-)
 create mode 100644 config/ppc/ppc64le-power8-linux-gcc-GHA

.ci/linux-build.sh +5 -1

index e1f5255327..52766b3811 100755
@@ -64,6 +64,10 @@ if [ "$AARCH64" = "true" ]; then
     fi
 fi
 
+if [ "$PPC64LE" = "true" ]; then
+    OPTS="$OPTS --cross-file config/ppc/ppc64le-power8-linux-gcc-GHA"
+fi
+
 if [ "$BUILD_DOCS" = "true" ]; then
     OPTS="$OPTS -Denable_docs=true"
 fi

@@ -86,7 +90,7 @@ OPTS="$OPTS -Dcheck_includes=true"
 meson build --werror $OPTS
 ninja -C build
 
-if [ "$AARCH64" != "true" ]; then
+if [ "$AARCH64" != "true" ] && [ "$PPC64LE" != "true" ]; then
     failed=
     configure_coredump
     devtools/test-null.sh || failed="true"

.github/workflows/build.yml +14 -1

index 9cc96121b6..4151cafee7 100644
@@ -21,6 +21,7 @@ jobs:
       CC: ccache ${{ matrix.config.compiler }}
       DEF_LIB: ${{ matrix.config.library }}
       LIBABIGAIL_VERSION: libabigail-1.8
+      PPC64LE: ${{ matrix.config.cross == 'ppc64le' }}
       REF_GIT_TAG: none
       RUN_TESTS: ${{ contains(matrix.config.checks, 'tests') }}

@@ -56,6 +57,14 @@ jobs:
             compiler: gcc
             library: shared
             cross: aarch64
+          - os: ubuntu-18.04
+            compiler: gcc
+            library: static
+            cross: ppc64le
+          - os: ubuntu-18.04
+            compiler: gcc
+            library: shared
+            cross: ppc64le
 
     steps:
     - name: Checkout sources

@@ -107,8 +116,12 @@ jobs:
       if: env.AARCH64 == 'true'
       run: sudo apt install -y gcc-aarch64-linux-gnu libc6-dev-arm64-cross
         pkg-config-aarch64-linux-gnu
+    - name: Install ppc64le cross compiling packages
+      if: env.PPC64LE == 'true'
+      run: sudo apt install -y gcc-powerpc64le-linux-gnu libc6-dev-ppc64el-cross
+        pkg-config-powerpc-linux-gnu
     - name: Install test tools packages
-      if: env.AARCH64 != 'true' || env.RUN_TESTS == 'true'
+      if: env.AARCH64 != 'true' || env.PPC64LE != 'true' || env.RUN_TESTS == 'true'
       run: sudo apt install -y gdb
     - name: Install doc generation packages
       if: env.BUILD_DOCS == 'true'

config/ppc/ppc64le-power8-linux-gcc-GHA new file +11 -1

new file mode 100644
index 0000000000..803c612cbc
@@ -0,0 +1,11 @@
+[binaries]
+c = 'powerpc64le-linux-gnu-gcc'
+cpp = 'powerpc64le-linux-gnu-cpp'
+ar = 'powerpc64le-linux-gnu-ar'
+strip = 'powerpc64le-linux-gnu-strip'
+
+[host_machine]
+system = 'linux'
+cpu_family = 'ppc64'
+cpu = 'power8'
+endian = 'little'
--

Quoted 2 lines

2.27.0

There is nothing specific to GHA in this cross compilation config file. I would call it config/ppc/ppc64le-power8-linux-gcc-ubuntu1804 (in the same way we have one a config for arm).

The rest lgtm.

Signature · 1 line

David Marchand

David Christensen

author

2021-11-08 17:53 UTC #2 lore raw

PATCH v2 1/1 ci: enable ppc64le cross compilation in GHA

In reply to David Christensen

Enable Github Actions to cross-compile code for POWER systems.

Signed-off-by David Christensen <[email protected]>

Reviewed-by David Marchand <[email protected]>

---
v2 - Changed cross compile filename to be consistent with ARM

 .ci/linux-build.sh                             |  6 +++++-
 .github/workflows/build.yml                    | 15 ++++++++++++++-
 config/ppc/ppc64le-power8-linux-gcc-ubuntu1804 | 11 +++++++++++
 3 files changed, 30 insertions(+), 2 deletions(-)
 create mode 100644 config/ppc/ppc64le-power8-linux-gcc-ubuntu1804

.ci/linux-build.sh +5 -1

index e1f5255327..ef0bd099be 100755
@@ -64,6 +64,10 @@ if [ "$AARCH64" = "true" ]; then
     fi
 fi
 
+if [ "$PPC64LE" = "true" ]; then
+    OPTS="$OPTS --cross-file config/ppc/ppc64le-power8-linux-gcc-ubuntu1804"
+fi
+
 if [ "$BUILD_DOCS" = "true" ]; then
     OPTS="$OPTS -Denable_docs=true"
 fi

@@ -86,7 +90,7 @@ OPTS="$OPTS -Dcheck_includes=true"
 meson build --werror $OPTS
 ninja -C build
 
-if [ "$AARCH64" != "true" ]; then
+if [ "$AARCH64" != "true" ] && [ "$PPC64LE" != "true" ]; then
     failed=
     configure_coredump
     devtools/test-null.sh || failed="true"

.github/workflows/build.yml +14 -1

index 9cc96121b6..4151cafee7 100644
@@ -21,6 +21,7 @@ jobs:
       CC: ccache ${{ matrix.config.compiler }}
       DEF_LIB: ${{ matrix.config.library }}
       LIBABIGAIL_VERSION: libabigail-1.8
+      PPC64LE: ${{ matrix.config.cross == 'ppc64le' }}
       REF_GIT_TAG: none
       RUN_TESTS: ${{ contains(matrix.config.checks, 'tests') }}

@@ -56,6 +57,14 @@ jobs:
             compiler: gcc
             library: shared
             cross: aarch64
+          - os: ubuntu-18.04
+            compiler: gcc
+            library: static
+            cross: ppc64le
+          - os: ubuntu-18.04
+            compiler: gcc
+            library: shared
+            cross: ppc64le
 
     steps:
     - name: Checkout sources

@@ -107,8 +116,12 @@ jobs:
       if: env.AARCH64 == 'true'
       run: sudo apt install -y gcc-aarch64-linux-gnu libc6-dev-arm64-cross
         pkg-config-aarch64-linux-gnu
+    - name: Install ppc64le cross compiling packages
+      if: env.PPC64LE == 'true'
+      run: sudo apt install -y gcc-powerpc64le-linux-gnu libc6-dev-ppc64el-cross
+        pkg-config-powerpc-linux-gnu
     - name: Install test tools packages
-      if: env.AARCH64 != 'true' || env.RUN_TESTS == 'true'
+      if: env.AARCH64 != 'true' || env.PPC64LE != 'true' || env.RUN_TESTS == 'true'
       run: sudo apt install -y gdb
     - name: Install doc generation packages
       if: env.BUILD_DOCS == 'true'

config/ppc/ppc64le-power8-linux-gcc-ubuntu1804 new file +11 -0

new file mode 100644
index 0000000000..803c612cbc
@@ -0,0 +1,11 @@
+[binaries]
+c = 'powerpc64le-linux-gnu-gcc'
+cpp = 'powerpc64le-linux-gnu-cpp'
+ar = 'powerpc64le-linux-gnu-ar'
+strip = 'powerpc64le-linux-gnu-strip'
+
+[host_machine]
+system = 'linux'
+cpu_family = 'ppc64'
+cpu = 'power8'
+endian = 'little'

--
2.27.0

David Marchand

Applied

2021-11-10 11:00 UTC #3 lore raw

Quoted 5 lines · David Christensen

Enable Github Actions to cross-compile code for POWER systems.
Signed-off-by David Christensen <[email protected]>
Reviewed-by David Marchand <[email protected]>

Applied, thanks.

Signature · 1 line

David Marchand