usb: dwc3: gadget: Fix null pointer exception
Subsystems (2)
PATCH v2 1/1 usb: dwc3: gadget: Fix null pointer exception
In the endpoint interrupt functions dwc3_gadget_endpoint_transfer_in_progress() and dwc3_gadget_endpoint_trbs_complete() will dereference the endpoint descriptor. But it could be cleared in __dwc3_gadget_ep_disable() when accessory disconnected. So we need to check whether it is null or not before dereferencing it.
Fixes f09ddcfcb8c5 ("usb: dwc3: gadget: Prevent EP queuing while stopping transfers")
Signed-off-by Albert Wang <[email protected]>
Reviewed-by Jack Pham <[email protected]>
--- drivers/usb/dwc3/gadget.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/usb/dwc3/gadget.c +6 -0
@@ -3252,6 +3252,9 @@ static bool dwc3_gadget_endpoint_trbs_complete(struct dwc3_ep *dep,struct dwc3 *dwc = dep->dwc;bool no_started_trb = true; +if (!dep->endpoint.desc) +return no_started_trb; +dwc3_gadget_ep_cleanup_completed_requests (dep, event, status);if (dep->flags &DWC3_EP_END_TRANSFER_PENDING )
@@ -3299,6 +3302,9 @@ static void dwc3_gadget_endpoint_transfer_in_progress(struct dwc3_ep *dep, {int status =0 ; +if (!dep->endpoint.desc) +return ; +if (usb_endpoint_xfer_isoc (dep->endpoint.desc))dwc3_gadget_endpoint_frame_from_event (dep, event);
Signature · 1 line
2.34.0.rc0.344.g81b53c2807-goog