Skip to contentSkip to conversation

drm/v3d: pass null pointers using NULL

PATCH In review Colin Ian King 2 participants 2 messages Nov 10, 2021 – Nov 11, 2021

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/v3d: pass null pointers using NULL

There are a couple of calls that are passing null pointers as integer zeros rather than NULL. Fix this by using NULL instead.

Fixes 07c2a41658c4 ("drm/v3d: alloc and init job in one shot")
---
 drivers/gpu/drm/v3d/v3d_gem.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/v3d/v3d_gem.c +2 -2
index e47ae40a865a..c7ed2e1cbab6 100644
@@ -774,7 +774,7 @@ v3d_submit_cl_ioctl(struct drm_device *dev, void *data,
 
 	if (args->flags & DRM_V3D_SUBMIT_CL_FLUSH_CACHE) {
 		ret = v3d_job_init(v3d, file_priv, (void *)&clean_job, sizeof(*clean_job),
-				   v3d_job_free, 0, 0, V3D_CACHE_CLEAN);
+				   v3d_job_free, 0, NULL, V3D_CACHE_CLEAN);
 		if (ret)
 			goto fail;
 
@@ -1007,7 +1007,7 @@ v3d_submit_csd_ioctl(struct drm_device *dev, void *data,
 		goto fail;
 
 	ret = v3d_job_init(v3d, file_priv, (void *)&clean_job, sizeof(*clean_job),
-			   v3d_job_free, 0, 0, V3D_CACHE_CLEAN);
+			   v3d_job_free, 0, NULL, V3D_CACHE_CLEAN);
 	if (ret)
 		goto fail;
 
Signature · 1 line
2.32.0
maintainer
#1 lore raw
Quoted 23 lines · Colin Ian King

There are a couple of calls that are passing null pointers as integer zeros rather than NULL. Fix this by using NULL instead.

Fixes 07c2a41658c4 ("drm/v3d: alloc and init job in one shot")
---
 drivers/gpu/drm/v3d/v3d_gem.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/v3d/v3d_gem.c +1 -1
index e47ae40a865a..c7ed2e1cbab6 100644
@@ -774,7 +774,7 @@ v3d_submit_cl_ioctl(struct drm_device *dev, void *data,
 
 	if (args->flags & DRM_V3D_SUBMIT_CL_FLUSH_CACHE) {
 		ret = v3d_job_init(v3d, file_priv, (void *)&clean_job, sizeof(*clean_job),
-				   v3d_job_free, 0, 0, V3D_CACHE_CLEAN);
+				   v3d_job_free, 0, NULL, V3D_CACHE_CLEAN);
 		if (ret)
 			goto fail;
 

drivers/gpu/drm/v3d/v3d_gem.c v3d_submit_csd_ioctl(struct drm_device *dev, void *data, · line 1012

Quoted 7 lines
drivers/gpu/drm/v3d/v3d_gem.c +1 -1
@@ -1007,7 +1007,7 @@ v3d_submit_csd_ioctl(struct drm_device *dev, void *data,
 		goto fail;
 
 	ret = v3d_job_init(v3d, file_priv, (void *)&clean_job, sizeof(*clean_job),
-			   v3d_job_free, 0, 0, V3D_CACHE_CLEAN);
+			   v3d_job_free, 0, NULL, V3D_CACHE_CLEAN);
 	if (ret)
 		goto fail;

Hi Colin,

This fix has been already done:
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=75ad021f21927311b8d454939eb248a50df92525

Thanks, anyway.

Melissa

Quoted 4 lines
Signature · 2 lines
-- 
2.32.0