Skip to contentSkip to conversation

recipe-graphics: Add depends on cmake-native

PATCH Superseded Anibal Limon 3 participants 3 messages Nov 11, 2021

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 recipe-graphics: Add depends on cmake-native

Fixes,

...
File "/home/builds/oe-rpb-master/build-410c/tmp-rpb-glibc/work/cortexa53-linaro-linux/waffle/1.7.0-r0/recipe-sysroot-native/usr/lib/python3.10/site-packages/mesonbuild/modules/cmake.py", line 241, in detect_cmake

    p, stdout, stderr = mesonlib.Popen_safe(cmakebin.get_command() + ['--system-information', '-G', 'Ninja'])[0:3]

File "/home/builds/oe-rpb-master/build-410c/tmp-rpb-glibc/work/cortexa53-linaro-linux/waffle/1.7.0-r0/recipe-sysroot-native/usr/lib/python3.10/site-packages/mesonbuild/mesonlib/universal.py", line 1397, in Popen_safe
p = subprocess.Popen(args, universal_newlines=True, close_fds=False,
File "/home/builds/oe-rpb-master/build-410c/tmp-rpb-glibc/work/cortexa53-linaro-linux/waffle/1.7.0-r0/recipe-sysroot-native/usr/lib/python3.10/subprocess.py", line 966, in __init__
self._execute_child(args, executable, preexec_fn, close_fds,
File "/home/builds/oe-rpb-master/build-410c/tmp-rpb-glibc/work/cortexa53-linaro-linux/waffle/1.7.0-r0/recipe-sysroot-native/usr/lib/python3.10/subprocess.py", line 1717, in _execute_child
and os.path.dirname(executable)
File "/home/builds/oe-rpb-master/build-410c/tmp-rpb-glibc/work/cortexa53-linaro-linux/waffle/1.7.0-r0/recipe-sysroot-native/usr/lib/python3.10/posixpath.py", line 152, in dirname
p = os.fspath(p)
...

---
 meta/recipes-graphics/waffle/waffle_1.7.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-graphics/waffle/waffle_1.7.0.bb +1 -1
index 6284af3076..ea11309940 100644
@@ -17,7 +17,7 @@ S = "${WORKDIR}/git"
 
 inherit meson features_check lib_package bash-completion pkgconfig
 
-DEPENDS:append = " python3"
+DEPENDS:append = " python3 cmake-native"
 
 # This should be overridden per-machine to reflect the capabilities of the GL
 # stack.
Signature · 1 line
2.33.1
#1 lore raw
Quoted 6 lines

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Anibal Limon
Sent: den 11 november 2021 01:44
To: [email protected]
Cc: [email protected]; Aníbal Limón <[email protected]>
Subject: [OE-core] [PATCH] recipe-graphics: Add depends on cmake-native

Change "recipe-graphics" to "waffle".

//Peter

Quoted 36 lines

Fixes,

...
File "/home/builds/oe-rpb-master/build-410c/tmp-rpb-glibc/work/cortexa53-linaro-linux/waffle/1.7.0-r0/recipe-sysroot-native/usr/lib/python3.10/site-packages/mesonbuild/modules/cmake.py", line 241, in detect_cmake

    p, stdout, stderr = mesonlib.Popen_safe(cmakebin.get_command() + ['--system-information', '-G', 'Ninja'])[0:3]

File "/home/builds/oe-rpb-master/build-410c/tmp-rpb-glibc/work/cortexa53-linaro-linux/waffle/1.7.0-r0/recipe-sysroot-native/usr/lib/python3.10/site-packages/mesonbuild/mesonlib/universal.py", line 1397, in Popen_safe
p = subprocess.Popen(args, universal_newlines=True, close_fds=False,
File "/home/builds/oe-rpb-master/build-410c/tmp-rpb-glibc/work/cortexa53-linaro-linux/waffle/1.7.0-r0/recipe-sysroot-native/usr/lib/python3.10/subprocess.py", line 966, in __init__
self._execute_child(args, executable, preexec_fn, close_fds,
File "/home/builds/oe-rpb-master/build-410c/tmp-rpb-glibc/work/cortexa53-linaro-linux/waffle/1.7.0-r0/recipe-sysroot-native/usr/lib/python3.10/subprocess.py", line 1717, in _execute_child
and os.path.dirname(executable)
File "/home/builds/oe-rpb-master/build-410c/tmp-rpb-glibc/work/cortexa53-linaro-linux/waffle/1.7.0-r0/recipe-sysroot-native/usr/lib/python3.10/posixpath.py", line 152, in dirname
p = os.fspath(p)
...

---
 meta/recipes-graphics/waffle/waffle_1.7.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-graphics/waffle/waffle_1.7.0.bb +1 -2
index 6284af3076..ea11309940 100644
@@ -17,7 +17,7 @@ S = "${WORKDIR}/git"
 
 inherit meson features_check lib_package bash-completion pkgconfig
 
-DEPENDS:append = " python3"
+DEPENDS:append = " python3 cmake-native"
 
 # This should be overridden per-machine to reflect the capabilities of the GL
 # stack.
--

2.33.1

#2 lore raw
Quoted 39 lines · Peter Kjellerstedt
Quoted 7 lines

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Anibal Limon
Sent: den 11 november 2021 01:44
To: [email protected]
Cc: [email protected]; Aníbal Limón <[email protected]>
Subject: [OE-core] [PATCH] recipe-graphics: Add depends on cmake-native

Change "recipe-graphics" to "waffle".

//Peter

Quoted 27 lines

Fixes,

...
File "/home/builds/oe-rpb-master/build-410c/tmp-rpb-glibc/work/cortexa53-linaro-linux/waffle/1.7.0-r0/recipe-sysroot-native/usr/lib/python3.10/site-packages/mesonbuild/modules/cmake.py", line 241, in detect_cmake

    p, stdout, stderr = mesonlib.Popen_safe(cmakebin.get_command() + ['--system-information', '-G', 'Ninja'])[0:3]

File "/home/builds/oe-rpb-master/build-410c/tmp-rpb-glibc/work/cortexa53-linaro-linux/waffle/1.7.0-r0/recipe-sysroot-native/usr/lib/python3.10/site-packages/mesonbuild/mesonlib/universal.py", line 1397, in Popen_safe
p = subprocess.Popen(args, universal_newlines=True, close_fds=False,
File "/home/builds/oe-rpb-master/build-410c/tmp-rpb-glibc/work/cortexa53-linaro-linux/waffle/1.7.0-r0/recipe-sysroot-native/usr/lib/python3.10/subprocess.py", line 966, in __init__
self._execute_child(args, executable, preexec_fn, close_fds,
File "/home/builds/oe-rpb-master/build-410c/tmp-rpb-glibc/work/cortexa53-linaro-linux/waffle/1.7.0-r0/recipe-sysroot-native/usr/lib/python3.10/subprocess.py", line 1717, in _execute_child
and os.path.dirname(executable)
File "/home/builds/oe-rpb-master/build-410c/tmp-rpb-glibc/work/cortexa53-linaro-linux/waffle/1.7.0-r0/recipe-sysroot-native/usr/lib/python3.10/posixpath.py", line 152, in dirname
p = os.fspath(p)
...

---
 meta/recipes-graphics/waffle/waffle_1.7.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-graphics/waffle/waffle_1.7.0.bb +0 -0
index 6284af3076..ea11309940 100644
@@ -17,7 +17,7 @@ S = "${WORKDIR}/git"
 
Quoted 4 lines

meta/recipes-graphics/waffle/waffle_1.7.0.bb S = "${WORKDIR}/git" · line 20

Quoted 4 lines
meta/recipes-graphics/waffle/waffle_1.7.0.bb +1 -1
 inherit meson features_check lib_package bash-completion pkgconfig
 
-DEPENDS:append = " python3"
+DEPENDS:append = " python3 cmake-native"

It's unusual for a recipe to add cmake-native to DEPENDS rather than inheriting the cmake class. Your patch comments should probably explain why it's the correct approach.

Quoted 14 lines
Quoted 4 lines
meta/recipes-graphics/waffle/waffle_1.7.0.bb +0 -1
 # This should be overridden per-machine to reflect the capabilities of the GL
 # stack.
--

2.33.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#158126): https://lists.openembedded.org/g/openembedded-core/message/158126
Mute This Topic: https://lists.openembedded.org/mt/86971860/3619030
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-