mm-vmscan-centralise-timeout-values-for-reclaim_throttle.patch removed from -mm tree
The patch titled
Subject: mm/vmscan: centralise timeout values for reclaim_throttle
has been removed from the -mm tree. Its filename was
mm-vmscan-centralise-timeout-values-for-reclaim_throttle.patch
This patch was dropped because it was merged into mainline or a subsystem tree
------------------------------------------------------
From: Mel Gorman <[email protected]>
Subject: mm/vmscan: centralise timeout values for reclaim_throttle
Neil Brown raised concerns about callers of reclaim_throttle specifying a timeout value. The original timeout values to congestion_wait() were probably pulled out of thin air or copy&pasted from somewhere else. This patch centralises the timeout values and selects a timeout based on the reason for reclaim throttling. These figures are also pulled out of the same thin air but better values may be derived
Running a workload that is throttling for inappropriate periods and tracing mm_vmscan_throttled can be used to pick a more appropriate value. Excessive throttling would pick a lower timeout where as excessive CPU usage in reclaim context would select a larger timeout. Ideally a large value would always be used and the wakeups would occur before a timeout but that requires careful testing.
---
mm/compaction.c | 2 - mm/internal.h | 3 -- mm/page-writeback.c | 2 - mm/vmscan.c | 50 +++++++++++++++++++++++++++++++----------- 4 files changed, 40 insertions(+), 17 deletions(-)
mm/compaction.c renamed from mm/compaction.c~mm-vmscan-centralise-timeout-values-for-reclaim_throttle +1 -1
@@ -828,7 +828,7 @@ isolate_migratepages_block(struct compacif (cc->mode ==MIGRATE_ASYNC )return -EAGAIN ; -reclaim_throttle (pgdat,VMSCAN_THROTTLE_ISOLATED ,HZ /10 ); +reclaim_throttle (pgdat,VMSCAN_THROTTLE_ISOLATED );if (fatal_signal_pending (current))return -EINTR ;
mm/internal.h renamed from mm/internal.h~mm-vmscan-centralise-timeout-values-for-reclaim_throttle +1 -2
@@ -130,8 +130,7 @@ extern unsigned long highest_memmap_pfn;*/ extern int isolate_lru_page (struct page *page);extern void putback_lru_page (struct page *page); -extern void reclaim_throttle (pg_data_t *pgdat,enum vmscan_throttle_state reason, -long timeout); +extern void reclaim_throttle (pg_data_t *pgdat,enum vmscan_throttle_state reason);/* * in mm/rmap.c:
mm/page-writeback.c renamed from mm/page-writeback.c~mm-vmscan-centralise-timeout-values-for-reclaim_throttle +1 -1
@@ -2374,7 +2374,7 @@ int do_writepages(struct address_space ** guess as any. */ reclaim_throttle (NODE_DATA (numa_node_id ()), -VMSCAN_THROTTLE_WRITEBACK ,HZ /50 ); +VMSCAN_THROTTLE_WRITEBACK ); }/* * Usually few pages are written by now from those we've just submitted
mm/vmscan.c renamed from mm/vmscan.c~mm-vmscan-centralise-timeout-values-for-reclaim_throttle +37 -13
94 lines not on this page · raw message
_
Patches currently in -mm which might be from [email protected] are