drm/i915/ttm: Async migration
Subsystems (3)
v2 cover drm/i915/ttm: Async migration
This patch series deals with async migration and async vram management. It still leaves an important part out, which is async unbinding which will reduce latency further, at least when trying to migrate already active objects.
Patches 1/6 and 2/6 deal with accessing and waiting for the TTM moving fence from i915 GEM.
Patch 3 is pure code reorganization, no functional change. Patch 4 breaks a refcounting loop involving the TTM moving fence. Patch 5 uses TTM to implement the ttm move() callback async, it also introduces a utility to collect dependencies and turn them into a single dma_fence, which is needed for the intel_migrate code. This also affects the gem object migrate code so.
Patch 6 makes the object copy utility async as well, mainly for future users since the only current user, suspend backup and restore, typically will want to sync anyway.
v2:
- Fix a couple of SPARSE warnings.
Maarten Lankhorst (2):
drm/i915: Add functions to set/get moving fence drm/i915: Add support for asynchronous moving fence waiting
Thomas Hellström (4):
drm/i915/ttm: Move the i915_gem_obj_copy_ttm() function drm/i915/ttm: Break refcounting loops at device region unref time drm/i915/ttm: Implement asynchronous TTM moves drm/i915/ttm: Update i915_gem_obj_copy_ttm() to be asynchronous
drivers/gpu/drm/i915/display/intel_fbdev.c | 7 +- drivers/gpu/drm/i915/display/intel_overlay.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_object.c | 37 ++ drivers/gpu/drm/i915/gem/i915_gem_object.h | 9 + drivers/gpu/drm/i915/gem/i915_gem_pages.c | 6 + drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 58 +-- drivers/gpu/drm/i915/gem/i915_gem_ttm.h | 6 +- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 396 ++++++++++++++++-- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.h | 10 +- drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c | 3 + drivers/gpu/drm/i915/gem/i915_gem_wait.c | 4 +- .../i915/gem/selftests/i915_gem_coherency.c | 4 +- .../drm/i915/gem/selftests/i915_gem_mman.c | 22 +- drivers/gpu/drm/i915/gt/intel_region_lmem.c | 1 + drivers/gpu/drm/i915/i915_vma.c | 39 +- drivers/gpu/drm/i915/i915_vma.h | 3 + drivers/gpu/drm/i915/intel_memory_region.c | 5 +- drivers/gpu/drm/i915/intel_memory_region.h | 1 + drivers/gpu/drm/i915/intel_region_ttm.c | 28 ++ drivers/gpu/drm/i915/intel_region_ttm.h | 2 + drivers/gpu/drm/i915/selftests/i915_vma.c | 4 +- 21 files changed, 538 insertions(+), 109 deletions(-)
Signature · 1 line
2.31.1
PATCH v2 1/6 drm/i915: Add functions to set/get moving fence
From: Maarten Lankhorst <[email protected]>
We want to get rid of i915_vma tracking to simplify the code and lifetimes. Add a way to set/put the moving fence, in preparation for removing the tracking.
--- drivers/gpu/drm/i915/gem/i915_gem_object.c | 37 ++++++++++++++++++++++ drivers/gpu/drm/i915/gem/i915_gem_object.h | 9 ++++++ 2 files changed, 46 insertions(+)
drivers/gpu/drm/i915/gem/i915_gem_object.c +37 -0
@@ -33,6 +33,7 @@#include "i915_gem_object.h" #include "i915_memcpy.h" #include "i915_trace.h" +#include "i915_gem_ttm.h" static struct kmem_cache *slab_objects;
@@ -726,6 +727,42 @@ static const struct drm_gem_object_funcs i915_gem_object_funcs = { .export = i915_gem_prime_export, }; +struct dma_fence * +i915_gem_object_get_moving_fence (struct drm_i915_gem_object *obj) +{ +return dma_fence_get (i915_gem_to_ttm (obj)->moving); +} + +void i915_gem_object_set_moving_fence (struct drm_i915_gem_object *obj, +struct dma_fence *fence) +{ +dma_fence_put (i915_gem_to_ttm (obj)->moving); + +i915_gem_to_ttm (obj)->moving =dma_fence_get (fence); +} + +int i915_gem_object_wait_moving_fence (struct drm_i915_gem_object *obj, +bool intr) +{ +struct dma_fence *fence =i915_gem_to_ttm (obj)->moving; +int ret; + +assert_object_held (obj); +if (!fence) +return 0 ; + + ret =dma_fence_wait (fence, intr); +if (ret) +return ret; + +if (fence->error) +return fence->error; + +i915_gem_to_ttm (obj)->moving =NULL ; +dma_fence_put (fence); +return 0 ; +} +#if IS_ENABLED (CONFIG_DRM_I915_SELFTEST )#include "selftests/huge_gem_object.c" #include "selftests/huge_pages.c"
drivers/gpu/drm/i915/gem/i915_gem_object.h +9 -0
@@ -517,6 +517,15 @@ i915_gem_object_finish_access(struct drm_i915_gem_object *obj)i915_gem_object_unpin_pages (obj); } +struct dma_fence * +i915_gem_object_get_moving_fence (struct drm_i915_gem_object *obj); + +void i915_gem_object_set_moving_fence (struct drm_i915_gem_object *obj, +struct dma_fence *fence); + +int i915_gem_object_wait_moving_fence (struct drm_i915_gem_object *obj, +bool intr); +void i915_gem_object_set_cache_coherency (struct drm_i915_gem_object *obj,unsigned int cache_level);bool i915_gem_object_can_bypass_llc (struct drm_i915_gem_object *obj);
Signature · 1 line
2.31.1
PATCH v2 2/6 drm/i915: Add support for asynchronous moving fence waiting
In reply to Thomas HellströmFrom: Maarten Lankhorst <[email protected]>
For now, we will only allow async migration when TTM is used, so the paths we care about are related to TTM.
The mmap path is handled by having the fence in ttm_bo->moving, when pinning, the binding only becomes available after the moving fence is signaled, and pinning a cpu map will only work after the moving fence signals.
This should close all holes where userspace can read a buffer before it's fully migrated.
v2:
- Fix a couple of SPARSE warnings
--- drivers/gpu/drm/i915/display/intel_fbdev.c | 7 ++-- drivers/gpu/drm/i915/display/intel_overlay.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_pages.c | 6 +++ .../i915/gem/selftests/i915_gem_coherency.c | 4 +- .../drm/i915/gem/selftests/i915_gem_mman.c | 22 ++++++----- drivers/gpu/drm/i915/i915_vma.c | 39 ++++++++++++++++++- drivers/gpu/drm/i915/i915_vma.h | 3 ++ drivers/gpu/drm/i915/selftests/i915_vma.c | 4 +- 8 files changed, 69 insertions(+), 18 deletions(-)
drivers/gpu/drm/i915/display/intel_fbdev.c +4 -3
@@ -265,11 +265,12 @@ static int intelfb_create(struct drm_fb_helper *helper, info->fix.smem_len = vma->node.size; } - vaddr =i915_vma_pin_iomap (vma); + vaddr =i915_vma_pin_iomap_unlocked (vma);if (IS_ERR (vaddr)) { -drm_err (&dev_priv->drm, -"Failed to remap framebuffer into virtual memory\n" ); ret =PTR_ERR (vaddr); +if (ret != -EINTR && ret != -ERESTARTSYS ) +drm_err (&dev_priv->drm, +"Failed to remap framebuffer into virtual memory\n" ); goto out_unpin; } info->screen_base = vaddr;
drivers/gpu/drm/i915/display/intel_overlay.c +1 -1
@@ -1357,7 +1357,7 @@ static int get_registers(struct intel_overlay *overlay, bool use_phys) overlay->flip_addr =sg_dma_address (obj->mm.pages->sgl); else overlay->flip_addr = i915_ggtt_offset(vma); - overlay->regs =i915_vma_pin_iomap (vma); + overlay->regs =i915_vma_pin_iomap_unlocked (vma);i915_vma_unpin (vma);if (IS_ERR (overlay->regs)) {
drivers/gpu/drm/i915/gem/i915_gem_pages.c +6 -0
@@ -418,6 +418,12 @@ void *i915_gem_object_pin_map(struct drm_i915_gem_object *obj, }if (!ptr) { + err =i915_gem_object_wait_moving_fence (obj, true); +if (err) { + ptr =ERR_PTR (err); + goto err_unpin; + } +if (GEM_WARN_ON (type ==I915_MAP_WC && !static_cpu_has (X86_FEATURE_PAT ))) ptr =ERR_PTR (-ENODEV );
drivers/gpu/drm/i915/gem/selftests/i915_gem_coherency.c +2 -2
@@ -101,7 +101,7 @@ static int gtt_set(struct context *ctx, unsigned long offset, u32 v)intel_gt_pm_get (vma->vm->gt); - map =i915_vma_pin_iomap (vma); + map =i915_vma_pin_iomap_unlocked (vma);i915_vma_unpin (vma);if (IS_ERR (map)) { err =PTR_ERR (map);
@@ -134,7 +134,7 @@ static int gtt_get(struct context *ctx, unsigned long offset, u32 *v)intel_gt_pm_get (vma->vm->gt); - map =i915_vma_pin_iomap (vma); + map =i915_vma_pin_iomap_unlocked (vma);i915_vma_unpin (vma);if (IS_ERR (map)) { err =PTR_ERR (map);
drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c +13 -9
@@ -125,12 +125,13 @@ static int check_partial_mapping(struct drm_i915_gem_object *obj, n = page - view.partial.offset;GEM_BUG_ON (n >= view.partial.size); - io =i915_vma_pin_iomap (vma); + io =i915_vma_pin_iomap_unlocked (vma);i915_vma_unpin (vma);if (IS_ERR (io)) { -pr_err ("Failed to iomap partial view: offset=%lu; err=%d\n" , - page, (int )PTR_ERR (io)); err =PTR_ERR (io); +if (err != -EINTR && err != -ERESTARTSYS ) +pr_err ("Failed to iomap partial view: offset=%lu; err=%d\n" , + page, err); goto out; }
@@ -219,12 +220,15 @@ static int check_partial_mappings(struct drm_i915_gem_object *obj, n = page - view.partial.offset;GEM_BUG_ON (n >= view.partial.size); - io =i915_vma_pin_iomap (vma); + io =i915_vma_pin_iomap_unlocked (vma);i915_vma_unpin (vma);if (IS_ERR (io)) { -pr_err ("Failed to iomap partial view: offset=%lu; err=%d\n" , - page, (int )PTR_ERR (io)); -return PTR_ERR (io); +int err =PTR_ERR (io); + +if (err != -EINTR && err != -ERESTARTSYS ) +pr_err ("Failed to iomap partial view: offset=%lu; err=%d\n" , + page, err); +return err; }iowrite32 (page, io + n *PAGE_SIZE /sizeof (*io));
@@ -773,7 +777,7 @@ static int gtt_set(struct drm_i915_gem_object *obj)return PTR_ERR (vma);intel_gt_pm_get (vma->vm->gt); - map =i915_vma_pin_iomap (vma); + map =i915_vma_pin_iomap_unlocked (vma);i915_vma_unpin (vma);if (IS_ERR (map)) { err =PTR_ERR (map);
@@ -799,7 +803,7 @@ static int gtt_check(struct drm_i915_gem_object *obj)return PTR_ERR (vma);intel_gt_pm_get (vma->vm->gt); - map =i915_vma_pin_iomap (vma); + map =i915_vma_pin_iomap_unlocked (vma);i915_vma_unpin (vma);if (IS_ERR (map)) { err =PTR_ERR (map);
drivers/gpu/drm/i915/i915_vma.c +38 -1
@@ -431,6 +431,13 @@ int i915_vma_bind(struct i915_vma *vma, work->pinned =i915_gem_object_get (vma->obj); } }else { +if (vma->obj) { +int ret; + + ret =i915_gem_object_wait_moving_fence (vma->obj, true); +if (ret) +return ret; + } vma->ops->bind_vma (vma->vm,NULL , vma, cache_level, bind_flags); }
@@ -455,6 +462,10 @@ void __iomem *i915_vma_pin_iomap(struct i915_vma *vma) ptr =READ_ONCE (vma->iomap);if (ptr ==NULL ) { + err =i915_gem_object_wait_moving_fence (vma->obj, true); +if (err) + goto err; +/* * TODO: consider just using i915_gem_object_pin_map() for lmem * instead, which already supports mapping non-contiguous chunks
@@ -496,6 +507,25 @@ void __iomem *i915_vma_pin_iomap(struct i915_vma *vma)return IO_ERR_PTR (err); } +void __iomem *i915_vma_pin_iomap_unlocked (struct i915_vma *vma) +{ +struct i915_gem_ww_ctx ww; +void __iomem *map; +int err; + + for_i915_gem_ww(&ww, err, true) { + err =i915_gem_object_lock (vma->obj, &ww); +if (err) +continue ; + + map =i915_vma_pin_iomap (vma); + } +if (err) + map =IO_ERR_PTR (err); + +return map; +} +void i915_vma_flush_writes (struct i915_vma *vma) {if (i915_vma_unset_ggtt_write (vma))
@@ -870,6 +900,7 @@ int i915_vma_pin_ww(struct i915_vma *vma, struct i915_gem_ww_ctx *ww, u64 size, u64 alignment, u64 flags) { struct i915_vma_work *work = NULL; +struct dma_fence *moving =NULL ;intel_wakeref_t wakeref =0 ;unsigned int bound;int err;
@@ -895,7 +926,8 @@ int i915_vma_pin_ww(struct i915_vma *vma, struct i915_gem_ww_ctx *ww,if (flags &PIN_GLOBAL ) wakeref =intel_runtime_pm_get (&vma->vm->i915->runtime_pm); -if (flags & vma->vm->bind_async_flags) { + moving =i915_gem_object_get_moving_fence (vma->obj); +if (flags & vma->vm->bind_async_flags || moving) {/* lock VM */ err =i915_vm_lock_objects (vma->vm, ww);if (err)
@@ -909,6 +941,8 @@ int i915_vma_pin_ww(struct i915_vma *vma, struct i915_gem_ww_ctx *ww, work->vm =i915_vm_get (vma->vm); +dma_fence_work_chain (&work->base, moving); +/* Allocate enough page directories to used PTE */ if (vma->vm->allocate_va_range) { err = i915_vm_alloc_pt_stash(vma->vm,
@@ -1013,7 +1047,10 @@ int i915_vma_pin_ww(struct i915_vma *vma, struct i915_gem_ww_ctx *ww, err_rpm:if (wakeref)intel_runtime_pm_put (&vma->vm->i915->runtime_pm, wakeref); +if (moving) +dma_fence_put (moving);vma_put_pages (vma); +return err; }
drivers/gpu/drm/i915/i915_vma.h +3 -0
@@ -326,6 +326,9 @@ static inline bool i915_node_color_differs(const struct drm_mm_node *node,* Returns a valid iomapped pointer or ERR_PTR. */ void __iomem *i915_vma_pin_iomap (struct i915_vma *vma); + +void __iomem *i915_vma_pin_iomap_unlocked (struct i915_vma *vma); +#define IO_ERR_PTR (x) ((void __iomem *)ERR_PTR(x))/**
drivers/gpu/drm/i915/selftests/i915_vma.c +2 -2
@@ -1005,7 +1005,7 @@ static int igt_vma_remapped_gtt(void *arg)GEM_BUG_ON (vma->ggtt_view.type != *t); - map =i915_vma_pin_iomap (vma); + map =i915_vma_pin_iomap_unlocked (vma);i915_vma_unpin (vma);if (IS_ERR (map)) { err =PTR_ERR (map);
@@ -1036,7 +1036,7 @@ static int igt_vma_remapped_gtt(void *arg)GEM_BUG_ON (vma->ggtt_view.type !=I915_GGTT_VIEW_NORMAL ); - map =i915_vma_pin_iomap (vma); + map =i915_vma_pin_iomap_unlocked (vma);i915_vma_unpin (vma);if (IS_ERR (map)) { err =PTR_ERR (map);
Signature · 1 line
2.31.1
PATCH v2 3/6 drm/i915/ttm: Move the i915_gem_obj_copy_ttm() function
In reply to Thomas HellströmMove the i915_gem_obj_copy_ttm() function to i915_gem_ttm_move.h. This will help keep a number of functions static when introducing async moves.
--- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 47 --------------- drivers/gpu/drm/i915/gem/i915_gem_ttm.h | 4 -- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 63 ++++++++++++++++---- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.h | 10 ++-- drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c | 1 + 5 files changed, 56 insertions(+), 69 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_ttm.c +0 -47
@@ -1063,50 +1063,3 @@ i915_gem_ttm_system_setup(struct drm_i915_private *i915,intel_memory_region_set_name (mr,"system-ttm" );return mr; } - -/** -* i915_gem_obj_copy_ttm - Copy the contents of one ttm-based gem object to -* another -* @dst: The destination object -* @src: The source object -* @allow_accel: Allow using the blitter. Otherwise TTM memcpy is used. -* @intr: Whether to perform waits interruptible: -* -* Note: The caller is responsible for assuring that the underlying -* TTM objects are populated if needed and locked. -* -* Return: Zero on success. Negative error code on error. If @intr == true, -* then it may return -ERESTARTSYS or -EINTR. -*/ -int i915_gem_obj_copy_ttm (struct drm_i915_gem_object *dst, -struct drm_i915_gem_object *src, -bool allow_accel,bool intr) -{ -struct ttm_buffer_object *dst_bo =i915_gem_to_ttm (dst); -struct ttm_buffer_object *src_bo =i915_gem_to_ttm (src); -struct ttm_operation_ctx ctx = { - .interruptible = intr, - }; -struct i915_refct_sgt *dst_rsgt; -int ret; - -assert_object_held (dst); -assert_object_held (src); - -/* -* Sync for now. This will change with async moves. -*/ - ret =ttm_bo_wait_ctx (dst_bo, &ctx); -if (!ret) - ret =ttm_bo_wait_ctx (src_bo, &ctx); -if (ret) -return ret; - - dst_rsgt =i915_ttm_resource_get_st (dst, dst_bo->resource); -__i915_ttm_move (src_bo, false, dst_bo->resource, dst_bo->ttm, - dst_rsgt, allow_accel); - -i915_refct_sgt_put (dst_rsgt); - -return 0 ; -}
drivers/gpu/drm/i915/gem/i915_gem_ttm.h +0 -4
@@ -49,10 +49,6 @@ int __i915_gem_ttm_object_init(struct intel_memory_region *mem,resource_size_t page_size, unsigned int flags); -int i915_gem_obj_copy_ttm (struct drm_i915_gem_object *dst, -struct drm_i915_gem_object *src, -bool allow_accel,bool intr); -/* Internal I915 TTM declarations and definitions below. */ #define I915_PL_LMEM0 TTM_PL_PRIV
drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c +51 -12
72 lines not on this page · raw message
drivers/gpu/drm/i915/gem/i915_gem_ttm_move.h +4 -6
@@ -23,13 +23,11 @@ int i915_ttm_move_notify(struct ttm_buffer_object *bo); I915_SELFTEST_DECLARE(void i915_ttm_migrate_set_failure_modes(bool gpu_migration,bool work_allocation)); -/* Internal I915 TTM declarations and definitions below. */ +int i915_gem_obj_copy_ttm (struct drm_i915_gem_object *dst, +struct drm_i915_gem_object *src, +bool allow_accel,bool intr); -void __i915_ttm_move (struct ttm_buffer_object *bo,bool clear, -struct ttm_resource *dst_mem, -struct ttm_tt *dst_ttm, -struct i915_refct_sgt *dst_rsgt, -bool allow_accel); +/* Internal I915 TTM declarations and definitions below. */ int i915_ttm_move(struct ttm_buffer_object *bo, bool evict, struct ttm_operation_ctx *ctx,
drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c +1 -0
@@ -12,6 +12,7 @@#include "gem/i915_gem_region.h" #include "gem/i915_gem_ttm.h" +#include "gem/i915_gem_ttm_move.h" #include "gem/i915_gem_ttm_pm.h" /**
Signature · 1 line
2.31.1
PATCH v2 4/6 drm/i915/ttm: Break refcounting loops at device region unref time
In reply to Thomas HellströmThere is an interesting refcounting loop:
struct intel_memory_region has a struct ttm_resource_manager, ttm_resource_manager->move may hold a reference to i915_request, i915_request may hold a reference to intel_context, intel_context may hold a reference to drm_i915_gem_object, drm_i915_gem_object may hold a reference to intel_memory_region.
Break this loop when we drop the device reference count on the region by putting the region move fence.
Also hold dropping the device reference count until all objects of the region has been deleted, to avoid issues if proceeding with the device takedown while the region is still present.
--- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 1 + drivers/gpu/drm/i915/gt/intel_region_lmem.c | 1 + drivers/gpu/drm/i915/intel_memory_region.c | 5 +++- drivers/gpu/drm/i915/intel_memory_region.h | 1 + drivers/gpu/drm/i915/intel_region_ttm.c | 28 +++++++++++++++++++++ drivers/gpu/drm/i915/intel_region_ttm.h | 2 ++ 6 files changed, 37 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/gem/i915_gem_ttm.c +1 -0
@@ -1044,6 +1044,7 @@ int __i915_gem_ttm_object_init(struct intel_memory_region *mem,static const struct intel_memory_region_ops ttm_system_region_ops = { .init_object = __i915_gem_ttm_object_init, + .disable = intel_region_ttm_disable, }; struct intel_memory_region *
drivers/gpu/drm/i915/gt/intel_region_lmem.c +1 -0
@@ -108,6 +108,7 @@ region_lmem_init(struct intel_memory_region *mem)static const struct intel_memory_region_ops intel_region_lmem_ops = { .init = region_lmem_init, .release = region_lmem_release, + .disable = intel_region_ttm_disable, .init_object = __i915_gem_ttm_object_init, };
drivers/gpu/drm/i915/intel_memory_region.c +4 -1
@@ -233,8 +233,11 @@ void intel_memory_regions_driver_release(struct drm_i915_private *i915)struct intel_memory_region *region =fetch_and_zero (&i915->mm.regions[i]); -if (region) +if (region) { +if (region->ops->disable) + region->ops->disable (region);intel_memory_region_put (region); + } } }
drivers/gpu/drm/i915/intel_memory_region.h +1 -0
@@ -52,6 +52,7 @@ struct intel_memory_region_ops {int (*init)(struct intel_memory_region *mem);void (*release)(struct intel_memory_region *mem); +void (*disable)(struct intel_memory_region *mem); int (*init_object)(struct intel_memory_region *mem, struct drm_i915_gem_object *obj,
drivers/gpu/drm/i915/intel_region_ttm.c +28 -0
@@ -114,6 +114,34 @@ void intel_region_ttm_fini(struct intel_memory_region *mem) mem->region_private =NULL ; } +/** +* intel_region_ttm_disable - A TTM region disable callback helper +* @mem: The memory region. +* +* A helper that ensures that nothing any longer references a region at +* device takedown. Breaks refcounting loops and waits for objects in the +* region to be deleted. +*/ +void intel_region_ttm_disable (struct intel_memory_region *mem) +{ +struct ttm_resource_manager *man = mem->region_private; + +/* +* Put the region's move fences. This releases requests that +* may hold on to contexts and vms that may hold on to buffer +* objects that may have a refcount on the region. :/ +*/ +if (man) +ttm_resource_manager_cleanup (man); + +/* Flush objects that may just have been freed */ +i915_gem_flush_free_objects (mem->i915); + +/* Wait until the only region reference left is our own. */ +while (kref_read (&mem->kref) >1 ) +msleep (20 ); +} +/** * intel_region_ttm_resource_to_rsgt - * Convert an opaque TTM resource manager resource to a refcounted sg_table.
drivers/gpu/drm/i915/intel_region_ttm.h +2 -0
@@ -22,6 +22,8 @@ int intel_region_ttm_init(struct intel_memory_region *mem);void intel_region_ttm_fini (struct intel_memory_region *mem); +void intel_region_ttm_disable (struct intel_memory_region *mem); +struct i915_refct_sgt *intel_region_ttm_resource_to_rsgt (struct intel_memory_region *mem,struct ttm_resource *res);
Signature · 1 line
2.31.1
PATCH v2 5/6 drm/i915/ttm: Implement asynchronous TTM moves
In reply to Thomas HellströmDon't wait sync while migrating, but rather make the GPU blit await the dependencies and add a moving fence to the object.
This also enables asynchronous VRAM management in that on eviction, rather than waiting for the moving fence to expire before freeing VRAM, it is freed immediately and the fence is stored with the VRAM manager and handed out to newly allocated objects to await before clears and swapins, or for kernel objects before setting up gpu vmas or mapping.
To collect dependencies before migrating, add a set of utilities that coalesce these to a single dma_fence.
What is still missing for fully asynchronous operation is asynchronous vma unbinding, which is still to be implemented.
This commit substantially reduces execution time in the gem_lmem_swapping test.
v2:
- Make a couple of functions static.
--- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 10 + drivers/gpu/drm/i915/gem/i915_gem_ttm.h | 2 +- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 329 +++++++++++++++++-- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 4 +- 4 files changed, 318 insertions(+), 27 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_ttm.c +10 -0
@@ -326,6 +326,9 @@ static bool i915_ttm_eviction_valuable(struct ttm_buffer_object *bo, {struct drm_i915_gem_object *obj =i915_ttm_to_gem (bo); +if (!obj) +return false; +/* * EXTERNAL objects should never be swapped out by TTM, instead we need * to handle that ourselves. TTM will already skip such objects for us,
@@ -448,6 +451,10 @@ static int i915_ttm_shrinker_release_pages(struct drm_i915_gem_object *obj,if (bo->ttm->page_flags &TTM_TT_FLAG_SWAPPED )return 0 ; + ret =ttm_bo_wait_ctx (bo, &ctx); +if (ret) +return ret; + bo->ttm->page_flags |=TTM_TT_FLAG_SWAPPED ; ret =ttm_bo_validate (bo, &place, &ctx);if (ret) {
@@ -549,6 +556,9 @@ static void i915_ttm_swap_notify(struct ttm_buffer_object *bo)struct drm_i915_gem_object *obj =i915_ttm_to_gem (bo);int ret =i915_ttm_move_notify (bo); +if (!obj) +return ; +GEM_WARN_ON (ret);GEM_WARN_ON (obj->ttm.cached_io_rsgt);if (!ret && obj->mm.madv !=I915_MADV_WILLNEED )
drivers/gpu/drm/i915/gem/i915_gem_ttm.h +1 -1
@@ -37,7 +37,7 @@ void i915_ttm_bo_destroy(struct ttm_buffer_object *bo);static inline struct drm_i915_gem_object *i915_ttm_to_gem (struct ttm_buffer_object *bo) { -if (GEM_WARN_ON (bo->destroy != i915_ttm_bo_destroy)) +if (bo->destroy != i915_ttm_bo_destroy)return NULL ; return container_of(bo, struct drm_i915_gem_object, __do_not_access);
drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c +305 -24
419 lines not on this page · raw message
drivers/gpu/drm/i915/gem/i915_gem_wait.c +2 -2
@@ -306,6 +306,6 @@ int i915_gem_object_wait_migration(struct drm_i915_gem_object *obj, unsigned int flags) {might_sleep (); -/* NOP for now. */ -return 0 ; + +return i915_gem_object_wait_moving_fence (obj, !!(flags &I915_WAIT_INTERRUPTIBLE )); }
Signature · 1 line
2.31.1
PATCH v2 6/6 drm/i915/ttm: Update i915_gem_obj_copy_ttm() to be asynchronous
In reply to Thomas HellströmUpdate the copy function i915_gem_obj_copy_ttm() to be asynchronous for future users and update the only current user to sync the objects as needed after this function.
--- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 40 ++++++++++++++------ drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c | 2 + 2 files changed, 30 insertions(+), 12 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c +28 -12
@@ -811,33 +811,49 @@ int i915_gem_obj_copy_ttm(struct drm_i915_gem_object *dst, .interruptible = intr, };struct i915_refct_sgt *dst_rsgt; -struct dma_fence *copy_fence; -int ret; +struct dma_fence *copy_fence, *dep_fence; +struct i915_deps deps; +int ret, shared_err;assert_object_held (dst);assert_object_held (src); +i915_deps_init (&deps,GFP_KERNEL | __GFP_NORETRY | __GFP_NOWARN);/* -* Sync for now. This will change with async moves. +* We plan to add a shared fence only for the source. If that +* fails, we await all source fences before commencing +* the copy instead of only the exclusive. */ - ret =ttm_bo_wait_ctx (dst_bo, &ctx); + shared_err =dma_resv_reserve_shared (src_bo->base.resv,1 ); + ret =i915_deps_add_resv (&deps, dst_bo->base.resv, true, false, &ctx);if (!ret) - ret =ttm_bo_wait_ctx (src_bo, &ctx); + ret =i915_deps_add_resv (&deps, src_bo->base.resv, + !!shared_err, false, &ctx);if (ret)return ret; + dep_fence =i915_deps_to_fence (&deps, &ctx); +if (IS_ERR (dep_fence)) +return PTR_ERR (dep_fence); + dst_rsgt =i915_ttm_resource_get_st (dst, dst_bo->resource); copy_fence =__i915_ttm_move (src_bo, false, dst_bo->resource, - dst_bo->ttm, dst_rsgt, allow_accel,NULL ); + dst_bo->ttm, dst_rsgt, allow_accel, + dep_fence);i915_refct_sgt_put (dst_rsgt); -if (IS_ERR (copy_fence)) -return PTR_ERR (copy_fence); +if (IS_ERR_OR_NULL (copy_fence)) +return PTR_ERR_OR_ZERO (copy_fence); -if (copy_fence) { -dma_fence_wait (copy_fence, false); -dma_fence_put (copy_fence); - } +dma_resv_add_excl_fence (dst_bo->base.resv, copy_fence); + +/* If we failed to reserve a shared slot, add an exclusive fence */ +if (shared_err) +dma_resv_add_excl_fence (src_bo->base.resv, copy_fence); +else +dma_resv_add_shared_fence (src_bo->base.resv, copy_fence); + +dma_fence_put (copy_fence);return 0 ; }
drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c +2 -0
@@ -80,6 +80,7 @@ static int i915_ttm_backup(struct i915_gem_apply_to_region *apply, err =i915_gem_obj_copy_ttm (backup, obj, pm_apply->allow_gpu, false);GEM_WARN_ON (err); +ttm_bo_wait_ctx (backup_bo, &ctx); obj->ttm.backup = backup;return 0 ;
@@ -170,6 +171,7 @@ static int i915_ttm_restore(struct i915_gem_apply_to_region *apply, err =i915_gem_obj_copy_ttm (obj, backup, pm_apply->allow_gpu, false);GEM_WARN_ON (err); +ttm_bo_wait_ctx (backup_bo, &ctx); obj->ttm.backup =NULL ; err =0 ;
Signature · 1 line
2.31.1
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/ttm: Async migration (rev2)
In reply to Thomas Hellström== Series Details ==
== Series Details ==
Series: drm/i915/ttm: Async migration (rev2)
URL : https://patchwork.freedesktop.org/series/96798/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/i915/gt/intel_engine_stats.h:28:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:28:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:28:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:33:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:33:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:51:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:51:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:51:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:57:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:57:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_reset.c:1399:5: warning: context imbalance in 'intel_gt_reset_trylock' - different lock contexts for basic block +drivers/gpu/drm/i915/i915_perf.c:1442:15: warning: memset with byte count of 16777216 +drivers/gpu/drm/i915/i915_perf.c:1496:15: warning: memset with byte count of 16777216 +./include/asm-generic/bitops/find.h:112:45: warning: shift count is negative (-262080) +./include/asm-generic/bitops/find.h:32:31: warning: shift count is negative (-262080) +./include/linux/spinlock.h:418:9: warning: context imbalance in 'fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:418:9: warning: context imbalance in 'fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:418:9: warning: context imbalance in 'fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:418:9: warning: context imbalance in 'fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:418:9: warning: context imbalance in 'fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:418:9: warning: context imbalance in 'fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:418:9: warning: context imbalance in 'fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:418:9: warning: context imbalance in 'gen6_write16' - different lock contexts for basic block +./include/linux/spinlock.h:418:9: warning: context imbalance in 'gen6_write32' - different lock contexts for basic block +./include/linux/spinlock.h:418:9: warning: context imbalance in 'gen6_write8' - different lock contexts for basic block
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/ttm: Async migration (rev2)
In reply to Thomas Hellström== Series Details ==
== Series Details ==
Series: drm/i915/ttm: Async migration (rev2)
URL : https://patchwork.freedesktop.org/series/96798/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10869 -> Patchwork_21561
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_21561 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_21561, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21561/index.html
Participating hosts (39 -> 30)
------------------------------
Additional (2): fi-kbl-x1275 fi-bdw-samus
Missing (11): fi-hsw-gt1 bat-dg1-6 bat-dg1-5 fi-icl-u2 fi-bsw-cyan fi-snb-2520m bat-adlp-4 fi-hsw-4770 fi-ivb-3770 fi-icl-y fi-snb-2600
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_21561:
### CI changes ###
#### Possible regressions ####
* boot:
- fi-bxt-dsi: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10869/fi-bxt-dsi/boot.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21561/fi-bxt-dsi/boot.html
Known issues
------------
Here are the changes found in Patchwork_21561 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_cs_nop@sync-fork-gfx0:
- fi-skl-6600u: NOTRUN -> [SKIP][3] ([fdo#109271]) +17 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21561/fi-skl-6600u/igt@amdgpu/[email protected]
* igt@amdgpu/amd_prime@amd-to-i915:
- fi-kbl-x1275: NOTRUN -> [SKIP][4] ([fdo#109271]) +28 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21561/fi-kbl-x1275/igt@amdgpu/[email protected]
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-1115g4: [PASS][5] -> [FAIL][6] ([i915#1888])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10869/fi-tgl-1115g4/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21561/fi-tgl-1115g4/igt@[email protected]
* igt@gem_huc_copy@huc-copy:
- fi-kbl-x1275: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#2190])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21561/fi-kbl-x1275/igt@[email protected]
* igt@kms_chamelium@hdmi-crc-fast:
- fi-kbl-x1275: NOTRUN -> [SKIP][8] ([fdo#109271] / [fdo#111827]) +8 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21561/fi-kbl-x1275/igt@[email protected]
* igt@kms_chamelium@hdmi-edid-read:
- fi-bdw-samus: NOTRUN -> [SKIP][9] ([fdo#109271] / [fdo#111827]) +8 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21561/fi-bdw-samus/igt@[email protected]
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-bdw-samus: NOTRUN -> [SKIP][10] ([fdo#109271]) +29 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21561/fi-bdw-samus/igt@[email protected]
- fi-kbl-x1275: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#533])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21561/fi-kbl-x1275/igt@[email protected]
#### Possible fixes ####
* igt@i915_pm_rpm@module-reload:
- fi-skl-6600u: [INCOMPLETE][12] ([i915#151]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10869/fi-skl-6600u/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21561/fi-skl-6600u/igt@[email protected]
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
Build changes
-------------
* Linux: CI_DRM_10869 -> Patchwork_21561
CI-20190529: 20190529
CI_DRM_10869: 6f7f448ac677719570bef6ee484d9f94a75c260b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6277: 7201d343fced07a1951feea119480d55bce787e4 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21561: 17f26675f9462aa08513382778b5aabfdbe556d6 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
17f26675f946 drm/i915/ttm: Update i915_gem_obj_copy_ttm() to be asynchronous 68e903393f4b drm/i915/ttm: Implement asynchronous TTM moves 528752afb7ad drm/i915/ttm: Break refcounting loops at device region unref time 388770fd3e54 drm/i915/ttm: Move the i915_gem_obj_copy_ttm() function 9bdb41b60d74 drm/i915: Add support for asynchronous moving fence waiting 98793808b74e drm/i915: Add functions to set/get moving fence
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21561/index.html
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/ttm: Async migration (rev3)
In reply to Thomas Hellström== Series Details ==
== Series Details ==
Series: drm/i915/ttm: Async migration (rev3)
URL : https://patchwork.freedesktop.org/series/96798/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/i915/gt/intel_engine_stats.h:28:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:28:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:28:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:33:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:33:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:51:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:51:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:51:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:57:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:57:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_reset.c:1399:5: warning: context imbalance in 'intel_gt_reset_trylock' - different lock contexts for basic block +drivers/gpu/drm/i915/i915_perf.c:1442:15: warning: memset with byte count of 16777216 +drivers/gpu/drm/i915/i915_perf.c:1496:15: warning: memset with byte count of 16777216 +./include/asm-generic/bitops/find.h:112:45: warning: shift count is negative (-262080) +./include/asm-generic/bitops/find.h:32:31: warning: shift count is negative (-262080) +./include/linux/spinlock.h:418:9: warning: context imbalance in 'fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:418:9: warning: context imbalance in 'fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:418:9: warning: context imbalance in 'fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:418:9: warning: context imbalance in 'fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:418:9: warning: context imbalance in 'fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:418:9: warning: context imbalance in 'fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:418:9: warning: context imbalance in 'fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:418:9: warning: context imbalance in 'gen6_write16' - different lock contexts for basic block +./include/linux/spinlock.h:418:9: warning: context imbalance in 'gen6_write32' - different lock contexts for basic block +./include/linux/spinlock.h:418:9: warning: context imbalance in 'gen6_write8' - different lock contexts for basic block
Patchwork
CI[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/ttm: Async migration (rev3)
In reply to Thomas Hellström== Series Details ==
== Series Details ==
Series: drm/i915/ttm: Async migration (rev3)
URL : https://patchwork.freedesktop.org/series/96798/
State : warning
== Summary ==
$ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_fbc.c:635: warning: Excess function parameter 'i915' description in 'intel_fbc_is_active' ./drivers/gpu/drm/i915/display/intel_fbc.c:1638: warning: Excess function parameter 'i915' description in 'intel_fbc_handle_fifo_underrun_irq' ./drivers/gpu/drm/i915/display/intel_fbc.c:635: warning: Function parameter or member 'fbc' not described in 'intel_fbc_is_active' ./drivers/gpu/drm/i915/display/intel_fbc.c:635: warning: Excess function parameter 'i915' description in 'intel_fbc_is_active' ./drivers/gpu/drm/i915/display/intel_fbc.c:1638: warning: Function parameter or member 'fbc' not described in 'intel_fbc_handle_fifo_underrun_irq' ./drivers/gpu/drm/i915/display/intel_fbc.c:1638: warning: Excess function parameter 'i915' description in 'intel_fbc_handle_fifo_underrun_irq'
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/ttm: Async migration (rev3)
In reply to Thomas Hellström== Series Details ==
== Series Details ==
Series: drm/i915/ttm: Async migration (rev3)
URL : https://patchwork.freedesktop.org/series/96798/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10875 -> Patchwork_21573
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_21573 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_21573, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21573/index.html
Participating hosts (28 -> 33)
------------------------------
Additional (8): fi-bxt-dsi fi-rkl-11600 fi-tgl-dsi fi-bwr-2160 fi-ilk-650 fi-ivb-3770 fi-elk-e7500 fi-snb-2600
Missing (3): fi-bsw-cyan bat-dg1-6 bat-dg1-5
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_21573:
### IGT changes ###
#### Possible regressions ####
* igt@runner@aborted:
- fi-bwr-2160: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21573/fi-bwr-2160/igt@[email protected]
- fi-hsw-4770: NOTRUN -> [FAIL][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21573/fi-hsw-4770/igt@[email protected]
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@runner@aborted:
- {fi-hsw-gt1}: NOTRUN -> [FAIL][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21573/fi-hsw-gt1/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_21573 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_cs_nop@sync-gfx0:
- fi-rkl-11600: NOTRUN -> [SKIP][4] ([fdo#109315]) +17 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21573/fi-rkl-11600/igt@amdgpu/[email protected]
* igt@gem_huc_copy@huc-copy:
- fi-rkl-11600: NOTRUN -> [SKIP][5] ([i915#2190])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21573/fi-rkl-11600/igt@[email protected]
- fi-bxt-dsi: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#2190])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21573/fi-bxt-dsi/igt@[email protected]
* igt@gem_tiled_pread_basic:
- fi-rkl-11600: NOTRUN -> [SKIP][7] ([i915#3282])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21573/fi-rkl-11600/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- fi-rkl-11600: NOTRUN -> [SKIP][8] ([i915#3012])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21573/fi-rkl-11600/igt@[email protected]
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-bxt-dsi: NOTRUN -> [SKIP][9] ([fdo#109271] / [fdo#111827]) +8 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21573/fi-bxt-dsi/igt@[email protected]
* igt@kms_chamelium@dp-crc-fast:
- fi-rkl-11600: NOTRUN -> [SKIP][10] ([fdo#111827]) +8 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21573/fi-rkl-11600/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-rkl-11600: NOTRUN -> [SKIP][11] ([i915#4103]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21573/fi-rkl-11600/igt@[email protected]
* igt@kms_force_connector_basic@force-load-detect:
- fi-bxt-dsi: NOTRUN -> [SKIP][12] ([fdo#109271]) +30 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21573/fi-bxt-dsi/igt@[email protected]
- fi-rkl-11600: NOTRUN -> [SKIP][13] ([fdo#109285] / [i915#4098])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21573/fi-rkl-11600/igt@[email protected]
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-rkl-11600: NOTRUN -> [SKIP][14] ([i915#533])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21573/fi-rkl-11600/igt@[email protected]
- fi-bxt-dsi: NOTRUN -> [SKIP][15] ([fdo#109271] / [i915#533])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21573/fi-bxt-dsi/igt@[email protected]
* igt@kms_psr@primary_mmap_gtt:
- fi-rkl-11600: NOTRUN -> [SKIP][16] ([i915#1072]) +3 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21573/fi-rkl-11600/igt@kms_psr@primary_mmap_gtt.html
* igt@prime_vgem@basic-userptr:
- fi-rkl-11600: NOTRUN -> [SKIP][17] ([i915#3301])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21573/fi-rkl-11600/igt@[email protected]
* igt@prime_vgem@basic-write:
- fi-rkl-11600: NOTRUN -> [SKIP][18] ([i915#3291]) +2 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21573/fi-rkl-11600/igt@[email protected]
* igt@runner@aborted:
- fi-ilk-650: NOTRUN -> [FAIL][19] ([i915#2426])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21573/fi-ilk-650/igt@[email protected]
- fi-snb-2600: NOTRUN -> [FAIL][20] ([i915#2426])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21573/fi-snb-2600/igt@[email protected]
- fi-ivb-3770: NOTRUN -> [FAIL][21] ([i915#2426])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21573/fi-ivb-3770/igt@[email protected]
- fi-elk-e7500: NOTRUN -> [FAIL][22] ([i915#2426])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21573/fi-elk-e7500/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1759]: https://gitlab.freedesktop.org/drm/intel/issues/1759
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2373]: https://gitlab.freedesktop.org/drm/intel/issues/2373
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
Build changes
-------------
* Linux: CI_DRM_10875 -> Patchwork_21573
CI-20190529: 20190529
CI_DRM_10875: f73b8d83650f7b8278b0e166e1aba1024eed4e2e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6280: 246bfd31dba6bf184b26b170d91d72c90a54be6b @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21573: 3aaf1b0e0ac3d74d675500f18bd690da521b05d5 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
3aaf1b0e0ac3 drm/i915/ttm: Update i915_gem_obj_copy_ttm() to be asynchronous 4c7fc751ec87 drm/i915/ttm: Implement asynchronous TTM moves 8cc63ae9bd40 drm/i915/ttm: Break refcounting loops at device region unref time f7e3af3ede4a drm/i915/ttm: Move the i915_gem_obj_copy_ttm() function 74a0f8ed7aee drm/i915: Add support for asynchronous moving fence waiting 3f5f54b7e691 drm/i915: Add functions to set/get moving fence
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21573/index.html