Skip to contentSkip to conversation

platform/x86: dell-wmi-descriptor: disable by default

PATCH In review Thomas Weißschuh 2 participants 2 messages Nov 13, 2021 – Nov 16, 2021 x86 platform drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 platform/x86: dell-wmi-descriptor: disable by default

dell-wmi-descriptor only provides symbols to other drivers. These drivers already select dell-wmi-descriptor when needed.

This fixes an issue where dell-wmi-descriptor is compiled as a module with localyesconfig on a non-Dell machine.

---
 drivers/platform/x86/dell/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/dell/Kconfig +1 -1
index 821aba31821c..dbc71a936339 100644
@@ -187,7 +187,7 @@ config DELL_WMI_AIO
 
 config DELL_WMI_DESCRIPTOR
 	tristate
-	default m
+	default n
 	depends on ACPI_WMI
 
 config DELL_WMI_LED

base-commit: 6880fa6c56601bb8ed59df6c30fd390cc5f6dd8f

Signature · 1 line
2.33.1
#1 lore raw

Hi,

Quoted 7 lines · Thomas Weißschuh

dell-wmi-descriptor only provides symbols to other drivers. These drivers already select dell-wmi-descriptor when needed.

This fixes an issue where dell-wmi-descriptor is compiled as a module with localyesconfig on a non-Dell machine.

Thank you for your patch, I've applied this patch to my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window.

Regards,

Hans

Quoted 20 lines
---
 drivers/platform/x86/dell/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/dell/Kconfig +1 -1
index 821aba31821c..dbc71a936339 100644
@@ -187,7 +187,7 @@ config DELL_WMI_AIO
 
 config DELL_WMI_DESCRIPTOR
 	tristate
-	default m
+	default n
 	depends on ACPI_WMI
 
 config DELL_WMI_LED

base-commit: 6880fa6c56601bb8ed59df6c30fd390cc5f6dd8f