Skip to contentSkip to conversation

leds: led-core: Update fwnode with device_set_node

PATCH Applied Sander Vanheule 2 participants 2 messages Nov 13, 2021 – Nov 15, 2021 LED

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 leds: led-core: Update fwnode with device_set_node

Update a newly created device's fwnode and of_node pointers using the recently added device_set_node helper. This keeps some firmware node specifics out of led-class and should help tracking future changes regarding device firmware node updates.

---
 drivers/leds/led-class.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/leds/led-class.c +2 -4
index f4bb02f6e042..6a8ea94834fa 100644
@@ -375,10 +375,8 @@ int led_classdev_register_ext(struct device *parent,
 		mutex_unlock(&led_cdev->led_access);
 		return PTR_ERR(led_cdev->dev);
 	}
-	if (init_data && init_data->fwnode) {
-		led_cdev->dev->fwnode = init_data->fwnode;
-		led_cdev->dev->of_node = to_of_node(init_data->fwnode);
-	}
+	if (init_data && init_data->fwnode)
+		device_set_node(led_cdev->dev, init_data->fwnode);
 
 	if (ret)
 		dev_warn(parent, "Led %s renamed to %s due to name collision",
Signature · 1 line
2.33.1
Applied
#1 lore raw
Quoted 6 lines · Sander Vanheule

Update a newly created device's fwnode and of_node pointers using the recently added device_set_node helper. This keeps some firmware node specifics out of led-class and should help tracking future changes regarding device firmware node updates.

Thanks, applied.
Pavel

Quoted 23 lines
---
 drivers/leds/led-class.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/leds/led-class.c +2 -4
index f4bb02f6e042..6a8ea94834fa 100644
@@ -375,10 +375,8 @@ int led_classdev_register_ext(struct device *parent,
 		mutex_unlock(&led_cdev->led_access);
 		return PTR_ERR(led_cdev->dev);
 	}
-	if (init_data && init_data->fwnode) {
-		led_cdev->dev->fwnode = init_data->fwnode;
-		led_cdev->dev->of_node = to_of_node(init_data->fwnode);
-	}
+	if (init_data && init_data->fwnode)
+		device_set_node(led_cdev->dev, init_data->fwnode);
 
 	if (ret)
 		dev_warn(parent, "Led %s renamed to %s due to name collision",
Signature · 1 line
2.33.1
Signature · 1 line
http://www.livejournal.com/~pavelmachek