Skip to contentSkip to conversation

scsi:elx: fix cond_no_effect.cocci warnings

PATCH In review [email protected] 2 participants 2 messages Nov 15, 2021 – Nov 30, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi:elx: fix cond_no_effect.cocci warnings

From: chiminghao <[email protected]>

Fix the following coccicheck WARNING:
./drivers/scsi/elx/libefc_sli/sli4.c, 2320, 2-4, WARNING possible condition with no effect (if == else)

---
 drivers/scsi/elx/libefc_sli/sli4.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
drivers/scsi/elx/libefc_sli/sli4.c +2 -6
index 907d67aeac23..b74065a4e5c1 100644
@@ -2317,12 +2317,8 @@ sli_xmit_bls_rsp64_wqe(struct sli4 *sli, void *buf,
 		SLI4_GENERIC_CONTEXT_VPI << SLI4_BLS_RSP_WQE_CT_SHFT;
 		bls->context_tag = cpu_to_le16(params->vpi);
 
-		if (params->s_id != U32_MAX)
-			bls->local_n_port_id_dword |=
-				cpu_to_le32(params->s_id & 0x00ffffff);
-		else
-			bls->local_n_port_id_dword |=
-				cpu_to_le32(params->s_id & 0x00ffffff);
+		bls->local_n_port_id_dword |=
+			cpu_to_le32(params->s_id & 0x00ffffff);
 
 		dw_ridflags = (dw_ridflags & ~SLI4_BLS_RSP_RID) |
 			       (params->d_id & SLI4_BLS_RSP_RID);
Signature · 1 line
2.25.1
#1 lore raw
Quoted 6 lines

From: chiminghao <[email protected]>

Fix the following coccicheck WARNING:
./drivers/scsi/elx/libefc_sli/sli4.c, 2320, 2-4, WARNING possible condition with no effect (if == else)

The patch attribution is confusing.

Patch was submitted by <[email protected]> but there is no signoff tag reflecting this.

Quoted 1 line

.cm?

Quoted 1 line
Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering