scsi:elx: fix cond_no_effect.cocci warnings
Subsystems (3)
PATCH 1/1 scsi:elx: fix cond_no_effect.cocci warnings
From: chiminghao <[email protected]>
Fix the following coccicheck WARNING:./drivers/scsi/elx/libefc_sli/sli4.c, 2320, 2-4, WARNING possible condition with no effect (if == else)
Reported-by Zeal Robot <[email protected]>
Signed-off-by chiminghao <[email protected]>
--- drivers/scsi/elx/libefc_sli/sli4.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
drivers/scsi/elx/libefc_sli/sli4.c +2 -6
@@ -2317,12 +2317,8 @@ sli_xmit_bls_rsp64_wqe(struct sli4 *sli, void *buf,SLI4_GENERIC_CONTEXT_VPI <<SLI4_BLS_RSP_WQE_CT_SHFT ; bls->context_tag =cpu_to_le16 (params->vpi); -if (params->s_id !=U32_MAX ) - bls->local_n_port_id_dword |= -cpu_to_le32 (params->s_id &0x00ffffff ); -else - bls->local_n_port_id_dword |= -cpu_to_le32 (params->s_id &0x00ffffff ); + bls->local_n_port_id_dword |= +cpu_to_le32 (params->s_id &0x00ffffff ); dw_ridflags = (dw_ridflags & ~SLI4_BLS_RSP_RID ) | (params->d_id &SLI4_BLS_RSP_RID );
Signature · 1 line
2.25.1
Quoted 6 lines
From: chiminghao <[email protected]>
Fix the following coccicheck WARNING:
./drivers/scsi/elx/libefc_sli/sli4.c, 2320, 2-4, WARNING possible condition with no effect (if == else)
The patch attribution is confusing.
Patch was submitted by <[email protected]> but there is no signoff tag reflecting this.
Quoted 1 line
Reported-by Zeal Robot <[email protected]>
.cm?
Quoted 1 line
Signed-off-by chiminghao <[email protected]>
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering