Skip to contentSkip to conversation

app/testpmd: avoid the process ID out of range

PATCH Applied Haiyue Wang 3 participants 3 messages Nov 15, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 app/testpmd: avoid the process ID out of range

The 'proc-id' should be less than 'num-procs', if not, exit the testpmd and show the error message.

Fixes a550baf24af9 ("app/testpmd: support multi-process")
---
 app/test-pmd/parameters.c | 6 ++++++
 1 file changed, 6 insertions(+)
app/test-pmd/parameters.c +6 -0
index 0974b0a38f..5251722d0f 100644
@@ -1527,6 +1527,12 @@ launch_args_parse(int argc, char** argv)
 		rte_exit(EXIT_FAILURE, "Command line is incorrect\n");
 	}
 
+	if (proc_id >= (int)num_procs)
+		rte_exit(EXIT_FAILURE,
+			 "The multi-process option '%s(%d)' should be less than '%s(%u)'\n",
+			 PARAM_PROC_ID, proc_id,
+			 PARAM_NUM_PROCS, num_procs);
+
 	/* Set offload configuration from command line parameters. */
 	rx_mode.offloads = rx_offloads;
 	tx_mode.offloads = tx_offloads;
Signature · 1 line
2.33.1
Acked-by on v1 1/1
#1 lore raw
Quoted 28 lines · Haiyue Wang

The 'proc-id' should be less than 'num-procs', if not, exit the testpmd and show the error message.

Fixes a550baf24af9 ("app/testpmd: support multi-process")
---
  app/test-pmd/parameters.c | 6 ++++++
  1 file changed, 6 insertions(+)
app/test-pmd/parameters.c +6 -0
index 0974b0a38f..5251722d0f 100644
@@ -1527,6 +1527,12 @@ launch_args_parse(int argc, char** argv)
  		rte_exit(EXIT_FAILURE, "Command line is incorrect\n");
  	}
 
+	if (proc_id >= (int)num_procs)
+		rte_exit(EXIT_FAILURE,
+			 "The multi-process option '%s(%d)' should be less than '%s(%u)'\n",
+			 PARAM_PROC_ID, proc_id,
+			 PARAM_NUM_PROCS, num_procs);
+
  	/* Set offload configuration from command line parameters. */
  	rx_mode.offloads = rx_offloads;
  	tx_mode.offloads = tx_offloads;