package/psplash: bump to revision 44afb75
PATCH v2 1/2 package/psplash: bump to revision 44afb75
This includes the following changes:
44afb75 Add configure options to disable progress bar fdbd111 Improve warnings from probing for double buffering f5203fd Update mailing list details since the move to groups.io 0a902f7 Fix psplash-systemd failures
4cf1330 Remove generated psplash-poky-img.h
aea172a Makefile.am: Fix out of tree builds
--- package/psplash/psplash.hash | 2 +- package/psplash/psplash.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
package/psplash/psplash.hash +1 -1
@@ -1,3 +1,3 @@ # Locally computed -sha256 2c1344dd8414415d80a01484b1cc29e78f99c31d5266189540e5966a7dc6e10e psplash-fd33a9b3d68c89fa22ff6873f4f9fd28bd85830c-br1.tar.gz +sha256 c9f71754f4606e46212a4851d6c1145e4ae8752fd11a2b40e825f04bf79b22ec psplash-44afb7506d43cca15582b4c5b90ba5580344d75d-br1.tar.gz sha256 f9c375a1be4a41f7b70301dd83c91cb89e41567478859b77eef375a52d782505 COPYING
package/psplash/psplash.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -PSPLASH_VERSION = fd33a9b3d68c89fa22ff6873f4f9fd28bd85830c +PSPLASH_VERSION = 44afb7506d43cca15582b4c5b90ba5580344d75d PSPLASH_SITE = git://git.yoctoproject.org/psplash PSPLASH_LICENSE = GPL-2.0+ PSPLASH_LICENSE_FILES = COPYING
Signature · 6 lines
2.25.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
PATCH v2 2/2 package/psplash: add support to missing configure options
Add support to three configure options:
--disable-startup-msg: Disable text banner output on startup --disable-progress-bar: Disable progress bar --enable-img-fullscreen: Enable the logo image in fullscreen mode
---
Change since v1:
Remove the crap .config.in.swp
package/psplash/Config.in | 15 +++++++++++++++ package/psplash/psplash.mk | 12 ++++++++++++ 2 files changed, 27 insertions(+)
package/psplash/Config.in +15 -0
@@ -35,6 +35,21 @@ config BR2_PACKAGE_PSPLASH_IMAGE Use a personalized png image as boot splash. Let it empty if you want to keep the psplash default image. +config BR2_PACKAGE_PSPLASH_FULL_SCREEN + bool "use fullscreen mode" + help + Enable the psplash image in fullscreen mode. + +config BR2_PACKAGE_PSPLASH_NO_STARTUP_MSG + bool "disable startup message" + help + Disable text banner output on startup. + +config BR2_PACKAGE_PSPLASH_NO_PROGRESS_BAR + bool "disable progress bar" + help + Disable the management of the progress bar. + endif comment "psplash needs a toolchain w/ wchar"
package/psplash/psplash.mk +12 -0
@@ -18,6 +18,18 @@ else PSPLASH_CONF_OPTS += --without-systemd endif +ifeq ($(BR2_PACKAGE_PSPLASH_FULL_SCREEN),y) +PSPLASH_CONF_OPTS += --enable-img-fullscreen +endif + +ifeq ($(BR2_PACKAGE_PSPLASH_NO_STARTUP_MSG),y) +PSPLASH_CONF_OPTS += --disable-startup-msg +endif + +ifeq ($(BR2_PACKAGE_PSPLASH_NO_PROGRESS_BAR),y) +PSPLASH_CONF_OPTS += --disable-progress-bar +endif + PSPLASH_IMAGE = $(call qstrip,$(BR2_PACKAGE_PSPLASH_IMAGE)) ifneq ($(PSPLASH_IMAGE),)
Signature · 6 lines
2.25.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Re: [Buildroot] [PATCH v2 2/2] package/psplash: add support to missing configure options
Hello,
Quoted 1 line · On Mon, 15 Nov 2021 16:26:04 +0100 Kory Maincent <[email protected]>…
Add support to three configure options:
Here and in the commit title: "Add support *for*" (not to)
Quoted 7 lines
package/psplash/Config.in +0
-0@@ -35,6 +35,21 @@ config BR2_PACKAGE_PSPLASH_IMAGE Use a personalized png image as boot splash. Let it empty if you want to keep the psplash default image.
package/psplash/Config.in config BR2_PACKAGE_PSPLASH_IMAGE · line 46
Quoted 10 lines
package/psplash/Config.in +9
-0+config BR2_PACKAGE_PSPLASH_FULL_SCREEN + bool "use fullscreen mode" + help + Enable the psplash image in fullscreen mode. + +config BR2_PACKAGE_PSPLASH_NO_STARTUP_MSG + bool "disable startup message" + help + Disable text banner output on startup.
Please use positive logic in options, i.e options should "enable" something, not "disable" something. If the previous default (when the option didn't exist) was to have it enabled, add a "default y" in the Config.in option so that it remains enabled by default.
package/psplash/Config.in config BR2_PACKAGE_PSPLASH_IMAGE · line 51
Quoted 5 lines
package/psplash/Config.in +5
-0+ +config BR2_PACKAGE_PSPLASH_NO_PROGRESS_BAR + bool "disable progress bar" + help + Disable the management of the progress bar.
Same.
package/psplash/Config.in config BR2_PACKAGE_PSPLASH_IMAGE · line 54
Quoted 3 lines
package/psplash/Config.in +3
-0+ifeq ($(BR2_PACKAGE_PSPLASH_FULL_SCREEN),y) +PSPLASH_CONF_OPTS += --enable-img-fullscreen +endif
We like to have both sides of the condition, i.e:
ifeq ($(BR2_PACKAGE_PSPLASH_FULL_SCREEN),y)PSPLASH_CONF_OPTS += --enable-img-fullscreen
elsePSPLASH_CONF_OPTS += --disable-img-fullscreen
endif
Best regards,
Thomas
Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Thomas Petazzoni
AppliedQuoted 9 lines · On Mon, 15 Nov 2021 16:26:03 +0100 Kory Maincent <[email protected]>…
This includes the following changes:
44afb75 Add configure options to disable progress bar fdbd111 Improve warnings from probing for double buffering f5203fd Update mailing list details since the move to groups.io 0a902f7 Fix psplash-systemd failures
4cf1330 Remove generatedpsplash-poky-img.h
aea172a Makefile.am: Fix out of tree builds
Quoted 5 lines
Signed-off-by Kory Maincent <[email protected]>--- package/psplash/psplash.hash | 2 +- package/psplash/psplash.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
Applied to next, thanks.
Thomas
Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot