Skip to contentSkip to conversation

package/psplash: bump to revision 44afb75

PATCH Superseded Kory Maincent 5 participants 9 messages Nov 15, 2021

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 package/psplash: bump to revision 44afb75

This includes the following changes:

44afb75 Add configure options to disable progress bar fdbd111 Improve warnings from probing for double buffering f5203fd Update mailing list details since the move to groups.io 0a902f7 Fix psplash-systemd failures
4cf1330 Remove generated psplash-poky-img.h
aea172a Makefile.am: Fix out of tree builds

---
 package/psplash/psplash.hash | 2 +-
 package/psplash/psplash.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/psplash/psplash.hash +1 -1
index 87fcdadd6d..77090d08f6 100644
@@ -1,3 +1,3 @@
 # Locally computed
-sha256  2c1344dd8414415d80a01484b1cc29e78f99c31d5266189540e5966a7dc6e10e  psplash-fd33a9b3d68c89fa22ff6873f4f9fd28bd85830c-br1.tar.gz
+sha256  c9f71754f4606e46212a4851d6c1145e4ae8752fd11a2b40e825f04bf79b22ec  psplash-44afb7506d43cca15582b4c5b90ba5580344d75d-br1.tar.gz
 sha256  f9c375a1be4a41f7b70301dd83c91cb89e41567478859b77eef375a52d782505  COPYING
package/psplash/psplash.mk +1 -1
index 199509ecd6..5e61f2392f 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-PSPLASH_VERSION = fd33a9b3d68c89fa22ff6873f4f9fd28bd85830c
+PSPLASH_VERSION = 44afb7506d43cca15582b4c5b90ba5580344d75d
 PSPLASH_SITE = git://git.yoctoproject.org/psplash
 PSPLASH_LICENSE = GPL-2.0+
 PSPLASH_LICENSE_FILES = COPYING
Signature · 6 lines
2.25.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

PATCH 2/2 package/psplash: add support to missing configure options

Add support to three configure options:
--disable-startup-msg: Disable text banner output on startup --disable-progress-bar: Disable progress bar --enable-img-fullscreen: Enable the logo image in fullscreen mode

---
 package/psplash/.Config.in.swp | Bin 0 -> 12288 bytes
 package/psplash/Config.in      |  15 +++++++++++++++
 package/psplash/psplash.mk     |  12 ++++++++++++
 3 files changed, 27 insertions(+)
 create mode 100644 package/psplash/.Config.in.swp
package/psplash/.Config.in.swp new file binary +0 -0
new file mode 100644
index 0000000000000000000000000000000000000000..e484556922e96c824ecda0725e674bc8223d8d00
GIT binary patch
package/psplash/Config.in +15 -0
index da99b264e0..e79e9e85c4 100644
@@ -35,6 +35,21 @@ config BR2_PACKAGE_PSPLASH_IMAGE
 	  Use a personalized png image as boot splash.
 	  Let it empty if you want to keep the psplash default image.
 
+config BR2_PACKAGE_PSPLASH_FULL_SCREEN
+	bool "use fullscreen mode"
+	help
+	  Enable the psplash image in fullscreen mode.
+
+config BR2_PACKAGE_PSPLASH_NO_STARTUP_MSG
+	bool "disable startup message"
+	help
+	  Disable text banner output on startup.
+
+config BR2_PACKAGE_PSPLASH_NO_PROGRESS_BAR
+	bool "disable progress bar"
+	help
+	  Disable the management of the progress bar.
+
 endif
 
 comment "psplash needs a toolchain w/ wchar"
package/psplash/psplash.mk +12 -0
index 5e61f2392f..a7d36697a6 100644
@@ -18,6 +18,18 @@ else
 PSPLASH_CONF_OPTS += --without-systemd
 endif
 
+ifeq ($(BR2_PACKAGE_PSPLASH_FULL_SCREEN),y)
+PSPLASH_CONF_OPTS += --enable-img-fullscreen
+endif
+
+ifeq ($(BR2_PACKAGE_PSPLASH_NO_STARTUP_MSG),y)
+PSPLASH_CONF_OPTS += --disable-startup-msg
+endif
+
+ifeq ($(BR2_PACKAGE_PSPLASH_NO_PROGRESS_BAR),y)
+PSPLASH_CONF_OPTS += --disable-progress-bar
+endif
+
 PSPLASH_IMAGE = $(call qstrip,$(BR2_PACKAGE_PSPLASH_IMAGE))
 
 ifneq ($(PSPLASH_IMAGE),)
Signature · 6 lines
2.25.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

Re: [Buildroot] [PATCH 2/2] package/psplash: add support to missing configure options

Hi Köry,

package/psplash/.Config.in.swp

Quoted 45 lines · Kory Maincent

Add support to three configure options:
--disable-startup-msg: Disable text banner output on startup --disable-progress-bar: Disable progress bar --enable-img-fullscreen: Enable the logo image in fullscreen mode

---
 package/psplash/.Config.in.swp | Bin 0 -> 12288 bytes
 package/psplash/Config.in      |  15 +++++++++++++++
 package/psplash/psplash.mk     |  12 ++++++++++++
 3 files changed, 27 insertions(+)
 create mode 100644 package/psplash/.Config.in.swp
package/psplash/.Config.in.swp new file binary +0 -0
new file mode 100644
index 0000000000000000000000000000000000000000..e484556922e96c824ecda0725e674bc8223d8d00
GIT binary patch

Greetings fellow vim user :) I assume you didn't want this in your patch :)

Cheers,
Quentin
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#3 lore raw

Re: [Buildroot] [PATCH 2/2] package/psplash: add support to missing configure options

Hello Quentin and Thomas,

Quoted 10 lines · On Mon, 15 Nov 2021 14:47:03 +0100 Quentin Schulz…
Quoted 9 lines
---
 package/psplash/.Config.in.swp | Bin 0 -> 12288 bytes
 package/psplash/Config.in      |  15 +++++++++++++++
 package/psplash/psplash.mk     |  12 ++++++++++++
 3 files changed, 27 insertions(+)
 create mode 100644 package/psplash/.Config.in.swp

HcmV?d00001

Quoted 2 lines

Greetings fellow vim user :) I assume you didn't want this in your patch :)

vim 4 life ! ;)
Oops, sorry for this crap.

Köry
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#4 lore raw

Re: [Buildroot] [PATCH 2/2] package/psplash: add support to missing configure options

In reply to Kory Maincent
Quoted 8 lines · On Mon, 15 Nov 2021 14:30:00 +0100 Kory Maincent <[email protected]>…

Add support to three configure options:
--disable-startup-msg: Disable text banner output on startup --disable-progress-bar: Disable progress bar --enable-img-fullscreen: Enable the logo image in fullscreen mode

---
 package/psplash/.Config.in.swp | Bin 0 -> 12288 bytes

Are you sure we want this file in Buildroot ? :-)

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#5 lore raw

Re: [Buildroot] [PATCH 2/2] package/psplash: add support to missing configure options

Hi Thomas,

Quoted 8 lines · Thomas Petazzoni
Quoted 5 lines · On Mon, 15 Nov 2021 14:30:00 +0100 Kory Maincent <[email protected]>…

Add support to three configure options:
--disable-startup-msg: Disable text banner output on startup --disable-progress-bar: Disable progress bar --enable-img-fullscreen: Enable the logo image in fullscreen mode

Quoted 5 lines
Quoted 3 lines
---
 package/psplash/.Config.in.swp | Bin 0 -> 12288 bytes

Are you sure we want this file in Buildroot ? :-)

A file of this name is already in current master branch. Introduced in commit 70440e28c8eef ("package/python-pudb: bump to version 2021.1").

baruch

Signature · 7 lines
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - [email protected] - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#6 lore raw

Re: [Buildroot] [PATCH 2/2] package/psplash: add support to missing configure options

Quoted 11 lines · On Mon, 15 Nov 2021 17:37:49 +0200 Baruch Siach <[email protected]> wrote:

Hi Thomas,

Quoted 8 lines · Thomas Petazzoni
Quoted 5 lines · On Mon, 15 Nov 2021 14:30:00 +0100 Kory Maincent <[email protected]>…

Add support to three configure options:
--disable-startup-msg: Disable text banner output on startup --disable-progress-bar: Disable progress bar --enable-img-fullscreen: Enable the logo image in fullscreen mode

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
---
 package/psplash/.Config.in.swp | Bin 0 -> 12288 bytes  

Are you sure we want this file in Buildroot ? :-)

A file of this name is already in current master branch. Introduced in commit 70440e28c8eef ("package/python-pudb: bump to version 2021.1").

I was confused initially, I thought you said package/psplash/.Config.in.swp already existed, but it's .Config.in.swp in the python-pudb package. We definitely want to get rid of it, indeed.

As an Emacs user, should I also suggest to forbid the usage of vim? :-)

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#7 lore raw

Re: [Buildroot] [PATCH 2/2] package/psplash: add support to missing configure options

Hi Thomas,

Quoted 17 lines · Thomas Petazzoni
Quoted 15 lines · On Mon, 15 Nov 2021 17:37:49 +0200 Baruch Siach <[email protected]> wrote:
Quoted 13 lines · Thomas Petazzoni
Quoted 8 lines · On Mon, 15 Nov 2021 14:30:00 +0100 Kory Maincent <[email protected]>…

Add support to three configure options:
--disable-startup-msg: Disable text banner output on startup --disable-progress-bar: Disable progress bar --enable-img-fullscreen: Enable the logo image in fullscreen mode

---
 package/psplash/.Config.in.swp | Bin 0 -> 12288 bytes  

Are you sure we want this file in Buildroot ? :-)

Quoted 8 lines
Quoted 2 lines

A file of this name is already in current master branch. Introduced in commit 70440e28c8eef ("package/python-pudb: bump to version 2021.1").

I was confused initially, I thought you said package/psplash/.Config.in.swp already existed, but it's .Config.in.swp in the python-pudb package. We definitely want to get rid of it, indeed.

As an Emacs user, should I also suggest to forbid the usage of vim? :-)

Or we can add '*.swp' or '.*' patterns to top level .gitignore. The kernel has the latter.

I have '*.swp' in .git/info/exclude for the same effect.

baruch

Signature · 7 lines
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - [email protected] - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#8 lore raw

Re: [Buildroot] [PATCH 2/2] package/psplash: add support to missing configure options

In reply to Baruch Siach via buildroot

Baruch, All,

On 2021-11-15 17:37 +0200, Baruch Siach via buildroot spake thusly:

Quoted 9 lines · Thomas Petazzoni
Quoted 8 lines
Quoted 5 lines · On Mon, 15 Nov 2021 14:30:00 +0100 Kory Maincent <[email protected]>…

Add support to three configure options:
--disable-startup-msg: Disable text banner output on startup --disable-progress-bar: Disable progress bar --enable-img-fullscreen: Enable the logo image in fullscreen mode

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
---
 package/psplash/.Config.in.swp | Bin 0 -> 12288 bytes

Are you sure we want this file in Buildroot ? :-)

A file of this name is already in current master branch. Introduced in commit 70440e28c8eef ("package/python-pudb: bump to version 2021.1").

Thanks for the report! I've cleaned up my mess now, by pushing commit 5f92c032369e. Thanks!

Regards,
Yann E. MORIN.

Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot