common/module: fix patient module remover when module is not present
PATCH 1/1 common/module: fix patient module remover when module is not present
When module is not present and the open coded patient module remover is called we'll end up in a loop which never ends. Fix this.
I actually found this issue not in fstests, but when applying this open coded solution to blktests. In fstest we tend to only call module remove when we have a module loaded. blktests is different, and so I immediately spotted the issue there.
--- common/module | 2 ++ 1 file changed, 2 insertions(+)
common/module +2 -0
@@ -180,6 +180,8 @@ _patient_rmmod() continue fi let max_tries=$max_tries-1 + else + break fi done
Signature · 1 line
2.33.0
Poke
Quoted 30 lines · Luis Chamberlain
When module is not present and the open coded patient module remover is called we'll end up in a loop which never ends. Fix this.
I actually found this issue not in fstests, but when applying this open coded solution to blktests. In fstest we tend to only call module remove when we have a module loaded. blktests is different, and so I immediately spotted the issue there.
Signed-off-by Luis Chamberlain <[email protected]>--- common/module | 2 ++ 1 file changed, 2 insertions(+)common/module +2
-0@@ -180,6 +180,8 @@ _patient_rmmod() continue fi let max_tries=$max_tries-1 + else + break fi doneSignature · 1 line
2.33.0
Quoted 1 line · Luis Chamberlain
Poke
Sorry, it got lost from my to-review queue, applied now, thanks!
Eryu
Quoted 32 lines · Luis Chamberlain
Quoted 30 lines
When module is not present and the open coded patient module remover is called we'll end up in a loop which never ends. Fix this.
I actually found this issue not in fstests, but when applying this open coded solution to blktests. In fstest we tend to only call module remove when we have a module loaded. blktests is different, and so I immediately spotted the issue there.
Signed-off-by Luis Chamberlain <[email protected]>--- common/module | 2 ++ 1 file changed, 2 insertions(+)common/module +2
-0@@ -180,6 +180,8 @@ _patient_rmmod() continue fi let max_tries=$max_tries-1 + else + break fi doneSignature · 1 line
2.33.0