Skip to contentSkip to conversation

mips: lantiq: add support for clk_get_parent()

PATCH Applied Randy Dunlap 4 participants 4 messages Nov 15, 2021 – Nov 16, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mips: lantiq: add support for clk_get_parent()

Provide a simple implementation of clk_get_parent() in the lantiq subarch so that callers of it will build without errors.

Fixes this build error:
ERROR: modpost: "clk_get_parent" [drivers/iio/adc/ingenic-adc.ko] undefined!

Fixes 171bb2f19ed6 ("MIPS: Lantiq: Add initial support for Lantiq SoCs")
Cc John Crispin <[email protected]>
Cc Thomas Bogendoerfer <[email protected]>
Cc Jonathan Cameron <[email protected]>
Cc Russell King <[email protected]>
Cc Andy Shevchenko <[email protected]>
---
 arch/mips/lantiq/clk.c |    6 ++++++
 1 file changed, 6 insertions(+)
arch/mips/lantiq/clk.c +6 -0
@@ -158,6 +158,12 @@ void clk_deactivate(struct clk *clk)
 }
 EXPORT_SYMBOL(clk_deactivate);
 
+struct clk *clk_get_parent(struct clk *clk)
+{
+	return NULL;
+}
+EXPORT_SYMBOL(clk_get_parent);
+
 static inline u32 get_counter_resolution(void)
 {
 	u32 res;
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · On Sun, 14 Nov 2021 17:20:51 -0800 Randy Dunlap <[email protected]> wrote:

Provide a simple implementation of clk_get_parent() in the lantiq subarch so that callers of it will build without errors.

Fixes this build error:
ERROR: modpost: "clk_get_parent" [drivers/iio/adc/ingenic-adc.ko] undefined!

Quoted 10 lines
Fixes 171bb2f19ed6 ("MIPS: Lantiq: Add initial support for Lantiq SoCs")
Cc John Crispin <[email protected]>
Cc Thomas Bogendoerfer <[email protected]>
Cc Jonathan Cameron <[email protected]>
Cc Russell King <[email protected]>
Cc Andy Shevchenko <[email protected]>

Thanks for tidying this up.

Jonathan

Quoted 19 lines
---
 arch/mips/lantiq/clk.c |    6 ++++++
 1 file changed, 6 insertions(+)
arch/mips/lantiq/clk.c +6 -0
@@ -158,6 +158,12 @@ void clk_deactivate(struct clk *clk)
 }
 EXPORT_SYMBOL(clk_deactivate);
 
+struct clk *clk_get_parent(struct clk *clk)
+{
+	return NULL;
+}
+EXPORT_SYMBOL(clk_get_parent);
+
 static inline u32 get_counter_resolution(void)
 {
 	u32 res;
maintainer Acked-by on v1 1/1
#2 lore raw
In reply to Randy Dunlap
Quoted 6 lines · Randy Dunlap

Provide a simple implementation of clk_get_parent() in the lantiq subarch so that callers of it will build without errors.

Fixes this build error:
ERROR: modpost: "clk_get_parent" [drivers/iio/adc/ingenic-adc.ko] undefined!

Quoted 10 lines
Fixes 171bb2f19ed6 ("MIPS: Lantiq: Add initial support for Lantiq SoCs")
Cc John Crispin <[email protected]>
Cc Thomas Bogendoerfer <[email protected]>
Cc Jonathan Cameron <[email protected]>
Cc Russell King <[email protected]>
Cc Andy Shevchenko <[email protected]>

// we added the same fix for mips/ralink a while back

Quoted 20 lines
---
  arch/mips/lantiq/clk.c |    6 ++++++
  1 file changed, 6 insertions(+)
arch/mips/lantiq/clk.c +6 -0
@@ -158,6 +158,12 @@ void clk_deactivate(struct clk *clk)
  }
  EXPORT_SYMBOL(clk_deactivate);
 
+struct clk *clk_get_parent(struct clk *clk)
+{
+	return NULL;
+}
+EXPORT_SYMBOL(clk_get_parent);
+
  static inline u32 get_counter_resolution(void)
  {
  	u32 res;
maintainer Applied
#3 lore raw
In reply to Randy Dunlap
Quoted 25 lines · Randy Dunlap

Provide a simple implementation of clk_get_parent() in the lantiq subarch so that callers of it will build without errors.

Fixes this build error:
ERROR: modpost: "clk_get_parent" [drivers/iio/adc/ingenic-adc.ko] undefined!

Fixes 171bb2f19ed6 ("MIPS: Lantiq: Add initial support for Lantiq SoCs")
Cc John Crispin <[email protected]>
Cc Thomas Bogendoerfer <[email protected]>
Cc Jonathan Cameron <[email protected]>
Cc Russell King <[email protected]>
Cc Andy Shevchenko <[email protected]>
---
 arch/mips/lantiq/clk.c |    6 ++++++
 1 file changed, 6 insertions(+)
arch/mips/lantiq/clk.c +0 -0
@@ -158,6 +158,12 @@ void clk_deactivate(struct clk *clk)
 }
 EXPORT_SYMBOL(clk_deactivate);

arch/mips/lantiq/clk.c void clk_deactivate(struct clk *clk) · line 169

Quoted 10 lines
arch/mips/lantiq/clk.c +6 -0
 
+struct clk *clk_get_parent(struct clk *clk)
+{
+	return NULL;
+}
+EXPORT_SYMBOL(clk_get_parent);
+
 static inline u32 get_counter_resolution(void)
 {
 	u32 res;

applied to mips-fixes.

Thomas.

Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]