target/configfs: delete unnecessary checks for NULL
Subsystems (3)
PATCH 1/1 target/configfs: delete unnecessary checks for NULL
The "item" pointer is always going to be valid pointer and does not need to be checked.
But if "item" were NULL then item_to_lun() would not return a NULL, but instead, the container_of() pointer math would return a value in the error pointer range. This confuses static checkers since it looks like a NULL vs IS_ERR() bug.
Delete the bogus checks.
--- drivers/target/target_core_fabric_configfs.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/target/target_core_fabric_configfs.c +8 -8
@@ -520,7 +520,7 @@ static ssize_t target_fabric_port_alua_tg_pt_gp_show(struct config_item *item, {struct se_lun *lun =item_to_lun (item); -if (!lun || !lun->lun_se_dev) +if (!lun->lun_se_dev)return -ENODEV ;return core_alua_show_tg_pt_gp_info (lun, page);
@@ -531,7 +531,7 @@ static ssize_t target_fabric_port_alua_tg_pt_gp_store(struct config_item *item, {struct se_lun *lun =item_to_lun (item); -if (!lun || !lun->lun_se_dev) +if (!lun->lun_se_dev)return -ENODEV ;return core_alua_store_tg_pt_gp_info (lun, page, count);
@@ -542,7 +542,7 @@ static ssize_t target_fabric_port_alua_tg_pt_offline_show( {struct se_lun *lun =item_to_lun (item); -if (!lun || !lun->lun_se_dev) +if (!lun->lun_se_dev)return -ENODEV ;return core_alua_show_offline_bit (lun, page);
@@ -553,7 +553,7 @@ static ssize_t target_fabric_port_alua_tg_pt_offline_store( {struct se_lun *lun =item_to_lun (item); -if (!lun || !lun->lun_se_dev) +if (!lun->lun_se_dev)return -ENODEV ;return core_alua_store_offline_bit (lun, page, count);
@@ -564,7 +564,7 @@ static ssize_t target_fabric_port_alua_tg_pt_status_show( {struct se_lun *lun =item_to_lun (item); -if (!lun || !lun->lun_se_dev) +if (!lun->lun_se_dev)return -ENODEV ;return core_alua_show_secondary_status (lun, page);
@@ -575,7 +575,7 @@ static ssize_t target_fabric_port_alua_tg_pt_status_store( {struct se_lun *lun =item_to_lun (item); -if (!lun || !lun->lun_se_dev) +if (!lun->lun_se_dev)return -ENODEV ;return core_alua_store_secondary_status (lun, page, count);
@@ -586,7 +586,7 @@ static ssize_t target_fabric_port_alua_tg_pt_write_md_show( {struct se_lun *lun =item_to_lun (item); -if (!lun || !lun->lun_se_dev) +if (!lun->lun_se_dev)return -ENODEV ;return core_alua_show_secondary_write_metadata (lun, page);
@@ -597,7 +597,7 @@ static ssize_t target_fabric_port_alua_tg_pt_write_md_store( {struct se_lun *lun =item_to_lun (item); -if (!lun || !lun->lun_se_dev) +if (!lun->lun_se_dev)return -ENODEV ;return core_alua_store_secondary_write_metadata (lun, page, count);
Signature · 1 line
2.20.1
Martin K. Petersen
AppliedQuoted 9 lines · Dan Carpenter
The "item" pointer is always going to be valid pointer and does not need to be checked.
But if "item" were NULL then
item_to_lun()would not return a NULL, but instead, thecontainer_of()pointer math would return a value in the error pointer range. This confuses static checkers since it looks like a NULL vsIS_ERR()bug.[...]
Applied to 5.16/scsi-fixes, thanks!
[1/1] target/configfs: delete unnecessary checks for NULL
https://git.kernel.org/mkp/scsi/c/9c6603e1faf8
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering