Skip to contentSkip to conversation

arm64: extable: remove unsed ex_handler_t definition

PATCH Superseded Jisheng Zhang 2 participants 2 messages Nov 18, 2021 arm64

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: extable: remove unsed ex_handler_t definition

From: Jisheng Zhang <[email protected]>

The type ex_handler_t is defined but not used, remove it.

---
 arch/arm64/mm/extable.c | 3 ---
 1 file changed, 3 deletions(-)
arch/arm64/mm/extable.c +0 -3
index c3d53811a15e..c0181e60cc98 100644
@@ -10,9 +10,6 @@
 #include <asm/asm-extable.h>
 #include <asm/ptrace.h>
 
-typedef bool (*ex_handler_t)(const struct exception_table_entry *,
-			     struct pt_regs *);
-
 static inline unsigned long
 get_ex_fixup(const struct exception_table_entry *ex)
 {
Signature · 1 line
2.33.0
reviewer Acked-by on v1 1/1
#1 lore raw
Quoted 3 lines · Jisheng Zhang

From: Jisheng Zhang <[email protected]>

The type ex_handler_t is defined but not used, remove it.

It's probably worth saying:

| The ex_handler_t type was introduced in commit:
|
|   d6e2cc5647753825 ("arm64: extable: add `type` and `data` fields")
| 
| ... but has never been used, and is unnecessary. Remove it.

... as this was a leftover from a prior version of that patch, and in the form merged in mainline it was redundant becuase we moved to using an enumerated type rather than a function pointer in the ex_table_entry.

Quoted 1 line

With or without the wording above:

Thanks,
Mark.

Quoted 22 lines
---
 arch/arm64/mm/extable.c | 3 ---
 1 file changed, 3 deletions(-)
arch/arm64/mm/extable.c +0 -3
index c3d53811a15e..c0181e60cc98 100644
@@ -10,9 +10,6 @@
 #include <asm/asm-extable.h>
 #include <asm/ptrace.h>
 
-typedef bool (*ex_handler_t)(const struct exception_table_entry *,
-			     struct pt_regs *);
-
 static inline unsigned long
 get_ex_fixup(const struct exception_table_entry *ex)
 {
Signature · 1 line
2.33.0