staging: vt6655: refactor camelcase uCurrRSSI to current_rssi
PATCH v3 1/1 staging: vt6655: refactor camelcase uCurrRSSI to current_rssi
Replace camelcase variable "uCurrRSSI" (current Received Signal Strength Indicator) into linux kernel coding style equivalent variable "current_rssi".
---
v2
- correct mailing list
v1
- remove whitespaces
drivers/staging/vt6655/device.h | 2 +- drivers/staging/vt6655/device_main.c | 4 ++-- drivers/staging/vt6655/dpc.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
drivers/staging/vt6655/device.h +1 -1
@@ -167,7 +167,7 @@ struct vnt_private {unsigned char abyCurrentNetAddr[ETH_ALEN ];__aligned(2) bool bLinkPass;/* link status: OK or fail */ -unsigned int uCurrRSSI; +unsigned int current_rssi;unsigned char byCurrSQ;unsigned long dwTxAntennaSel;
drivers/staging/vt6655/device_main.c +2 -2
@@ -979,10 +979,10 @@ static void vnt_check_bb_vga(struct vnt_private *priv)if (priv->hw->conf.flags &IEEE80211_CONF_OFFCHANNEL )return ; -if (!(priv->vif->bss_conf.assoc && priv->uCurrRSSI)) +if (!(priv->vif->bss_conf.assoc && priv->current_rssi))return ; -RFvRSSITodBm (priv, (u8 )priv->uCurrRSSI, &dbm); +RFvRSSITodBm (priv, (u8 )priv->current_rssi, &dbm);for (i =0 ; i <BB_VGA_LEVEL ; i++) {if (dbm < priv->ldBmThreshold[i]) {
drivers/staging/vt6655/dpc.c +1 -1
@@ -82,7 +82,7 @@ static bool vnt_rx_data(struct vnt_private *priv, struct sk_buff *skb,RFvRSSITodBm (priv, *rssi, &rx_dbm); priv->byBBPreEDRSSI = (u8 )rx_dbm +1 ; - priv->uCurrRSSI = *rssi; + priv->current_rssi = *rssi;skb_pull (skb,4 );skb_trim (skb, frame_size);
Signature · 1 line
2.25.1
Greg KH
maintainerQuoted 9 lines · Alberto Merciai
Replace camelcase variable "uCurrRSSI" (current Received Signal Strength Indicator) into linux kernel coding style equivalent variable "
current_rssi".Signed-off-by Alberto Merciai <[email protected]>---
v2
- correct mailing list
No, you did not use the correct mailing list.
What is the output of scripts/get_maintainer.pl on your patch?
thanks,
greg k-h
driver-core$ ./scripts/get_maintainer.pl drivers/staging/vt6655/device.h
Forest Bond <[email protected]> (odd fixer:STAGING - VIA VT665X DRIVERS)
Greg Kroah-Hartman <[email protected]> (supporter:STAGING SUBSYSTEM)
Alberto Merciai <[email protected]> (commit_signer:2/2=100%,authored:2/2=100%,added_lines:2/2=100%,removed_lines:2/2=100%) [email protected] (open list:STAGING SUBSYSTEM)
[email protected] (open list)
Regards,
Alberto
Quoted 18 lines · Greg KH
Quoted 9 lines · Alberto Merciai
Replace camelcase variable "uCurrRSSI" (current Received Signal Strength Indicator) into linux kernel coding style equivalent variable "
current_rssi".Signed-off-by Alberto Merciai <[email protected]>---
v2
- correct mailing listNo, you did not use the correct mailing list.
What is the output of
scripts/get_maintainer.plon your patch?thanks,
greg k-h
Greg KH
maintainerQuoted 6 lines · Alberto Merciai
driver-core$
./scripts/get_maintainer.pldrivers/staging/vt6655/device.h
Forest Bond <[email protected]> (odd fixer:STAGING - VIA VT665X DRIVERS)
Greg Kroah-Hartman <[email protected]> (supporter:STAGING SUBSYSTEM)
Alberto Merciai <[email protected]> (commit_signer:2/2=100%,authored:2/2=100%,added_lines:2/2=100%,removed_lines:2/2=100%) [email protected] (open list:STAGING SUBSYSTEM)
[email protected] (open list)
What kernel version is that?
The driverdev mailing list is very old and should not be used anymore.
Please always work against the latest version of the kernel, and for development stuff, linux-next is usually best so you do not duplicate any work that anyone else has done.
thanks,
greg k-h
Quoted 9 lines · Alberto Merciai
Replace camelcase variable "uCurrRSSI" (current Received Signal Strength Indicator) into linux kernel coding style equivalent variable "
current_rssi".Signed-off-by Alberto Merciai <[email protected]>---
v2
- correct mailing list
Are you using the staging-next tree?
regards,
dan carpenter
I'm using the master branch of
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git/
Alberto
Quoted 16 lines · Dan Carpenter
Quoted 9 lines · Alberto Merciai
Replace camelcase variable "uCurrRSSI" (current Received Signal Strength Indicator) into linux kernel coding style equivalent variable "
current_rssi".Signed-off-by Alberto Merciai <[email protected]>---
v2
- correct mailing listAre you using the staging-next tree?
regards,
dan carpenter
Greg KH
maintainerA: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
Quoted 2 lines · Alberto Merciai
I'm using the master branch of
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git/
Very odd, why? That git tree has nothing to do with the staging development process, and especially not the master branch.
What caused you to pick that one?
thanks,
greg k-h
Quoted 1 line
What caused you to pick that one?
My mistake :(
I was reading "Submitting patches: the essential guide
to getting your code into the kernel" and I was confuse dby this line "See the T: entry for the subsystem in the MAINTAINERS file to find that tree, or simply ask the maintainer if the tree is not listed there." supposing that master branch was the correct one.
I'm moving on "staging-next" branch as you suggest.
Regards,
Alberto