treewide: add missing includes masked by cgroup -> bpf dependency
Subsystems (25)
Jakub Kicinski
maintainerPATCH 1/1 treewide: add missing includes masked by cgroup -> bpf dependency
cgroup.h (therefore swap.h, therefore half of the universe) includes bpf.h which in turn includes module.h and slab.h. Since we're about to get rid of that dependency we need to clean things up.
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
Well, let's see if this makes it thru email servers...
--- block/fops.c | 1 + drivers/gpu/drm/drm_gem_shmem_helper.c | 1 + drivers/gpu/drm/i915/gt/intel_gtt.c | 1 + drivers/gpu/drm/i915/i915_request.c | 1 + drivers/gpu/drm/lima/lima_device.c | 1 + drivers/gpu/drm/msm/msm_gem_shrinker.c | 1 + drivers/gpu/drm/ttm/ttm_tt.c | 1 + drivers/net/ethernet/huawei/hinic/hinic_sriov.c | 1 + drivers/net/ethernet/marvell/octeontx2/nic/otx2_ptp.c | 2 ++ drivers/pci/controller/dwc/pci-exynos.c | 1 + drivers/pci/controller/dwc/pcie-qcom-ep.c | 1 + drivers/usb/cdns3/host.c | 1 + include/linux/device/driver.h | 1 + include/linux/filter.h | 2 +- mm/damon/vaddr.c | 1 + mm/memory_hotplug.c | 1 + mm/swap_slots.c | 1 + 17 files changed, 18 insertions(+), 1 deletion(-)
block/fops.c +1 -0
@@ -15,6 +15,7 @@#include <linux/falloc.h> #include <linux/suspend.h> #include <linux/fs.h> +#include <linux/module.h> #include "blk.h" static inline struct inode *bdev_file_inode (struct file *file)
drivers/gpu/drm/drm_gem_shmem_helper.c +1 -0
@@ -9,6 +9,7 @@#include <linux/shmem_fs.h> #include <linux/slab.h> #include <linux/vmalloc.h> +#include <linux/module.h> #ifdef CONFIG_X86 #include <asm/set_memory.h>
drivers/gpu/drm/i915/gt/intel_gtt.c +1 -0
@@ -6,6 +6,7 @@#include <linux/slab.h> /* fault-inject.h is not standalone! */ #include <linux/fault-inject.h> +#include <linux/sched/mm.h> #include "gem/i915_gem_lmem.h" #include "i915_trace.h"
drivers/gpu/drm/i915/i915_request.c +1 -0
@@ -29,6 +29,7 @@#include <linux/sched.h> #include <linux/sched/clock.h> #include <linux/sched/signal.h> +#include <linux/sched/mm.h> #include "gem/i915_gem_context.h" #include "gt/intel_breadcrumbs.h"
drivers/gpu/drm/lima/lima_device.c +1 -0
@@ -4,6 +4,7 @@#include <linux/regulator/consumer.h> #include <linux/reset.h> #include <linux/clk.h> +#include <linux/slab.h> #include <linux/dma-mapping.h> #include <linux/platform_device.h>
drivers/gpu/drm/msm/msm_gem_shrinker.c +1 -0
@@ -5,6 +5,7 @@*/ #include <linux/vmalloc.h> +#include <linux/sched/mm.h> #include "msm_drv.h" #include "msm_gem.h"
drivers/gpu/drm/ttm/ttm_tt.c +1 -0
@@ -34,6 +34,7 @@#include <linux/sched.h> #include <linux/shmem_fs.h> #include <linux/file.h> +#include <linux/module.h> #include <drm/drm_cache.h> #include <drm/ttm/ttm_bo_driver.h>
drivers/net/ethernet/huawei/hinic/hinic_sriov.c +1 -0
@@ -8,6 +8,7 @@#include <linux/interrupt.h> #include <linux/etherdevice.h> #include <linux/netdevice.h> +#include <linux/module.h> #include "hinic_hw_dev.h" #include "hinic_dev.h"
drivers/net/ethernet/marvell/octeontx2/nic/otx2_ptp.c +2 -0
@@ -5,6 +5,8 @@* */ +#include <linux/module.h> +#include "otx2_common.h" #include "otx2_ptp.h"
drivers/pci/controller/dwc/pci-exynos.c +1 -0
@@ -19,6 +19,7 @@#include <linux/platform_device.h> #include <linux/phy/phy.h> #include <linux/regulator/consumer.h> +#include <linux/module.h> #include "pcie-designware.h"
drivers/pci/controller/dwc/pcie-qcom-ep.c +1 -0
@@ -18,6 +18,7 @@#include <linux/pm_domain.h> #include <linux/regmap.h> #include <linux/reset.h> +#include <linux/module.h> #include "pcie-designware.h"
drivers/usb/cdns3/host.c +1 -0
@@ -10,6 +10,7 @@*/ #include <linux/platform_device.h> +#include <linux/slab.h> #include "core.h" #include "drd.h" #include "host-export.h"
include/linux/device/driver.h +1 -0
@@ -18,6 +18,7 @@#include <linux/klist.h> #include <linux/pm.h> #include <linux/device/bus.h> +#include <linux/module.h> /** * enum probe_type - device driver probe type to try
include/linux/filter.h +1 -1
@@ -6,6 +6,7 @@#define __LINUX_FILTER_H__#include <linux/atomic.h> +#include <linux/bpf.h> #include <linux/refcount.h> #include <linux/compat.h> #include <linux/skbuff.h>
@@ -26,7 +27,6 @@#include <asm/byteorder.h> #include <uapi/linux/filter.h> -#include <uapi/linux/bpf.h> struct sk_buff ;struct sock ;
mm/damon/vaddr.c +1 -0
@@ -13,6 +13,7 @@#include <linux/mmu_notifier.h> #include <linux/page_idle.h> #include <linux/pagewalk.h> +#include <linux/sched/mm.h> #include "prmtv-common.h"
mm/memory_hotplug.c +1 -0
@@ -35,6 +35,7 @@#include <linux/memblock.h> #include <linux/compaction.h> #include <linux/rmap.h> +#include <linux/module.h> #include <asm/tlbflush.h>
mm/swap_slots.c +1 -0
@@ -30,6 +30,7 @@#include <linux/swap_slots.h> #include <linux/cpu.h> #include <linux/cpumask.h> +#include <linux/slab.h> #include <linux/vmalloc.h> #include <linux/mutex.h> #include <linux/mm.h>
Signature · 1 line
2.31.1
Hi Jakub,
[...]
Quoted 2 lines
drivers/pci/controller/dwc/pci-exynos.c | 1 + drivers/pci/controller/dwc/pcie-qcom-ep.c | 1 +
Happy to give
for the the PCI drivers. Thank you!
Krzysztof
kernel test robot
build botI love your patch! Yet something to improve:
Hi Jakub,
I love your patch! Yet something to improve:
[auto build test ERROR on bpf/master]
url: https://github.com/0day-ci/linux/commits/Jakub-Kicinski/treewide-add-missing-includes-masked-by-cgroup-bpf-dependency/20211120-115325 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git master config: riscv-randconfig-m031-20211118 (attached as .config) compiler: riscv32-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/e31b3bdd266ef8f63543f27cf7493e98112fd74a
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jakub-Kicinski/treewide-add-missing-includes-masked-by-cgroup-bpf-dependency/20211120-115325 git checkout e31b3bdd266ef8f63543f27cf7493e98112fd74a
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=riscv SHELL=/bin/bash drivers/base/ drivers/iio/dac/ drivers/of/
If you fix the issue, kindly add following tag as appropriate
All error/warnings (new ones prefixed by >>):
In file included from include/linux/cpu.h:17,
from include/linux/cacheinfo.h:6, from arch/riscv/include/asm/cacheinfo.h:9, from arch/riscv/include/asm/elf.h:14, from include/linux/elf.h:6,
from include/linux/module.h:19, from include/linux/device/driver.h:21, from include/linux/device.h:32, from drivers/base/component.c:11:
>> include/linux/node.h:85:25: error: field 'dev' has incomplete type
85 | struct device dev;
| ^~~
In file included from include/linux/cacheinfo.h:6,
from arch/riscv/include/asm/cacheinfo.h:9,
from arch/riscv/include/asm/elf.h:14,
from include/linux/elf.h:6,
from include/linux/module.h:19,
from include/linux/device/driver.h:21,
from include/linux/device.h:32,
from drivers/base/component.c:11:
>> include/linux/cpu.h:29:23: error: field 'dev' has incomplete type
29 | struct device dev;
| ^~~
>> include/linux/cpu.h:44:36: warning: 'struct device_attribute' declared inside parameter list will not be visible outside of this definition or declaration
44 | extern int cpu_add_dev_attr(struct device_attribute *attr);
| ^~~~~~~~~~~~~~~~
include/linux/cpu.h:45:40: warning: 'struct device_attribute' declared inside parameter list will not be visible outside of this definition or declaration
45 | extern void cpu_remove_dev_attr(struct device_attribute *attr);
| ^~~~~~~~~~~~~~~~
include/linux/cpu.h:51:41: warning: 'struct device_attribute' declared inside parameter list will not be visible outside of this definition or declaration
51 | struct device_attribute *attr, char *buf);
| ^~~~~~~~~~~~~~~~
include/linux/cpu.h:53:43: warning: 'struct device_attribute' declared inside parameter list will not be visible outside of this definition or declaration
53 | struct device_attribute *attr, char *buf);
| ^~~~~~~~~~~~~~~~
include/linux/cpu.h:55:43: warning: 'struct device_attribute' declared inside parameter list will not be visible outside of this definition or declaration
55 | struct device_attribute *attr, char *buf);
| ^~~~~~~~~~~~~~~~
include/linux/cpu.h:57:50: warning: 'struct device_attribute' declared inside parameter list will not be visible outside of this definition or declaration
57 | struct device_attribute *attr, char *buf);
| ^~~~~~~~~~~~~~~~
include/linux/cpu.h:59:37: warning: 'struct device_attribute' declared inside parameter list will not be visible outside of this definition or declaration
59 | struct device_attribute *attr, char *buf);
| ^~~~~~~~~~~~~~~~
include/linux/cpu.h:61:36: warning: 'struct device_attribute' declared inside parameter list will not be visible outside of this definition or declaration
61 | struct device_attribute *attr, char *buf);
| ^~~~~~~~~~~~~~~~
include/linux/cpu.h:63:48: warning: 'struct device_attribute' declared inside parameter list will not be visible outside of this definition or declaration
63 | struct device_attribute *attr,
| ^~~~~~~~~~~~~~~~
include/linux/cpu.h:66:46: warning: 'struct device_attribute' declared inside parameter list will not be visible outside of this definition or declaration
66 | struct device_attribute *attr, char *buf);
| ^~~~~~~~~~~~~~~~
include/linux/cpu.h:67:58: warning: 'struct device_attribute' declared inside parameter list will not be visible outside of this definition or declaration
67 | extern ssize_t cpu_show_srbds(struct device *dev, struct device_attribute *attr, char *buf);
| ^~~~~~~~~~~~~~~~--
In file included from include/linux/node.h:18,
from include/linux/cpu.h:17, from include/linux/cacheinfo.h:6, from arch/riscv/include/asm/cacheinfo.h:9, from arch/riscv/include/asm/elf.h:14, from include/linux/elf.h:6,
from include/linux/module.h:19, from include/linux/device/driver.h:21, from drivers/base/driver.c:11:
include/linux/device.h: In function 'dev_has_sync_state':
>> include/linux/device.h:794:39: error: invalid use of undefined type 'struct device_driver'
794 | if (dev->driver && dev->driver->sync_state)
| ^~--
In file included from include/linux/cpu.h:17,
from include/linux/cacheinfo.h:6, from arch/riscv/include/asm/cacheinfo.h:9, from arch/riscv/include/asm/elf.h:14, from include/linux/elf.h:6,
from include/linux/module.h:19, from include/linux/device/driver.h:21, from include/linux/device.h:32, from drivers/base/attribute_container.c:14:
>> include/linux/node.h:85:25: error: field 'dev' has incomplete type
85 | struct device dev;
| ^~~
In file included from include/linux/cacheinfo.h:6,
from arch/riscv/include/asm/cacheinfo.h:9,
from arch/riscv/include/asm/elf.h:14,
from include/linux/elf.h:6,
from include/linux/module.h:19,
from include/linux/device/driver.h:21,
from include/linux/device.h:32,
from drivers/base/attribute_container.c:14:
>> include/linux/cpu.h:29:23: error: field 'dev' has incomplete type
29 | struct device dev;
| ^~~
--
In file included from arch/riscv/include/asm/module.h:7,
from include/linux/module.h:33,
from include/linux/device/driver.h:21,
from include/linux/device.h:32,
from include/linux/node.h:18,
from include/linux/cpu.h:17,
from include/linux/cacheinfo.h:6,
from arch/riscv/include/asm/cacheinfo.h:9,
from arch/riscv/include/asm/elf.h:14,
from include/linux/elf.h:6,
from include/linux/elfcore.h:13,
from include/linux/crash_core.h:6,
from include/linux/kexec.h:18,
from include/linux/crash_dump.h:5,
from drivers/of/fdt.c:11:
>> include/asm-generic/module.h:37:25: error: unknown type name 'Elf32_Ehdr'
37 | #define Elf_Ehdr Elf32_Ehdr
| ^~~~~~~~~~
include/linux/module.h:835:32: note: in expansion of macro 'Elf_Ehdr'
835 | void module_bug_finalize(const Elf_Ehdr *, const Elf_Shdr *,
| ^~~~~~~~
>> include/asm-generic/module.h:33:25: error: unknown type name 'Elf32_Shdr'
33 | #define Elf_Shdr Elf32_Shdr
| ^~~~~~~~~~ include/linux/module.h:835:50: note: in expansion of macro 'Elf_Shdr'
835 | void module_bug_finalize(const Elf_Ehdr *, const Elf_Shdr *,
| ^~~~~~~~
--
In file included from include/linux/cpu.h:17,
from include/linux/cacheinfo.h:6,
from arch/riscv/include/asm/cacheinfo.h:9,
from arch/riscv/include/asm/elf.h:14,
from include/linux/elf.h:6,
from include/linux/module.h:19,
from include/linux/device/driver.h:21,
from include/linux/device.h:32,
from drivers/iio/dac/ad5755.c:8:
>> include/linux/node.h:85:25: error: field 'dev' has incomplete type
85 | struct device dev;
| ^~~
In file included from include/linux/cacheinfo.h:6,
from arch/riscv/include/asm/cacheinfo.h:9,
from arch/riscv/include/asm/elf.h:14,
from include/linux/elf.h:6,
from include/linux/module.h:19,
from include/linux/device/driver.h:21,
from include/linux/device.h:32,
from drivers/iio/dac/ad5755.c:8:
>> include/linux/cpu.h:29:23: error: field 'dev' has incomplete type
29 | struct device dev;
| ^~~
>> include/linux/cpu.h:44:36: warning: 'struct device_attribute' declared inside parameter list will not be visible outside of this definition or declaration
44 | extern int cpu_add_dev_attr(struct device_attribute *attr);
| ^~~~~~~~~~~~~~~~
include/linux/cpu.h:45:40: warning: 'struct device_attribute' declared inside parameter list will not be visible outside of this definition or declaration
45 | extern void cpu_remove_dev_attr(struct device_attribute *attr);
| ^~~~~~~~~~~~~~~~
include/linux/cpu.h:51:41: warning: 'struct device_attribute' declared inside parameter list will not be visible outside of this definition or declaration
51 | struct device_attribute *attr, char *buf);
| ^~~~~~~~~~~~~~~~
include/linux/cpu.h:53:43: warning: 'struct device_attribute' declared inside parameter list will not be visible outside of this definition or declaration
53 | struct device_attribute *attr, char *buf);
| ^~~~~~~~~~~~~~~~
include/linux/cpu.h:55:43: warning: 'struct device_attribute' declared inside parameter list will not be visible outside of this definition or declaration
55 | struct device_attribute *attr, char *buf);
| ^~~~~~~~~~~~~~~~
include/linux/cpu.h:57:50: warning: 'struct device_attribute' declared inside parameter list will not be visible outside of this definition or declaration
57 | struct device_attribute *attr, char *buf);
| ^~~~~~~~~~~~~~~~
include/linux/cpu.h:59:37: warning: 'struct device_attribute' declared inside parameter list will not be visible outside of this definition or declaration
59 | struct device_attribute *attr, char *buf);
| ^~~~~~~~~~~~~~~~
include/linux/cpu.h:61:36: warning: 'struct device_attribute' declared inside parameter list will not be visible outside of this definition or declaration
61 | struct device_attribute *attr, char *buf);
| ^~~~~~~~~~~~~~~~
include/linux/cpu.h:63:48: warning: 'struct device_attribute' declared inside parameter list will not be visible outside of this definition or declaration
63 | struct device_attribute *attr,
| ^~~~~~~~~~~~~~~~
include/linux/cpu.h:66:46: warning: 'struct device_attribute' declared inside parameter list will not be visible outside of this definition or declaration
66 | struct device_attribute *attr, char *buf);
| ^~~~~~~~~~~~~~~~
include/linux/cpu.h:67:58: warning: 'struct device_attribute' declared inside parameter list will not be visible outside of this definition or declaration
67 | extern ssize_t cpu_show_srbds(struct device *dev, struct device_attribute *attr, char *buf);
| ^~~~~~~~~~~~~~~~
drivers/iio/dac/ad5755.c:785:34: warning: 'ad5755_of_match' defined but not used [-Wunused-const-variable=]
785 | static const struct of_device_id ad5755_of_match[] = {
| ^~~~~~~~~~~~~~~vim +/dev +29 include/linux/cpu.h
313162d0b83836 Paul Gortmaker 2012-01-30 25
^1da177e4c3f41 Linus Torvalds 2005-04-16 26 struct cpu {
^1da177e4c3f41 Linus Torvalds 2005-04-16 27 int node_id; /* The node which contains the CPU */
72486f1f8f0a2b Siddha, Suresh B 2006-12-07 28 int hotpluggable; /* creates sysfs control file if hotpluggable */
8a25a2fd126c62 Kay Sievers 2011-12-21 @29 struct device dev;
^1da177e4c3f41 Linus Torvalds 2005-04-16 30 };
^1da177e4c3f41 Linus Torvalds 2005-04-16 31
cff7d378d3fdbb Thomas Gleixner 2016-02-26 32 extern void boot_cpu_init(void);
b5b1404d081589 Linus Torvalds 2018-08-12 33 extern void boot_cpu_hotplug_init(void);
1777e463550726 Ingo Molnar 2017-02-05 34 extern void cpu_init(void);
1777e463550726 Ingo Molnar 2017-02-05 35 extern void trap_init(void);
cff7d378d3fdbb Thomas Gleixner 2016-02-26 36
76b67ed9dce69a KAMEZAWA Hiroyuki 2006-06-27 37 extern int register_cpu(struct cpu *cpu, int num);
8a25a2fd126c62 Kay Sievers 2011-12-21 38 extern struct device *get_cpu_device(unsigned cpu);
2987557f52b97f Josh Triplett 2011-12-03 39 extern bool cpu_is_hotpluggable(unsigned cpu);
183912d352a242 Sudeep Holla 2013-08-15 40 extern bool arch_match_cpu_phys_id(int cpu, u64 phys_id);
d1cb9d1af0bc11 David Miller 2013-10-03 41 extern bool arch_find_n_match_cpu_physical_id(struct device_node *cpun,
d1cb9d1af0bc11 David Miller 2013-10-03 42 int cpu, unsigned int *thread);
0344c6c5387ba3 Christian Krafft 2006-10-24 43
8a25a2fd126c62 Kay Sievers 2011-12-21 @44 extern int cpu_add_dev_attr(struct device_attribute *attr);
8a25a2fd126c62 Kay Sievers 2011-12-21 45 extern void cpu_remove_dev_attr(struct device_attribute *attr);
0344c6c5387ba3 Christian Krafft 2006-10-24 46 ---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
Jakub Kicinski
maintainerQuoted 2 lines · On Sat, 20 Nov 2021 15:01:35 +0800 kernel test robot wrote:
In file included from
include/linux/cpu.h:17,
frominclude/linux/cacheinfo.h:6,
Yeah, okay, I think cacheinfo.h including cpu.h is the least sane part of this chain. Let me try to attack that.
Peter Chen
maintainerQuoted 134 lines · Jakub Kicinski
cgroup.h(thereforeswap.h, therefore half of the universe) includesbpf.hwhich in turn includesmodule.handslab.h. Since we're about to get rid of that dependency we need to clean things up.Signed-off-by Jakub Kicinski <[email protected]>---
static inline struct inode *bdev_file_inode(struct file *file)drivers/gpu/drm/drm_gem_shmem_helper.c +1
-0@@ -9,6 +9,7 @@#include <linux/shmem_fs.h> #include <linux/slab.h> #include <linux/vmalloc.h> +#include <linux/module.h> #ifdef CONFIG_X86 #include <asm/set_memory.h> drivers/gpu/drm/i915/gt/intel_gtt.c +1
-0@@ -6,6 +6,7 @@#include <linux/slab.h> /* fault-inject.h is not standalone! */ #include <linux/fault-inject.h> +#include <linux/sched/mm.h> #include "gem/i915_gem_lmem.h" #include "i915_trace.h" drivers/gpu/drm/i915/i915_request.c +1
-0@@ -29,6 +29,7 @@#include <linux/sched.h> #include <linux/sched/clock.h> #include <linux/sched/signal.h> +#include <linux/sched/mm.h> #include "gem/i915_gem_context.h" #include "gt/intel_breadcrumbs.h" drivers/gpu/drm/lima/lima_device.c +1
-0@@ -4,6 +4,7 @@#include <linux/regulator/consumer.h> #include <linux/reset.h> #include <linux/clk.h> +#include <linux/slab.h> #include <linux/dma-mapping.h> #include <linux/platform_device.h> drivers/gpu/drm/msm/msm_gem_shrinker.c +1
-0@@ -5,6 +5,7 @@*/ #include <linux/vmalloc.h> +#include <linux/sched/mm.h> #include "msm_drv.h" #include "msm_gem.h" drivers/gpu/drm/ttm/ttm_tt.c +1
-0@@ -34,6 +34,7 @@#include <linux/sched.h> #include <linux/shmem_fs.h> #include <linux/file.h> +#include <linux/module.h> #include <drm/drm_cache.h> #include <drm/ttm/ttm_bo_driver.h> drivers/net/ethernet/huawei/hinic/hinic_sriov.c +1
-0@@ -8,6 +8,7 @@#include <linux/interrupt.h> #include <linux/etherdevice.h> #include <linux/netdevice.h> +#include <linux/module.h> #include "hinic_hw_dev.h" #include "hinic_dev.h" drivers/net/ethernet/marvell/octeontx2/nic/otx2_ptp.c +2
-0@@ -5,6 +5,8 @@* */ +#include <linux/module.h> +#include "otx2_common.h" #include "otx2_ptp.h" drivers/pci/controller/dwc/pci-exynos.c +1
-0@@ -19,6 +19,7 @@#include <linux/platform_device.h> #include <linux/phy/phy.h> #include <linux/regulator/consumer.h> +#include <linux/module.h> #include "pcie-designware.h" drivers/pci/controller/dwc/pcie-qcom-ep.c +1
-0@@ -18,6 +18,7 @@#include <linux/pm_domain.h> #include <linux/regmap.h> #include <linux/reset.h> +#include <linux/module.h> #include "pcie-designware.h" drivers/usb/cdns3/host.c +0
-0
drivers/usb/cdns3/host.c line 13
Quoted 4 lines
drivers/usb/cdns3/host.c +1
-0@@ -10,6 +10,7 @@*/ #include <linux/platform_device.h> +#include <linux/slab.h>
Should be "#include <linux/module.h>"?
Signature · 2 lines
Thanks, Peter Chen
Jakub Kicinski
maintainerQuoted 11 lines · On Sat, 20 Nov 2021 15:30:11 +0800 Peter Chen wrote:
drivers/usb/cdns3/host.c line 13
Quoted 9 lines
drivers/usb/cdns3/host.c +1
-0@@ -10,6 +10,7 @@*/ #include <linux/platform_device.h> +#include <linux/slab.h> Should be "#include <
linux/module.h>"?
Why? Different files are missing different includes, this one needs slab.h:
../drivers/usb/cdns3/host.c: In function ‘__cdns_host_init’:../drivers/usb/cdns3/host.c:86:2: error: implicit declaration of function ‘kfree’; did you mean ‘vfree’? [-Werror=implicit-function-declaration]
kfree(cdns->xhci_plat_data);
^~~~~
vfree
Quoted 13 lines · Jakub Kicinski
Quoted 11 lines · On Sat, 20 Nov 2021 15:30:11 +0800 Peter Chen wrote:
drivers/usb/cdns3/host.c line 13
Quoted 9 lines
drivers/usb/cdns3/host.c +1
-0@@ -10,6 +10,7 @@*/ #include <linux/platform_device.h> +#include <linux/slab.h> Should be "#include <
linux/module.h>"?
Quoted 8 lines
Why? Different files are missing different includes, this one needs
slab.h:
../drivers/usb/cdns3/host.c: In function ‘__cdns_host_init’:../drivers/usb/cdns3/host.c:86:2: error: implicit declaration of function ‘kfree’; did you mean ‘vfree’? [-Werror=implicit-function-declaration]
kfree(cdns->xhci_plat_data);
^~~~~
vfree
Oh, my fault.
Signature · 2 lines
Thanks, Peter Chen
Hi Jakub,
Quoted 6 lines · On Fri, 19 Nov 2021 19:52:53 -0800 Jakub Kicinski <[email protected]> wrote:
cgroup.h(thereforeswap.h, therefore half of the universe) includesbpf.hwhich in turn includesmodule.handslab.h. Since we're about to get rid of that dependency we need to clean things up.Signed-off-by Jakub Kicinski <[email protected]>
for DAMON part.
Thanks,
SJ
[...]
kernel test robot
build botI love your patch! Yet something to improve:
Hi Jakub,
I love your patch! Yet something to improve:
[auto build test ERROR on bpf/master]
url: https://github.com/0day-ci/linux/commits/Jakub-Kicinski/treewide-add-missing-includes-masked-by-cgroup-bpf-dependency/20211120-115325 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git master config: riscv-rv32_defconfig (attached as .config) compiler: riscv32-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/e31b3bdd266ef8f63543f27cf7493e98112fd74a
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jakub-Kicinski/treewide-add-missing-includes-masked-by-cgroup-bpf-dependency/20211120-115325 git checkout e31b3bdd266ef8f63543f27cf7493e98112fd74a
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=riscv SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
All errors (new ones prefixed by >>):
In file included from arch/riscv/include/asm/module.h:7,
from include/linux/module.h:33,
from include/linux/device/driver.h:21,
from include/linux/device.h:32,
from include/linux/node.h:18,
from include/linux/cpu.h:17,
from include/linux/cacheinfo.h:6,
from arch/riscv/include/asm/cacheinfo.h:9, from arch/riscv/include/asm/elf.h:14,
from include/linux/elf.h:6,
from arch/riscv/kernel/ptrace.c:16:
include/asm-generic/module.h:33:25: error: unknown type name 'Elf32_Shdr'
33 | #define Elf_Shdr Elf32_Shdr
| ^~~~~~~~~~
arch/riscv/include/asm/module.h:15:9: note: in expansion of macro 'Elf_Shdr'
15 | Elf_Shdr *shdr;
| ^~~~~~~~
In file included from include/linux/module.h:33,
from include/linux/device/driver.h:21,
from include/linux/device.h:32,
from include/linux/node.h:18,
from include/linux/cpu.h:17,
from include/linux/cacheinfo.h:6,
from arch/riscv/include/asm/cacheinfo.h:9,
from arch/riscv/include/asm/elf.h:14,
from include/linux/elf.h:6,
from arch/riscv/kernel/ptrace.c:16:
arch/riscv/include/asm/module.h: In function 'get_got_entry':
arch/riscv/include/asm/module.h:38:63: error: request for member 'sh_addr' in something not a structure or union
38 | struct got_entry *got = (struct got_entry *)(sec->shdr->sh_addr);
| ^~
arch/riscv/include/asm/module.h: In function 'get_got_plt_idx':
arch/riscv/include/asm/module.h:91:66: error: request for member 'sh_addr' in something not a structure or union
91 | struct got_entry *got_plt = (struct got_entry *)sec->shdr->sh_addr;
| ^~
arch/riscv/include/asm/module.h: In function 'get_plt_entry':
arch/riscv/include/asm/module.h:104:66: error: request for member 'sh_addr' in something not a structure or union
104 | struct plt_entry *plt = (struct plt_entry *)sec_plt->shdr->sh_addr;
| ^~
In file included from arch/riscv/include/asm/module.h:7,
from include/linux/module.h:33,
from include/linux/device/driver.h:21,
from include/linux/device.h:32,
from include/linux/node.h:18,
from include/linux/cpu.h:17,
from include/linux/cacheinfo.h:6,
from arch/riscv/include/asm/cacheinfo.h:9,
from arch/riscv/include/asm/elf.h:14,
from include/linux/elf.h:6,
from arch/riscv/kernel/ptrace.c:16:
include/linux/module.h: At top level:
>> include/asm-generic/module.h:35:25: error: unknown type name 'Elf32_Sym'
35 | #define Elf_Sym Elf32_Sym
| ^~~~~~~~~
include/linux/module.h:349:9: note: in expansion of macro 'Elf_Sym'
349 | Elf_Sym *symtab;
| ^~~~~~~
>> include/asm-generic/module.h:35:25: error: unknown type name 'Elf32_Sym'
35 | #define Elf_Sym Elf32_Sym
| ^~~~~~~~~
include/linux/module.h:547:57: note: in expansion of macro 'Elf_Sym'
547 | static inline unsigned long kallsyms_symbol_value(const Elf_Sym *sym)
| ^~~~~~~
In file included from include/linux/device/driver.h:21,
from include/linux/device.h:32,
from include/linux/node.h:18,
from include/linux/cpu.h:17,
from include/linux/cacheinfo.h:6,
from arch/riscv/include/asm/cacheinfo.h:9,
from arch/riscv/include/asm/elf.h:14,
from include/linux/elf.h:6,
from arch/riscv/kernel/ptrace.c:16:
include/linux/module.h: In function 'kallsyms_symbol_value':
include/linux/module.h:549:19: error: request for member 'st_value' in something not a structure or union
549 | return sym->st_value;
| ^~
In file included from arch/riscv/include/asm/module.h:7,
from include/linux/module.h:33,
from include/linux/device/driver.h:21,
from include/linux/device.h:32,
from include/linux/node.h:18,
from include/linux/cpu.h:17,
from include/linux/cacheinfo.h:6,
from arch/riscv/include/asm/cacheinfo.h:9,
from arch/riscv/include/asm/elf.h:14,
from include/linux/elf.h:6,
from arch/riscv/kernel/ptrace.c:16:
include/linux/module.h: At top level:
include/asm-generic/module.h:37:25: error: unknown type name 'Elf32_Ehdr'
37 | #define Elf_Ehdr Elf32_Ehdr
| ^~~~~~~~~~
include/linux/module.h:835:32: note: in expansion of macro 'Elf_Ehdr'
835 | void module_bug_finalize(const Elf_Ehdr *, const Elf_Shdr *,
| ^~~~~~~~
include/asm-generic/module.h:33:25: error: unknown type name 'Elf32_Shdr'
33 | #define Elf_Shdr Elf32_Shdr
| ^~~~~~~~~~ include/linux/module.h:835:50: note: in expansion of macro 'Elf_Shdr'
835 | void module_bug_finalize(const Elf_Ehdr *, const Elf_Shdr *,
| ^~~~~~~~
--
In file included from arch/riscv/include/asm/module.h:7,
from include/linux/module.h:33,
from include/linux/device/driver.h:21,
from include/linux/device.h:32,
from include/linux/node.h:18,
from include/linux/cpu.h:17,
from include/linux/cacheinfo.h:6,
from arch/riscv/include/asm/cacheinfo.h:9, from arch/riscv/include/asm/elf.h:14,
from include/linux/elf.h:6,
from arch/riscv/kernel/module-sections.c:8:
include/asm-generic/module.h:33:25: error: unknown type name 'Elf32_Shdr'
33 | #define Elf_Shdr Elf32_Shdr
| ^~~~~~~~~~
arch/riscv/include/asm/module.h:15:9: note: in expansion of macro 'Elf_Shdr'
15 | Elf_Shdr *shdr;
| ^~~~~~~~
In file included from include/linux/module.h:33,
from include/linux/device/driver.h:21,
from include/linux/device.h:32,
from include/linux/node.h:18,
from include/linux/cpu.h:17,
from include/linux/cacheinfo.h:6,
from arch/riscv/include/asm/cacheinfo.h:9,
from arch/riscv/include/asm/elf.h:14,
from include/linux/elf.h:6,
from arch/riscv/kernel/module-sections.c:8:
arch/riscv/include/asm/module.h: In function 'get_got_entry':
arch/riscv/include/asm/module.h:38:63: error: request for member 'sh_addr' in something not a structure or union
38 | struct got_entry *got = (struct got_entry *)(sec->shdr->sh_addr);
| ^~
arch/riscv/include/asm/module.h: In function 'get_got_plt_idx':
arch/riscv/include/asm/module.h:91:66: error: request for member 'sh_addr' in something not a structure or union
91 | struct got_entry *got_plt = (struct got_entry *)sec->shdr->sh_addr;
| ^~
arch/riscv/include/asm/module.h: In function 'get_plt_entry':
arch/riscv/include/asm/module.h:104:66: error: request for member 'sh_addr' in something not a structure or union
104 | struct plt_entry *plt = (struct plt_entry *)sec_plt->shdr->sh_addr;
| ^~
In file included from arch/riscv/include/asm/module.h:7,
from include/linux/module.h:33,
from include/linux/device/driver.h:21,
from include/linux/device.h:32,
from include/linux/node.h:18,
from include/linux/cpu.h:17,
from include/linux/cacheinfo.h:6,
from arch/riscv/include/asm/cacheinfo.h:9,
from arch/riscv/include/asm/elf.h:14,
from include/linux/elf.h:6,
from arch/riscv/kernel/module-sections.c:8:
include/linux/module.h: At top level:
>> include/asm-generic/module.h:35:25: error: unknown type name 'Elf32_Sym'
35 | #define Elf_Sym Elf32_Sym
| ^~~~~~~~~
include/linux/module.h:349:9: note: in expansion of macro 'Elf_Sym'
349 | Elf_Sym *symtab;
| ^~~~~~~
>> include/asm-generic/module.h:35:25: error: unknown type name 'Elf32_Sym'
35 | #define Elf_Sym Elf32_Sym
| ^~~~~~~~~
include/linux/module.h:547:57: note: in expansion of macro 'Elf_Sym'
547 | static inline unsigned long kallsyms_symbol_value(const Elf_Sym *sym)
| ^~~~~~~
In file included from include/linux/device/driver.h:21,
from include/linux/device.h:32,
from include/linux/node.h:18,
from include/linux/cpu.h:17,
from include/linux/cacheinfo.h:6,
from arch/riscv/include/asm/cacheinfo.h:9,
from arch/riscv/include/asm/elf.h:14,
from include/linux/elf.h:6,
from arch/riscv/kernel/module-sections.c:8:
include/linux/module.h: In function 'kallsyms_symbol_value':
include/linux/module.h:549:19: error: request for member 'st_value' in something not a structure or union
549 | return sym->st_value;
| ^~
In file included from arch/riscv/include/asm/module.h:7,
from include/linux/module.h:33,
from include/linux/device/driver.h:21,
from include/linux/device.h:32,
from include/linux/node.h:18,
from include/linux/cpu.h:17,
from include/linux/cacheinfo.h:6,
from arch/riscv/include/asm/cacheinfo.h:9,
from arch/riscv/include/asm/elf.h:14,
from include/linux/elf.h:6,
from arch/riscv/kernel/module-sections.c:8:
include/linux/module.h: At top level:
include/asm-generic/module.h:37:25: error: unknown type name 'Elf32_Ehdr'
37 | #define Elf_Ehdr Elf32_Ehdr
| ^~~~~~~~~~
include/linux/module.h:835:32: note: in expansion of macro 'Elf_Ehdr'
835 | void module_bug_finalize(const Elf_Ehdr *, const Elf_Shdr *,
| ^~~~~~~~
include/asm-generic/module.h:33:25: error: unknown type name 'Elf32_Shdr'
33 | #define Elf_Shdr Elf32_Shdr
| ^~~~~~~~~~
include/linux/module.h:835:50: note: in expansion of macro 'Elf_Shdr'
835 | void module_bug_finalize(const Elf_Ehdr *, const Elf_Shdr *,
| ^~~~~~~~
arch/riscv/kernel/module-sections.c: In function 'module_emit_got_entry':
arch/riscv/kernel/module-sections.c:23:48: error: request for member 'sh_addr' in something not a structure or union
23 | got = (struct got_entry *)got_sec->shdr->sh_addr;
| ^~
arch/riscv/kernel/module-sections.c: In function 'module_emit_plt_entry':
arch/riscv/kernel/module-sections.c:44:56: error: request for member 'sh_addr' in something not a structure or union
44 | got_plt = (struct got_entry *)got_plt_sec->shdr->sh_addr;
| ^~
arch/riscv/kernel/module-sections.c:46:48: error: request for member 'sh_addr' in something not a structure or union
46 | plt = (struct plt_entry *)plt_sec->shdr->sh_addr;
| ^~
arch/riscv/kernel/module-sections.c: In function 'module_frob_arch_sections':
>> arch/riscv/kernel/module-sections.c:102:44: error: assignment to 'int *' from incompatible pointer type 'Elf32_Shdr *' {aka 'struct elf32_shdr *'} [-Werror=incompatible-pointer-types]
102 | mod->arch.plt.shdr = sechdrs + i;
| ^
arch/riscv/kernel/module-sections.c:104:44: error: assignment to 'int *' from incompatible pointer type 'Elf32_Shdr *' {aka 'struct elf32_shdr *'} [-Werror=incompatible-pointer-types]
104 | mod->arch.got.shdr = sechdrs + i;
| ^
arch/riscv/kernel/module-sections.c:106:48: error: assignment to 'int *' from incompatible pointer type 'Elf32_Shdr *' {aka 'struct elf32_shdr *'} [-Werror=incompatible-pointer-types]
106 | mod->arch.got_plt.shdr = sechdrs + i;
| ^
arch/riscv/kernel/module-sections.c:138:27: error: request for member 'sh_type' in something not a structure or union
138 | mod->arch.plt.shdr->sh_type = SHT_NOBITS;
| ^~
arch/riscv/kernel/module-sections.c:139:27: error: request for member 'sh_flags' in something not a structure or union
139 | mod->arch.plt.shdr->sh_flags = SHF_EXECINSTR | SHF_ALLOC;
| ^~
arch/riscv/kernel/module-sections.c:140:27: error: request for member 'sh_addralign' in something not a structure or union
140 | mod->arch.plt.shdr->sh_addralign = L1_CACHE_BYTES;
| ^~
arch/riscv/kernel/module-sections.c:141:27: error: request for member 'sh_size' in something not a structure or union
141 | mod->arch.plt.shdr->sh_size = (num_plts + 1) * sizeof(struct plt_entry);
| ^~
arch/riscv/kernel/module-sections.c:145:27: error: request for member 'sh_type' in something not a structure or union
145 | mod->arch.got.shdr->sh_type = SHT_NOBITS;
| ^~
arch/riscv/kernel/module-sections.c:146:27: error: request for member 'sh_flags' in something not a structure or union
146 | mod->arch.got.shdr->sh_flags = SHF_ALLOC;
| ^~
arch/riscv/kernel/module-sections.c:147:27: error: request for member 'sh_addralign' in something not a structure or union
147 | mod->arch.got.shdr->sh_addralign = L1_CACHE_BYTES;
| ^~
arch/riscv/kernel/module-sections.c:148:27: error: request for member 'sh_size' in something not a structure or union
148 | mod->arch.got.shdr->sh_size = (num_gots + 1) * sizeof(struct got_entry);
| ^~
arch/riscv/kernel/module-sections.c:152:31: error: request for member 'sh_type' in something not a structure or union
152 | mod->arch.got_plt.shdr->sh_type = SHT_NOBITS;
| ^~
arch/riscv/kernel/module-sections.c:153:31: error: request for member 'sh_flags' in something not a structure or union
153 | mod->arch.got_plt.shdr->sh_flags = SHF_ALLOC;
| ^~
arch/riscv/kernel/module-sections.c:154:31: error: request for member 'sh_addralign' in something not a structure or union
154 | mod->arch.got_plt.shdr->sh_addralign = L1_CACHE_BYTES;
| ^~
arch/riscv/kernel/module-sections.c:155:31: error: request for member 'sh_size' in something not a structure or union
155 | mod->arch.got_plt.shdr->sh_size = (num_plts + 1) * sizeof(struct got_entry);
| ^~cc1: some warnings being treated as errors
vim +/Elf32_Sym +35 include/asm-generic/module.h
786d35d45cc40b David Howells 2012-09-28 32 aafe4dbed0bf6c Arnd Bergmann 2009-05-13 33 #define Elf_Shdr Elf32_Shdr 786d35d45cc40b David Howells 2012-09-28 34 #define Elf_Phdr Elf32_Phdr aafe4dbed0bf6c Arnd Bergmann 2009-05-13 @35 #define Elf_Sym Elf32_Sym 786d35d45cc40b David Howells 2012-09-28 36 #define Elf_Dyn Elf32_Dyn aafe4dbed0bf6c Arnd Bergmann 2009-05-13 37 #define Elf_Ehdr Elf32_Ehdr 786d35d45cc40b David Howells 2012-09-28 38 #define Elf_Addr Elf32_Addr 786d35d45cc40b David Howells 2012-09-28 39 #ifdef CONFIG_MODULES_USE_ELF_REL 786d35d45cc40b David Howells 2012-09-28 40 #define Elf_Rel Elf32_Rel 786d35d45cc40b David Howells 2012-09-28 41 #endif 786d35d45cc40b David Howells 2012-09-28 42 #ifdef CONFIG_MODULES_USE_ELF_RELA 786d35d45cc40b David Howells 2012-09-28 43 #define Elf_Rela Elf32_Rela 786d35d45cc40b David Howells 2012-09-28 44 #endif 786d35d45cc40b David Howells 2012-09-28 45 #define ELF_R_TYPE(X) ELF32_R_TYPE(X) 786d35d45cc40b David Howells 2012-09-28 46 #define ELF_R_SYM(X) ELF32_R_SYM(X) aafe4dbed0bf6c Arnd Bergmann 2009-05-13 47 #endif
aafe4dbed0bf6c Arnd Bergmann 2009-05-13 48
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
Jakub Kicinski
maintainerQuoted 10 lines · On Sat, 20 Nov 2021 16:55:16 +0800 kernel test robot wrote:
Hi Jakub,
I love your patch! Yet something to improve:
[auto build test ERROR on bpf/master]
url: https://github.com/0day-ci/linux/commits/Jakub-Kicinski/treewide-add-missing-includes-masked-by-cgroup-bpf-dependency/20211120-115325 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git master config: riscv-rv32_defconfig (attached as .config) compiler: riscv32-linux-gcc (GCC) 11.2.0
Quoted 10 lines
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/e31b3bdd266ef8f63543f27cf7493e98112fd74a
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jakub-Kicinski/treewide-add-missing-includes-masked-by-cgroup-bpf-dependency/20211120-115325 git checkoute31b3bdd266ef8f63543f27cf7493e98112fd74a
# save the attached .config to linux build tree
mkdirbuild_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=riscv SHELL=/bin/bash
False positive, riscv seems to have a broken module.h so including it in more places results in more of the same errors.
Quoted 21 lines · Jakub Kicinski
Quoted 10 lines · On Sat, 20 Nov 2021 16:55:16 +0800 kernel test robot wrote:
Hi Jakub,
I love your patch! Yet something to improve:
[auto build test ERROR on bpf/master]
url: https://github.com/0day-ci/linux/commits/Jakub-Kicinski/treewide-add-missing-includes-masked-by-cgroup-bpf-dependency/20211120-115325 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git master config: riscv-rv32_defconfig (attached as .config) compiler: riscv32-linux-gcc (GCC) 11.2.0Quoted 10 lines
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/e31b3bdd266ef8f63543f27cf7493e98112fd74a
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jakub-Kicinski/treewide-add-missing-includes-masked-by-cgroup-bpf-dependency/20211120-115325 git checkoute31b3bdd266ef8f63543f27cf7493e98112fd74a
# save the attached .config to linux build tree
mkdirbuild_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=riscv SHELL=/bin/bash
Quoted 2 lines
False positive, riscv seems to have a broken
module.hso including it in more places results in more of the same errors.
Hi Jakub,
Thanks for the feedback, the bot can't always find the first introduced commit with the bisection method,
we hope someone can fix the reported issues if interested.
Best Regards,
Rong Chen
Jakub Kicinski
maintainerQuoted 6 lines · On Mon, 6 Dec 2021 10:21:00 +0800 Rong Chen wrote:
Quoted 2 lines
False positive, riscv seems to have a broken
module.hso including it in more places results in more of the same errors.Thanks for the feedback, the bot can't always find the first introduced commit with the bisection method,
we hope someone can fix the reported issues if interested.
FWIW I realized later that kbuild bot was actually correct, although the chain of dependencies which cause this wasn't obvious. Apologies.
Quoted 64 lines · Jakub Kicinski
cgroup.h(thereforeswap.h, therefore half of the universe) includesbpf.hwhich in turn includesmodule.handslab.h. Since we're about to get rid of that dependency we need to clean things up.Signed-off-by Jakub Kicinski <[email protected]>---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
Quoted 6 lines
Well, let's see if this makes it thru email servers...
--- block/fops.c | 1 + drivers/gpu/drm/drm_gem_shmem_helper.c | 1 + drivers/gpu/drm/i915/gt/intel_gtt.c | 1 + drivers/gpu/drm/i915/i915_request.c | 1 +
For the i915 parts,
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for treewide: add missing includes masked by cgroup -> bpf dependency
In reply to Jakub Kicinski== Series Details ==
== Series Details ==
Series: treewide: add missing includes masked by cgroup -> bpf dependency
URL : https://patchwork.freedesktop.org/series/97159/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BAT: failure for treewide: add missing includes masked by cgroup -> bpf dependency
In reply to Jakub Kicinski== Series Details ==
== Series Details ==
Series: treewide: add missing includes masked by cgroup -> bpf dependency
URL : https://patchwork.freedesktop.org/series/97159/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10913 -> Patchwork_21653
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_21653 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_21653, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21653/index.html
Participating hosts (43 -> 35)
------------------------------
Missing (8): bat-dg1-6 bat-dg1-5 fi-icl-u2 fi-bsw-cyan bat-adlp-6 bat-adlp-4 bat-jsl-2 bat-jsl-1
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_21653:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@requests:
- fi-kbl-soraka: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10913/fi-kbl-soraka/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21653/fi-kbl-soraka/igt@i915_selftest@[email protected]
Known issues
------------
Here are the changes found in Patchwork_21653 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@semaphore:
- fi-bdw-5557u: NOTRUN -> [SKIP][3] ([fdo#109271]) +31 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21653/fi-bdw-5557u/igt@amdgpu/[email protected]
* igt@kms_chamelium@dp-crc-fast:
- fi-bdw-5557u: NOTRUN -> [SKIP][4] ([fdo#109271] / [fdo#111827]) +8 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21653/fi-bdw-5557u/igt@[email protected]
* igt@runner@aborted:
- fi-kbl-soraka: NOTRUN -> [FAIL][5] ([i915#1436] / [i915#3363] / [i915#4312])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21653/fi-kbl-soraka/igt@[email protected]
#### Possible fixes ####
* igt@core_hotunplug@unbind-rebind:
- fi-tgl-u2: [INCOMPLETE][6] ([i915#4006]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10913/fi-tgl-u2/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21653/fi-tgl-u2/igt@[email protected]
* igt@gem_exec_suspend@basic-s0:
- fi-glk-dsi: [DMESG-WARN][8] ([i915#2943]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10913/fi-glk-dsi/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21653/fi-glk-dsi/igt@[email protected]
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-1115g4: [FAIL][10] ([i915#1888]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10913/fi-tgl-1115g4/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21653/fi-tgl-1115g4/igt@[email protected]
* igt@kms_frontbuffer_tracking@basic:
- fi-cfl-8109u: [DMESG-FAIL][12] ([i915#295]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10913/fi-cfl-8109u/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21653/fi-cfl-8109u/igt@[email protected]
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b:
- fi-cfl-8109u: [DMESG-WARN][14] ([i915#295]) -> [PASS][15] +10 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10913/fi-cfl-8109u/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21653/fi-cfl-8109u/igt@[email protected]
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2943]: https://gitlab.freedesktop.org/drm/intel/issues/2943
[i915#295]: https://gitlab.freedesktop.org/drm/intel/issues/295
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#4006]: https://gitlab.freedesktop.org/drm/intel/issues/4006
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
Build changes
-------------
* Linux: CI_DRM_10913 -> Patchwork_21653
CI-20190529: 20190529
CI_DRM_10913: 2350312b9d034c596a510f1eabff0f74de5f2ab7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6286: cdcbf81f734fdb1d102e84490e49e9fec23760cd @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21653: 05c3e8d39174f709a6c73295c78926990f47dc94 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
05c3e8d39174 treewide: add missing includes masked by cgroup -> bpf dependency
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21653/index.html