Skip to contentSkip to conversation

core-image-ptest-all,core-image-ptest-fast: Depend on core-image class

PATCH Superseded Khem Raj 2 participants 3 messages Nov 20, 2021 – Nov 21, 2021

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/2 core-image-ptest-all,core-image-ptest-fast: Depend on core-image class

Use the default packages as mentioned in core-image-base without splash since many machines ( e.g. raspberrypi ) add packages to enable wifi/bt via MACHINE_EXTRA_RRECOMMENDS which are essential to boot the system without errors, otherwise there are errors about BT firmware not being found etc. which is then marked as failure and also services like btuart fail to start and it marked as failure in system logs

Using default base package groups addresses this issue amicably

---
 meta/recipes-core/images/core-image-ptest-all.bb  | 3 +--
 meta/recipes-core/images/core-image-ptest-fast.bb | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)
meta/recipes-core/images/core-image-ptest-all.bb +1 -2
index 1472451675e..8edd9a2b886 100644
@@ -1,7 +1,6 @@
-inherit features_check
+inherit core-image features_check
 REQUIRED_DISTRO_FEATURES = "ptest"
 
-require core-image-minimal.bb
 require conf/distro/include/ptest-packagelists.inc
 
 DESCRIPTION += "Also includes ptest packages."
meta/recipes-core/images/core-image-ptest-fast.bb +1 -2
index 40df274c4c1..286f20e547c 100644
@@ -1,7 +1,6 @@
-inherit features_check
+inherit core-image features_check
 REQUIRED_DISTRO_FEATURES = "ptest"
 
-require core-image-minimal.bb
 require conf/distro/include/ptest-packagelists.inc
 
 # Include only fast (< 30 sec) ptests
Signature · 1 line
2.34.0
author
#1 lore raw

PATCH 2/2 core-image-base: Remove psplash from required features

base-image boots in degraded mode when using systems without display system since there is no fb device detected and pslash service would fail to start. Removing this image feature means that core-image-base is complete for headless devices

---
 meta/recipes-core/images/core-image-base.bb | 2 --
 1 file changed, 2 deletions(-)
meta/recipes-core/images/core-image-base.bb +0 -2
index 75a08cfc92a..ced8de6c14f 100644
@@ -1,8 +1,6 @@
 SUMMARY = "A console-only image that fully supports the target device \
 hardware."
 
-IMAGE_FEATURES += "splash"
-
 LICENSE = "MIT"
 
 inherit core-image
Signature · 1 line
2.34.0
#2 lore raw

Re: [OE-core] [PATCH 2/2] core-image-base: Remove psplash from required features

Quoted 15 lines · Khem Raj

base-image boots in degraded mode when using systems without display system since there is no fb device detected and pslash service would fail to start. Removing this image feature means that core-image-base is complete for headless devices

---
 meta/recipes-core/images/core-image-base.bb | 2 --
 1 file changed, 2 deletions(-)
meta/recipes-core/images/core-image-base.bb +0 -0
index 75a08cfc92a..ced8de6c14f 100644

meta/recipes-core/images/core-image-base.bb line 6

Quoted 8 lines
meta/recipes-core/images/core-image-base.bb +0 -2
@@ -1,8 +1,6 @@
 SUMMARY = "A console-only image that fully supports the target device \
 hardware."
 
-IMAGE_FEATURES += "splash"
-
 LICENSE = "MIT"
 
 inherit core-image

I think the way this was originally intended to work was to have a MACHINE_FEATURE which represented the possibility of a display, then the image could configure itself accordingly. Removing features from images to the lowest common denominator of any given hardware doesn't seem like the correct thing to do...

Cheers,

Richard