Skip to contentSkip to conversation

x86/pmu: Make "ref cycles" test to pass on the latest cpu

PATCH Superseded Like Xu 1 participant 1 message Nov 22, 2021 KVM

lore
Share & tools
lore

Like Xu

author
#0 lore raw

PATCH 1/1 x86/pmu: Make "ref cycles" test to pass on the latest cpu

From: Like Xu <[email protected]>

Expand the boundary for "ref cycles" event test as it has been observed that the results do not fit on some CPUs [1]:

FAIL: full-width writes: ref cycles-N
100000 >= 87765 <= 30000000
100000 >= 87926 <= 30000000
100000 >= 87790 <= 30000000
100000 >= 87687 <= 30000000
100000 >= 87875 <= 30000000
100000 >= 88043 <= 30000000
100000 >= 88161 <= 30000000
100000 >= 88052 <= 30000000

[1] Intel(R) Xeon(R) Platinum 8374C CPU @ 2.70GHz

Opportunistically fix cc1 warnings for commented print statement.

---
 x86/pmu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
x86/pmu.c +2 -2
index 92206ad..3d05384 100644
@@ -86,7 +86,7 @@ struct pmu_event {
 } gp_events[] = {
 	{"core cycles", 0x003c, 1*N, 50*N},
 	{"instructions", 0x00c0, 10*N, 10.2*N},
-	{"ref cycles", 0x013c, 0.1*N, 30*N},
+       {"ref cycles", 0x013c, 0.08*N, 30*N},
 	{"llc refference", 0x4f2e, 1, 2*N},
 	{"llc misses", 0x412e, 1, 1*N},
 	{"branches", 0x00c4, 1*N, 1.1*N},
@@ -223,7 +223,7 @@ static void measure(pmu_counter_t *evt, int count)
 
 static bool verify_event(uint64_t count, struct pmu_event *e)
 {
-	// printf("%lld >= %lld <= %lld\n", e->min, count, e->max);
+	// printf("%d >= %ld <= %d\n", e->min, count, e->max);
 	return count >= e->min  && count <= e->max;
 
 }
Signature · 1 line
2.33.1