ARM: pxa/lubbock: Replace custom ->cs_control() by GPIO lookup table
Subsystems (3)
PATCH 1/1 ARM: pxa/lubbock: Replace custom ->cs_control() by GPIO lookup table
SPI PXA2xx driver supports GPIO chipselect by querying for known GPIO connection ID. Replace custom ->cs_control() by GPIO table, so the driver will use generic approach on this platform.
Signed-off-by Andy Shevchenko <[email protected]>
--- arch/arm/mach-pxa/lubbock.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-)
arch/arm/mach-pxa/lubbock.c +9 -6
@@ -211,16 +211,17 @@ static struct ads7846_platform_data ads_info = {// .y_plate_ohms = 500, /* GUESS! */ }; -static void ads7846_cs (u32 command) -{ -static const unsigned TS_nCS =1 <<11 ; -lubbock_set_misc_wr (TS_nCS, (command ==PXA2XX_CS_ASSERT ) ?0 : TS_nCS); -} +static struct gpiod_lookup_table ads7846_cs_gpios = { + .dev_id ="ads7846" , + .table = { +GPIO_LOOKUP ("lubbock" ,11 ,"cs" ,GPIO_ACTIVE_LOW ), + {} + }, +};static struct pxa2xx_spi_chip ads_hw = { .tx_threshold =1 , .rx_threshold =2 , - .cs_control = ads7846_cs, };static struct spi_board_info spi_board_info[]__initdata = { {
@@ -512,6 +513,8 @@ static void __init lubbock_init(void) lubbock_flash_data[flashboot].name ="boot-rom" ; (void )platform_add_devices (devices,ARRAY_SIZE (devices)); +gpiod_add_lookup_table (&ads7846_cs_gpios); +pxa2xx_set_spi_info (1 , &pxa_ssp_master_info);spi_register_board_info (spi_board_info,ARRAY_SIZE (spi_board_info)); }
Signature · 1 line
2.33.0
Quoted 3 lines · Andy Shevchenko
SPI PXA2xx driver supports GPIO chipselect by querying for known GPIO connection ID. Replace custom ->cs_control() by GPIO table, so the driver will use generic approach on this platform.
Okay, I think it would be first patch in a series of getting rid of cs_control. So, please give your Acks, etc here, and I will appreciate any testing in case you are in possession of such platform.
Signature · 2 lines
With Best Regards, Andy Shevchenko