Skip to contentSkip to conversation

hugetlb: Fix spelling mistake "hierarichal" -> "hierarchical"

PATCH In review Colin Ian King 3 participants 5 messages Nov 25, 2021 – Nov 26, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hugetlb: Fix spelling mistake "hierarichal" -> "hierarchical"

There is a spelling mistake in a literal string and a comment. Fix them.

---
 mm/hugetlb_cgroup.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
mm/hugetlb_cgroup.c +2 -2
index 9bdcf6560849..9eebe8df3c39 100644
@@ -495,11 +495,11 @@ static int hugetlb_cgroup_read_numa_stat(struct seq_file *seq, void *dummy)
 	 * The hierarchical total is pretty much the value recorded by the
 	 * counter, so use that.
 	 */
-	seq_printf(seq, "%stotal=%lu", legacy ? "hierarichal_" : "",
+	seq_printf(seq, "%stotal=%lu", legacy ? "hierarchical_" : "",
 		   page_counter_read(&h_cg->hugepage[idx]) * PAGE_SIZE);
 
 	/*
-	 * For each node, transverse the css tree to obtain the hierarichal
+	 * For each node, transverse the css tree to obtain the hierarchical
 	 * node usage.
 	 */
 	for_each_node_state(nid, N_MEMORY) {
Signature · 1 line
2.33.1
#2 lore raw
In reply to Colin Ian King
Quoted 1 line · Colin Ian King

There is a spelling mistake in a literal string and a comment. Fix them.

[]

mm/hugetlb_cgroup.c

Quoted 1 line
mm/hugetlb_cgroup.c +0 -0

[]

mm/hugetlb_cgroup.c static int hugetlb_cgroup_read_numa_stat(struct seq_file *seq, void *dummy) · line 499

Quoted 7 lines
mm/hugetlb_cgroup.c +1 -1
@@ -495,11 +495,11 @@ static int hugetlb_cgroup_read_numa_stat(struct seq_file *seq, void *dummy)
 	 * The hierarchical total is pretty much the value recorded by the
 	 * counter, so use that.
 	 */
-	seq_printf(seq, "%stotal=%lu", legacy ? "hierarichal_" : "",
+	seq_printf(seq, "%stotal=%lu", legacy ? "hierarchical_" : "",
 		   page_counter_read(&h_cg->hugepage[idx]) * PAGE_SIZE);

Not sure this should be changed as seq output is nominally ABI.

mm/hugetlb_cgroup.c static int hugetlb_cgroup_read_numa_stat(struct seq_file *seq, void *dummy) · line 502

Quoted 4 lines
mm/hugetlb_cgroup.c +1 -1
 	/*
-	 * For each node, transverse the css tree to obtain the hierarichal
+	 * For each node, transverse the css tree to obtain the hierarchical

Fixing the comment typo is good. Thanks.

#3 lore raw
Quoted 5 lines · Joe Perches
Quoted 1 line · Colin Ian King

There is a spelling mistake in a literal string and a comment. Fix them.

[]

mm/hugetlb_cgroup.c

Quoted 1 line
mm/hugetlb_cgroup.c +0 -0

[]

Quoted 9 lines

mm/hugetlb_cgroup.c static int hugetlb_cgroup_read_numa_stat(struct seq_file *seq, void *dummy) · line 499

Quoted 7 lines
mm/hugetlb_cgroup.c +1 -1
@@ -495,11 +495,11 @@ static int hugetlb_cgroup_read_numa_stat(struct seq_file *seq, void *dummy)
  	 * The hierarchical total is pretty much the value recorded by the
  	 * counter, so use that.
  	 */
-	seq_printf(seq, "%stotal=%lu", legacy ? "hierarichal_" : "",
+	seq_printf(seq, "%stotal=%lu", legacy ? "hierarchical_" : "",
  		   page_counter_read(&h_cg->hugepage[idx]) * PAGE_SIZE);

Not sure this should be changed as seq output is nominally ABI.

This just landed in linux-next, so I doubt many folk are using it. Let's fix it before it lands mainline.

Quoted 9 lines

mm/hugetlb_cgroup.c static int hugetlb_cgroup_read_numa_stat(struct seq_file *seq, void *dummy) · line 502

Quoted 5 lines
mm/hugetlb_cgroup.c +1 -1
  	/*
-	 * For each node, transverse the css tree to obtain the hierarichal
+	 * For each node, transverse the css tree to obtain the hierarchical

Fixing the comment typo is good. Thanks.

#4 lore raw
Quoted 17 lines · Colin King (gmail)
Quoted 5 lines · Joe Perches
Quoted 1 line · Colin Ian King

There is a spelling mistake in a literal string and a comment. Fix them.

[]

mm/hugetlb_cgroup.c

Quoted 1 line
mm/hugetlb_cgroup.c +0 -0

[]

Quoted 9 lines

mm/hugetlb_cgroup.c static int hugetlb_cgroup_read_numa_stat(struct seq_file *seq, void *dummy) · line 499

Quoted 7 lines
mm/hugetlb_cgroup.c +1 -1
@@ -495,11 +495,11 @@ static int hugetlb_cgroup_read_numa_stat(struct seq_file *seq, void *dummy)
      * The hierarchical total is pretty much the value recorded by the
      * counter, so use that.
      */
-    seq_printf(seq, "%stotal=%lu", legacy ? "hierarichal_" : "",
+    seq_printf(seq, "%stotal=%lu", legacy ? "hierarchical_" : "",
                page_counter_read(&h_cg->hugepage[idx]) * PAGE_SIZE);

Not sure this should be changed as seq output is nominally ABI.

Quoted 2 lines

This just landed in linux-next, so I doubt many folk are using it. Let's fix it before it lands mainline.

Totally agree.

Quoted 11 lines
Quoted 10 lines

mm/hugetlb_cgroup.c static int hugetlb_cgroup_read_numa_stat(struct seq_file *seq, void *dummy) · line 502

Quoted 6 lines
mm/hugetlb_cgroup.c +1 -1
     /*
-     * For each node, transverse the css tree to obtain the hierarichal
+     * For each node, transverse the css tree to obtain the hierarchical

Fixing the comment typo is good. Thanks.