RDMA/rtrs-clt: Fix the initial value of min_latency
Subsystems (2)
Jack Wang
maintainerPATCH 1/1 RDMA/rtrs-clt: Fix the initial value of min_latency
The type of min_latency is ktime_t, so use KTIME_MAX to initialize the initial value.
--- drivers/infiniband/ulp/rtrs/rtrs-clt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/ulp/rtrs/rtrs-clt.c +1 -1
@@ -867,7 +867,7 @@ static struct rtrs_clt_sess *get_next_path_min_latency(struct path_it *it)struct rtrs_clt_sess *min_path =NULL ;struct rtrs_clt *clt = it->clt;struct rtrs_clt_sess *sess; -ktime_t min_latency =INT_MAX ; +ktime_t min_latency =KTIME_MAX ;ktime_t latency;list_for_each_entry_rcu (sess, &clt->paths_list, s.entry) {
Signature · 1 line
2.25.1
Quoted 14 lines · Jack Wang
The type of
min_latencyisktime_t, so useKTIME_MAXto initialize the initial value.Fixes dc3b66a0ce70 ("RDMA/rtrs-clt: Add a minimum latency multipath policy")Signed-off-by Jack Wang<[email protected]>--- drivers/infiniband/ulp/rtrs/rtrs-clt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/infiniband/ulp/rtrs/rtrs-clt.c +0
-0
drivers/infiniband/ulp/rtrs/rtrs-clt.c static struct rtrs_clt_sess *get_next_path_min_latency(struct path_it *it) · line 873
Quoted 8 lines
drivers/infiniband/ulp/rtrs/rtrs-clt.c +1
-1@@ -867,7 +867,7 @@ static struct rtrs_clt_sess *get_next_path_min_latency(struct path_it *it)struct rtrs_clt_sess *min_path =NULL ;struct rtrs_clt *clt = it->clt;struct rtrs_clt_sess *sess; -ktime_t min_latency =INT_MAX ; +ktime_t min_latency =KTIME_MAX ;ktime_t latency;list_for_each_entry_rcu (sess, &clt->paths_list, s.entry) {
LGTM.
Thanks,
Guoqing
Jinpu Wang
maintainerQuoted 25 lines · Guoqing Jiang
Quoted 21 lines · Jack Wang
The type of
min_latencyisktime_t, so useKTIME_MAXto initialize the initial value.Fixes dc3b66a0ce70 ("RDMA/rtrs-clt: Add a minimum latency multipath policy")Signed-off-by Jack Wang<[email protected]>--- drivers/infiniband/ulp/rtrs/rtrs-clt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/infiniband/ulp/rtrs/rtrs-clt.c +1
-1@@ -867,7 +867,7 @@ static struct rtrs_clt_sess *get_next_path_min_latency(struct path_it *it)struct rtrs_clt_sess *min_path =NULL ;struct rtrs_clt *clt = it->clt;struct rtrs_clt_sess *sess; -ktime_t min_latency =INT_MAX ; +ktime_t min_latency =KTIME_MAX ;ktime_t latency;
Quoted 5 lines
drivers/infiniband/ulp/rtrs/rtrs-clt.c static struct rtrs_clt_sess *get_next_path_min_latency(struct path_it *it) · line 873
Quoted 1 line
drivers/infiniband/ulp/rtrs/rtrs-clt.c +0
-0list_for_each_entry_rcu (sess, &clt->paths_list, s.entry) {LGTM.
Reviewed-by Guoqing Jiang <[email protected]>
Thank you for the quick review!
Quoted 3 lines
Thanks,
Guoqing
Quoted 9 lines · Jack Wang
The type of
min_latencyisktime_t, so useKTIME_MAXto initialize the initial value.Fixes dc3b66a0ce70 ("RDMA/rtrs-clt: Add a minimum latency multipath policy")Signed-off-by Jack Wang <[email protected]>Reviewed-by Guoqing Jiang <[email protected]>--- drivers/infiniband/ulp/rtrs/rtrs-clt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-next, thanks
Jason