Skip to contentSkip to conversation

linux-next: build failure after merge of the tip tree

DISCUSSION Stephen Rothwell 3 participants 6 messages Nov 26, 2021 – Dec 1, 2021 Linux-next tree

lore
Share & tools
lore
#0 lore raw

Hi all,

After merging the tip tree, today's linux-next build (sparc defconfig) failed like this:

In file included from arch/sparc/include/asm/futex_32.h:4:0,
from arch/sparc/include/asm/futex.h:7,
from kernel/futex/futex.h:12,
from kernel/futex/core.c:41:
kernel/futex/core.c: In function 'futex_cmpxchg_value_locked':
include/asm-generic/futex.h:17:2: error: implicit declaration of function 'futex_atomic_cmpxchg_inatomic_local_generic'; did you mean 'futex_atomic_cmpxchg_inatomic_local'? [-Werror=implicit-function-declaration]
futex_atomic_cmpxchg_inatomic_local_generic(uval, uaddr, oldval, newval)
^
include/asm-generic/futex.h:17:2: note: in definition of macro 'futex_atomic_cmpxchg_inatomic'
futex_atomic_cmpxchg_inatomic_local_generic(uval, uaddr, oldval, newval)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Caused by commit

3f2bedabb62c ("futex: Ensure futex_atomic_cmpxchg_inatomic() is present")

Gcc version (if it matters):
sparc64-linux-gcc (Custom f51944395b6aa154) 7.3.1 20180130

I have reverted that commit for today (and the following one).

Signature · 2 lines
Cheers,
Stephen Rothwell
#1 lore raw
Quoted 6 lines · Stephen Rothwell

Hi all,

After merging the tip tree, today's linux-next build (sparc defconfig) failed like this:

Quoted 11 lines

In file included from arch/sparc/include/asm/futex_32.h:4:0,
from arch/sparc/include/asm/futex.h:7,
from kernel/futex/futex.h:12,
from kernel/futex/core.c:41:
kernel/futex/core.c: In function 'futex_cmpxchg_value_locked':
include/asm-generic/futex.h:17:2: error: implicit declaration of function 'futex_atomic_cmpxchg_inatomic_local_generic'; did you mean 'futex_atomic_cmpxchg_inatomic_local'? [-Werror=implicit-function-declaration]
futex_atomic_cmpxchg_inatomic_local_generic(uval, uaddr, oldval, newval)
^
include/asm-generic/futex.h:17:2: note: in definition of macro 'futex_atomic_cmpxchg_inatomic'
futex_atomic_cmpxchg_inatomic_local_generic(uval, uaddr, oldval, newval)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Thanks a lot for the report, I sent a fix now:

https://lore.kernel.org/lkml/[email protected]

Arnd

#2 lore raw

Hi all,

Quoted 18 lines · On Fri, 26 Nov 2021 11:01:52 +0100 Arnd Bergmann <[email protected]> wrote:
Quoted 4 lines · Stephen Rothwell

After merging the tip tree, today's linux-next build (sparc defconfig) failed like this:

Quoted 11 lines

In file included from arch/sparc/include/asm/futex_32.h:4:0,
from arch/sparc/include/asm/futex.h:7,
from kernel/futex/futex.h:12,
from kernel/futex/core.c:41:
kernel/futex/core.c: In function 'futex_cmpxchg_value_locked':
include/asm-generic/futex.h:17:2: error: implicit declaration of function 'futex_atomic_cmpxchg_inatomic_local_generic'; did you mean 'futex_atomic_cmpxchg_inatomic_local'? [-Werror=implicit-function-declaration]
futex_atomic_cmpxchg_inatomic_local_generic(uval, uaddr, oldval, newval)
^
include/asm-generic/futex.h:17:2: note: in definition of macro 'futex_atomic_cmpxchg_inatomic'
futex_atomic_cmpxchg_inatomic_local_generic(uval, uaddr, oldval, newval)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Quoted 3 lines

Thanks a lot for the report, I sent a fix now:

https://lore.kernel.org/lkml/[email protected]

I am still getting this failure (Arnd's fix has not been applied).

Signature · 2 lines
Cheers,
Stephen Rothwell
#3 lore raw
Quoted 7 lines · Stephen Rothwell
Quoted 4 lines · On Fri, 26 Nov 2021 11:01:52 +0100 Arnd Bergmann <[email protected]> wrote:

Thanks a lot for the report, I sent a fix now:

https://lore.kernel.org/lkml/[email protected]

I am still getting this failure (Arnd's fix has not been applied).

It got applied, but due to tip maintainer confusion the next branch was not updated. Will be fixed tomorrow.

Thanks,

tglx

#4 lore raw
Quoted 11 lines · Thomas Gleixner
Quoted 7 lines · Stephen Rothwell
Quoted 4 lines · On Fri, 26 Nov 2021 11:01:52 +0100 Arnd Bergmann <[email protected]> wrote:

Thanks a lot for the report, I sent a fix now:

https://lore.kernel.org/lkml/[email protected]

I am still getting this failure (Arnd's fix has not been applied).

It got applied, but due to tip maintainer confusion the next branch was not updated. Will be fixed tomorrow.

Actually now. So still today here :)

#5 lore raw

Hi Thomas,

Quoted 8 lines · On Wed, 01 Dec 2021 23:19:40 +0100 Thomas Gleixner <[email protected]> wrote:
Quoted 5 lines · Thomas Gleixner
Quoted 4 lines · Stephen Rothwell
Quoted 3 lines · On Fri, 26 Nov 2021 11:01:52 +0100 Arnd Bergmann <[email protected]> wrote:

Thanks a lot for the report, I sent a fix now:

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line

https://lore.kernel.org/lkml/[email protected]

I am still getting this failure (Arnd's fix has not been applied).

It got applied, but due to tip maintainer confusion the next branch was not updated. Will be fixed tomorrow.

Actually now. So still today here :)

Thanks, I have that now, so it will go into today's linux-next.

Signature · 2 lines
Cheers,
Stephen Rothwell