ARC: perf: Remove redundant initialization of variable idx
Subsystems (3)
PATCH 1/1 ARC: perf: Remove redundant initialization of variable idx
The variable idx is being initialized with a value that is never read, it is being updated later on. The assignment is redundant and can be removed.
--- arch/arc/kernel/perf_event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arc/kernel/perf_event.c +1 -1
@@ -361,7 +361,7 @@ static int arc_pmu_add(struct perf_event *event, int flags) {struct arc_pmu_cpu *pmu_cpu =this_cpu_ptr (&arc_pmu_cpu);struct hw_perf_event *hwc = &event->hw; -int idx = hwc->idx; +int idx; idx =ffz (pmu_cpu->used_mask[0 ]);if (idx == arc_pmu->n_counters)
Signature · 7 lines
2.33.1 _______________________________________________ linux-snps-arc mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Quoted 23 lines · Colin Ian King
The variable idx is being initialized with a value that is never read, it is being updated later on. The assignment is redundant and can be removed.
Signed-off-by Colin Ian King <[email protected]>--- arch/arc/kernel/perf_event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arc/kernel/perf_event.c +1
-1@@ -361,7 +361,7 @@ static int arc_pmu_add(struct perf_event *event, int flags) {struct arc_pmu_cpu *pmu_cpu =this_cpu_ptr (&arc_pmu_cpu);struct hw_perf_event *hwc = &event->hw; -int idx = hwc->idx; +int idx; idx =ffz (pmu_cpu->used_mask[0 ]);
Quoted 4 lines
if (idx ==
arc_pmu->n_counters)
--
2.33.1
Thank you,
Vladimir Isaev
_______________________________________________
linux-snps-arc mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Vineet Gupta
maintainerQuoted 5 lines · Colin Ian King
The variable idx is being initialized with a value that is never read, it is being updated later on. The assignment is redundant and can be removed.
Signed-off-by Colin Ian King<[email protected]>
Sorry for the delay in getting to this. Added to ARC tree now.
Thx,
-Vineet