Skip to contentSkip to conversation

ASoC: amd: fix uninitialized variable in snd_acp6x_probe()

PATCH In review Dan Carpenter 2 participants 2 messages Nov 30, 2021 – Dec 1, 2021

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: amd: fix uninitialized variable in snd_acp6x_probe()

The "index" is potentially used without being initialized on the error path.

Fixes fc329c1de498 ("ASoC: amd: add platform devices for acp6x pdm driver and dmic driver")
---
 sound/soc/amd/yc/pci-acp6x.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
sound/soc/amd/yc/pci-acp6x.c +2 -1
index 957eeb6fb8e3..7e9a9a9d8ddd 100644
@@ -146,10 +146,11 @@ static int snd_acp6x_probe(struct pci_dev *pci,
 {
 	struct acp6x_dev_data *adata;
 	struct platform_device_info pdevinfo[ACP6x_DEVS];
-	int ret, index;
+	int index = 0;
 	int val = 0x00;
 	u32 addr;
 	unsigned int irqflags;
+	int ret;
 
 	irqflags = IRQF_SHARED;
 	/* Yellow Carp device check */
Signature · 1 line
2.20.1
maintainer
#1 lore raw
Quoted 4 lines · Dan Carpenter

The "index" is potentially used without being initialized on the error path.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-linus

Thanks!

[1/1] ASoC: amd: fix uninitialized variable in snd_acp6x_probe()

      commit: d5c137f41352e8dd864522c417b45d8d1aebca68

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark