Skip to contentSkip to conversation

Add pin control support for lpass sc7280

PATCH In review Srinivasa Rao Mandadapu 4 participants 15 messages Nov 29, 2021 – Dec 1, 2021

Subsystems (6)
lore
Share & tools
lore
#0 lore raw

v3 cover Add pin control support for lpass sc7280

This patch series is to split lpass variant common pin control functions and SoC specific functions and to add lpass sc7280 pincontrol support. It also Adds dt-bindings for lpass sc7280 lpass lpi pincontrol.

Changes Since V2:
-- Add new dt-bindings for sc7280 lpi driver.
-- Make clock voting change as separate patch.
-- Split existing pincontrol driver and make common functions
as part of separate file.
-- Rename lpass pincontrol lpi dt-bindings to sm8250 specific dt-bindings

Changes Since V1:
-- Make lpi pinctrl variant data structure as constant -- Add appropriate commit message
-- Change signedoff by sequence.

Srinivasa Rao Mandadapu (5):
dt-bindings: pinctrl: qcom: Update lpass lpi file name to SoC specific
dt-bindings: pinctrl: qcom: Add sc7280 lpass lpi pinctrl bindings
pinctrl: qcom: Move chip specific functions to right files
pinctrl: qcom: Update clock voting as optional
pinctrl: qcom: Add SC7280 lpass pin configuration

 .../bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml   | 130 -----------
 .../pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml     | 115 ++++++++++
 .../pinctrl/qcom,sm8250-lpass-lpi-pinctrl.yaml     | 130 +++++++++++
 drivers/pinctrl/qcom/Makefile                      |   2 +
 drivers/pinctrl/qcom/pinctrl-lpass-lpi.c           | 253 +--------------------
 drivers/pinctrl/qcom/pinctrl-lpass-lpi.h           | 140 ++++++++++++
 drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c    | 127 +++++++++++
 drivers/pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c    | 125 ++++++++++
 8 files changed, 646 insertions(+), 376 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml
 create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml
 create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sm8250-lpass-lpi-pinctrl.yaml
 create mode 100644 drivers/pinctrl/qcom/pinctrl-lpass-lpi.h
 create mode 100644 drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c
 create mode 100644 drivers/pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c
Signature · 2 lines
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
#1 lore raw

PATCH v3 1/5 dt-bindings: pinctrl: qcom: Update lpass lpi file name to SoC specific

Change generic lpass lpi pincotrol bindings file to SoC specific file, to distinguish and accomadate other SoC specific dt bindings.

---
 .../bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml   | 130 ---------------------
 .../pinctrl/qcom,sm8250-lpass-lpi-pinctrl.yaml     | 130 +++++++++++++++++++++
 2 files changed, 130 insertions(+), 130 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml
 create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sm8250-lpass-lpi-pinctrl.yaml
Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml deleted +0 -130
deleted file mode 100644
index e47ebf9..0000000
@@ -1,130 +0,0 @@
-# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
-%YAML 1.2
----
-$id: http://devicetree.org/schemas/pinctrl/qcom,lpass-lpi-pinctrl.yaml#
-$schema: http://devicetree.org/meta-schemas/core.yaml#
-
-title: Qualcomm Technologies, Inc. Low Power Audio SubSystem (LPASS)
-  Low Power Island (LPI) TLMM block
-
-maintainers:
-  - Srinivas Kandagatla <[email protected]>
-
-description: |
-  This binding describes the Top Level Mode Multiplexer block found in the
-  LPASS LPI IP on most Qualcomm SoCs
-
-properties:
-  compatible:
-    const: qcom,sm8250-lpass-lpi-pinctrl
-
-  reg:
-    minItems: 2
-    maxItems: 2
-
-  clocks:
-    items:
-      - description: LPASS Core voting clock
-      - description: LPASS Audio voting clock
-
-  clock-names:
-    items:
-      - const: core
-      - const: audio
-
-  gpio-controller: true
-
-  '#gpio-cells':
-    description: Specifying the pin number and flags, as defined in
-      include/dt-bindings/gpio/gpio.h
-    const: 2
-
-  gpio-ranges:
-    maxItems: 1
-
-#PIN CONFIGURATION NODES
-patternProperties:
-  '-pins$':
-    type: object
-    description:
-      Pinctrl node's client devices use subnodes for desired pin configuration.
-      Client device subnodes use below standard properties.
-    $ref: "/schemas/pinctrl/pincfg-node.yaml"
-
-    properties:
-      pins:
-        description:
-          List of gpio pins affected by the properties specified in this
-          subnode.
-        items:
-          oneOf:
-            - pattern: "^gpio([0-9]|[1-9][0-9])$"
-        minItems: 1
-        maxItems: 14
-
-      function:
-        enum: [ gpio, swr_tx_clk, qua_mi2s_sclk, swr_tx_data, qua_mi2s_ws,
-                qua_mi2s_data, swr_rx_clk, swr_rx_data, dmic1_clk, i2s1_clk,
-                dmic1_data, i2s1_ws, dmic2_clk, dmic2_data, i2s1_data,
-                i2s2_clk, wsa_swr_clk, i2s2_ws, wsa_swr_data, dmic3_clk,
-                dmic3_data, i2s2_data ]
-        description:
-          Specify the alternative function to be configured for the specified
-          pins.
-
-      drive-strength:
-        enum: [2, 4, 6, 8, 10, 12, 14, 16]
-        default: 2
-        description:
-          Selects the drive strength for the specified pins, in mA.
-
-      slew-rate:
-        enum: [0, 1, 2, 3]
-        default: 0
-        description: |
-            0: No adjustments
-            1: Higher Slew rate (faster edges)
-            2: Lower Slew rate (slower edges)
-            3: Reserved (No adjustments)
-
-      bias-pull-down: true
-
-      bias-pull-up: true
-
-      bias-disable: true
-
-      output-high: true
-
-      output-low: true
-
-    required:
-      - pins
-      - function
-
-    additionalProperties: false
-
-required:
-  - compatible
-  - reg
-  - clocks
-  - clock-names
-  - gpio-controller
-  - '#gpio-cells'
-  - gpio-ranges
-
-additionalProperties: false
-
-examples:
-  - |
-    #include <dt-bindings/sound/qcom,q6afe.h>
-    lpi_tlmm: pinctrl@33c0000 {
-        compatible = "qcom,sm8250-lpass-lpi-pinctrl";
-        reg = <0x33c0000 0x20000>,
-              <0x3550000 0x10000>;
-        clocks = <&q6afecc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
-                 <&q6afecc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
-        clock-names = "core", "audio";
-        gpio-controller;
-        #gpio-cells = <2>;
-        gpio-ranges = <&lpi_tlmm 0 0 14>;
-    };
Documentation/devicetree/bindings/pinctrl/qcom,sm8250-lpass-lpi-pinctrl.yaml new file +130 -0

130 lines not on this page · raw message

Signature · 2 lines
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
maintainer
#2 lore raw

Re: [PATCH v3 1/5] dt-bindings: pinctrl: qcom: Update lpass lpi file name to SoC specific

Quoted 6 lines · Srinivasa Rao Mandadapu

Change generic lpass lpi pincotrol bindings file to SoC specific file, to distinguish and accomadate other SoC specific dt bindings.

Quoted 7 lines
---
 .../bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml   | 130 ---------------------
 .../pinctrl/qcom,sm8250-lpass-lpi-pinctrl.yaml     | 130 +++++++++++++++++++++
 2 files changed, 130 insertions(+), 130 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml
 create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sm8250-lpass-lpi-pinctrl.yaml

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
./Documentation/devicetree/bindings/pinctrl/qcom,sm8250-lpass-lpi-pinctrl.yaml: $id: relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/pinctrl/qcom,sm8250-lpass-lpi-pinctrl.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1561071

This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:

pip3 install dtschema --upgrade

Please check and re-submit.

#3 lore raw

Re: [PATCH v3 1/5] dt-bindings: pinctrl: qcom: Update lpass lpi file name to SoC specific

In reply to Srinivasa Rao Mandadapu
Quoted 2 lines · Srinivasa Rao Mandadapu

Change generic lpass lpi pincotrol bindings file to SoC specific file, to distinguish and accomadate other SoC specific dt bindings.

TBH, for adding sc7820 lpass lpi support, this rename patch is totally not necessary.

Quoted 7 lines
---
  .../bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml   | 130 ---------------------
  .../pinctrl/qcom,sm8250-lpass-lpi-pinctrl.yaml     | 130 +++++++++++++++++++++

Consider using "git mv" when renaming files, this would give a better diff stat.

--srini

Quoted 277 lines
  2 files changed, 130 insertions(+), 130 deletions(-)

delete mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sm8250-lpass-lpi-pinctrl.yaml

Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml deleted +0 -130
deleted file mode 100644
index e47ebf9..0000000
@@ -1,130 +0,0 @@
-# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
-%YAML 1.2
----
-$id: http://devicetree.org/schemas/pinctrl/qcom,lpass-lpi-pinctrl.yaml#
-$schema: http://devicetree.org/meta-schemas/core.yaml#
-
-title: Qualcomm Technologies, Inc. Low Power Audio SubSystem (LPASS)
-  Low Power Island (LPI) TLMM block
-
-maintainers:
-  - Srinivas Kandagatla <[email protected]>
-
-description: |
-  This binding describes the Top Level Mode Multiplexer block found in the
-  LPASS LPI IP on most Qualcomm SoCs
-
-properties:
-  compatible:
-    const: qcom,sm8250-lpass-lpi-pinctrl
-
-  reg:
-    minItems: 2
-    maxItems: 2
-
-  clocks:
-    items:
-      - description: LPASS Core voting clock
-      - description: LPASS Audio voting clock
-
-  clock-names:
-    items:
-      - const: core
-      - const: audio
-
-  gpio-controller: true
-
-  '#gpio-cells':
-    description: Specifying the pin number and flags, as defined in
-      include/dt-bindings/gpio/gpio.h
-    const: 2
-
-  gpio-ranges:
-    maxItems: 1
-
-#PIN CONFIGURATION NODES
-patternProperties:
-  '-pins$':
-    type: object
-    description:
-      Pinctrl node's client devices use subnodes for desired pin configuration.
-      Client device subnodes use below standard properties.
-    $ref: "/schemas/pinctrl/pincfg-node.yaml"
-
-    properties:
-      pins:
-        description:
-          List of gpio pins affected by the properties specified in this
-          subnode.
-        items:
-          oneOf:
-            - pattern: "^gpio([0-9]|[1-9][0-9])$"
-        minItems: 1
-        maxItems: 14
-
-      function:
-        enum: [ gpio, swr_tx_clk, qua_mi2s_sclk, swr_tx_data, qua_mi2s_ws,
-                qua_mi2s_data, swr_rx_clk, swr_rx_data, dmic1_clk, i2s1_clk,
-                dmic1_data, i2s1_ws, dmic2_clk, dmic2_data, i2s1_data,
-                i2s2_clk, wsa_swr_clk, i2s2_ws, wsa_swr_data, dmic3_clk,
-                dmic3_data, i2s2_data ]
-        description:
-          Specify the alternative function to be configured for the specified
-          pins.
-
-      drive-strength:
-        enum: [2, 4, 6, 8, 10, 12, 14, 16]
-        default: 2
-        description:
-          Selects the drive strength for the specified pins, in mA.
-
-      slew-rate:
-        enum: [0, 1, 2, 3]
-        default: 0
-        description: |
-            0: No adjustments
-            1: Higher Slew rate (faster edges)
-            2: Lower Slew rate (slower edges)
-            3: Reserved (No adjustments)
-
-      bias-pull-down: true
-
-      bias-pull-up: true
-
-      bias-disable: true
-
-      output-high: true
-
-      output-low: true
-
-    required:
-      - pins
-      - function
-
-    additionalProperties: false
-
-required:
-  - compatible
-  - reg
-  - clocks
-  - clock-names
-  - gpio-controller
-  - '#gpio-cells'
-  - gpio-ranges
-
-additionalProperties: false
-
-examples:
-  - |
-    #include <dt-bindings/sound/qcom,q6afe.h>
-    lpi_tlmm: pinctrl@33c0000 {
-        compatible = "qcom,sm8250-lpass-lpi-pinctrl";
-        reg = <0x33c0000 0x20000>,
-              <0x3550000 0x10000>;
-        clocks = <&q6afecc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
-                 <&q6afecc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
-        clock-names = "core", "audio";
-        gpio-controller;
-        #gpio-cells = <2>;
-        gpio-ranges = <&lpi_tlmm 0 0 14>;
-    };
Documentation/devicetree/bindings/pinctrl/qcom,sm8250-lpass-lpi-pinctrl.yaml new file +130 -0
new file mode 100644
index 0000000..e47ebf9
@@ -0,0 +1,130 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pinctrl/qcom,lpass-lpi-pinctrl.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Technologies, Inc. Low Power Audio SubSystem (LPASS)
+  Low Power Island (LPI) TLMM block
+
+maintainers:
+  - Srinivas Kandagatla <[email protected]>
+
+description: |
+  This binding describes the Top Level Mode Multiplexer block found in the
+  LPASS LPI IP on most Qualcomm SoCs
+
+properties:
+  compatible:
+    const: qcom,sm8250-lpass-lpi-pinctrl
+
+  reg:
+    minItems: 2
+    maxItems: 2
+
+  clocks:
+    items:
+      - description: LPASS Core voting clock
+      - description: LPASS Audio voting clock
+
+  clock-names:
+    items:
+      - const: core
+      - const: audio
+
+  gpio-controller: true
+
+  '#gpio-cells':
+    description: Specifying the pin number and flags, as defined in
+      include/dt-bindings/gpio/gpio.h
+    const: 2
+
+  gpio-ranges:
+    maxItems: 1
+
+#PIN CONFIGURATION NODES
+patternProperties:
+  '-pins$':
+    type: object
+    description:
+      Pinctrl node's client devices use subnodes for desired pin configuration.
+      Client device subnodes use below standard properties.
+    $ref: "/schemas/pinctrl/pincfg-node.yaml"
+
+    properties:
+      pins:
+        description:
+          List of gpio pins affected by the properties specified in this
+          subnode.
+        items:
+          oneOf:
+            - pattern: "^gpio([0-9]|[1-9][0-9])$"
+        minItems: 1
+        maxItems: 14
+
+      function:
+        enum: [ gpio, swr_tx_clk, qua_mi2s_sclk, swr_tx_data, qua_mi2s_ws,
+                qua_mi2s_data, swr_rx_clk, swr_rx_data, dmic1_clk, i2s1_clk,
+                dmic1_data, i2s1_ws, dmic2_clk, dmic2_data, i2s1_data,
+                i2s2_clk, wsa_swr_clk, i2s2_ws, wsa_swr_data, dmic3_clk,
+                dmic3_data, i2s2_data ]
+        description:
+          Specify the alternative function to be configured for the specified
+          pins.
+
+      drive-strength:
+        enum: [2, 4, 6, 8, 10, 12, 14, 16]
+        default: 2
+        description:
+          Selects the drive strength for the specified pins, in mA.
+
+      slew-rate:
+        enum: [0, 1, 2, 3]
+        default: 0
+        description: |
+            0: No adjustments
+            1: Higher Slew rate (faster edges)
+            2: Lower Slew rate (slower edges)
+            3: Reserved (No adjustments)
+
+      bias-pull-down: true
+
+      bias-pull-up: true
+
+      bias-disable: true
+
+      output-high: true
+
+      output-low: true
+
+    required:
+      - pins
+      - function
+
+    additionalProperties: false
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - clock-names
+  - gpio-controller
+  - '#gpio-cells'
+  - gpio-ranges
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/sound/qcom,q6afe.h>
+    lpi_tlmm: pinctrl@33c0000 {
+        compatible = "qcom,sm8250-lpass-lpi-pinctrl";
+        reg = <0x33c0000 0x20000>,
+              <0x3550000 0x10000>;
+        clocks = <&q6afecc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
+                 <&q6afecc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>;
+        clock-names = "core", "audio";
+        gpio-controller;
+        #gpio-cells = <2>;
+        gpio-ranges = <&lpi_tlmm 0 0 14>;
+    };
#4 lore raw

PATCH v3 2/5 dt-bindings: pinctrl: qcom: Add sc7280 lpass lpi pinctrl bindings

In reply to Srinivasa Rao Mandadapu

Add device tree binding Documentation details for Qualcomm SC7280 LPASS LPI pinctrl driver.

---
 .../pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml     | 115 +++++++++++++++++++++
 1 file changed, 115 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml
Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml new file +115 -0
new file mode 100644
index 0000000..62babb8
@@ -0,0 +1,115 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pinctrl/qcom,lpass-lpi-pinctrl.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Technologies, Inc. Low Power Audio SubSystem (LPASS)
+  Low Power Island (LPI) TLMM block
+
+maintainers:
+  - Srinivasa Rao Mandadapu <[email protected]>
+  - Srinivas Kandagatla <[email protected]>
+
+description: |
+  This binding describes the Top Level Mode Multiplexer block found in the
+  LPASS LPI IP on most Qualcomm SoCs
+
+properties:
+  compatible:
+    const: qcom,sc7280-lpass-lpi-pinctrl
+
+  reg:
+    minItems: 2
+    maxItems: 2
+
+  gpio-controller: true
+
+  '#gpio-cells':
+    description: Specifying the pin number and flags, as defined in
+      include/dt-bindings/gpio/gpio.h
+    const: 2
+
+  gpio-ranges:
+    maxItems: 1
+
+#PIN CONFIGURATION NODES
+patternProperties:
+  '-pins$':
+    type: object
+    description:
+      Pinctrl node's client devices use subnodes for desired pin configuration.
+      Client device subnodes use below standard properties.
+    $ref: "/schemas/pinctrl/pincfg-node.yaml"
+
+    properties:
+      pins:
+        description:
+          List of gpio pins affected by the properties specified in this
+          subnode.
+        items:
+          oneOf:
+            - pattern: "^gpio([0-9]|[1-9][0-9])$"
+        minItems: 1
+        maxItems: 15
+
+      function:
+        enum: [ gpio, swr_tx_clk, qua_mi2s_sclk, swr_tx_data, qua_mi2s_ws,
+                qua_mi2s_data, swr_rx_clk, swr_rx_data, dmic1_clk, i2s1_clk,
+                dmic1_data, i2s1_ws, dmic2_clk, dmic2_data, i2s1_data,
+                i2s2_clk, wsa_swr_clk, i2s2_ws, wsa_swr_data, dmic3_clk,
+                dmic3_data, i2s2_data ]
+        description:
+          Specify the alternative function to be configured for the specified
+          pins.
+
+      drive-strength:
+        enum: [2, 4, 6, 8, 10, 12, 14, 16]
+        default: 2
+        description:
+          Selects the drive strength for the specified pins, in mA.
+
+      slew-rate:
+        enum: [0, 1, 2, 3]
+        default: 0
+        description: |
+            0: No adjustments
+            1: Higher Slew rate (faster edges)
+            2: Lower Slew rate (slower edges)
+            3: Reserved (No adjustments)
+
+      bias-pull-down: true
+
+      bias-pull-up: true
+
+      bias-disable: true
+
+      output-high: true
+
+      output-low: true
+
+    required:
+      - pins
+      - function
+
+    additionalProperties: false
+
+required:
+  - compatible
+  - reg
+  - gpio-controller
+  - '#gpio-cells'
+  - gpio-ranges
+
+additionalProperties: false
+
+examples:
+  - |
+    lpass_tlmm: pinctrl@33c0000 {
+        compatible = "qcom,sc7280-lpass-lpi-pinctrl";
+        reg = <0x33c0000 0x20000>,
+              <0x3550000 0x10000>;
+        gpio-controller;
+        #gpio-cells = <2>;
+        gpio-ranges = <&lpass_tlmm 0 0 15>;
+    };
Signature · 2 lines
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
maintainer
#5 lore raw

Re: [PATCH v3 2/5] dt-bindings: pinctrl: qcom: Add sc7280 lpass lpi pinctrl bindings

Quoted 11 lines · Srinivasa Rao Mandadapu

Add device tree binding Documentation details for Qualcomm SC7280 LPASS LPI pinctrl driver.

---
 .../pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml     | 115 +++++++++++++++++++++
 1 file changed, 115 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
./Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml: $id: relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml: duplicate '$id' value 'http://devicetree.org/schemas/pinctrl/qcom,lpass-lpi-pinctrl.yaml#'

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1561073

This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:

pip3 install dtschema --upgrade

Please check and re-submit.

#6 lore raw

PATCH v3 3/5 pinctrl: qcom: Move chip specific functions to right files

In reply to Srinivasa Rao Mandadapu

Update lpass lpi pin control driver to accommodate new lpass variant SoC specific drivers.
Move sm8250 SoC specific functions to pinctrl-sm8250-lpass-lpi.c file and common declarations to pinctrl-lpass-lpi.h header file.

---
 drivers/pinctrl/qcom/Makefile                   |   1 +
 drivers/pinctrl/qcom/pinctrl-lpass-lpi.c        | 251 +-----------------------
 drivers/pinctrl/qcom/pinctrl-lpass-lpi.h        | 139 +++++++++++++
 drivers/pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c | 125 ++++++++++++
 4 files changed, 271 insertions(+), 245 deletions(-)
 create mode 100644 drivers/pinctrl/qcom/pinctrl-lpass-lpi.h
 create mode 100644 drivers/pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c
drivers/pinctrl/qcom/Makefile +1 -0
index 7a12e8c..74568cf 100644
@@ -37,3 +37,4 @@ obj-$(CONFIG_PINCTRL_SM8150) += pinctrl-sm8150.o
 obj-$(CONFIG_PINCTRL_SM8250) += pinctrl-sm8250.o
 obj-$(CONFIG_PINCTRL_SM8350) += pinctrl-sm8350.o
 obj-$(CONFIG_PINCTRL_LPASS_LPI) += pinctrl-lpass-lpi.o
+obj-$(CONFIG_PINCTRL_LPASS_LPI) += pinctrl-sm8250-lpass-lpi.o
drivers/pinctrl/qcom/pinctrl-lpass-lpi.c +6 -245

283 lines not on this page · raw message

drivers/pinctrl/qcom/pinctrl-lpass-lpi.h new file +139 -0

139 lines not on this page · raw message

drivers/pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c new file +125 -0

125 lines not on this page · raw message

Signature · 2 lines
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
#7 lore raw

Re: [PATCH v3 3/5] pinctrl: qcom: Move chip specific functions to right files

Thank you for the patch! Yet something to improve:

Hi Srinivasa,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linusw-pinctrl/devel]
[also build test ERROR on v5.16-rc3 next-20211130]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Srinivasa-Rao-Mandadapu/Add-pin-control-support-for-lpass-sc7280/20211129-180254
base:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
config: arm-allmodconfig (https://download.01.org/0day-ci/archive/20211130/202111301848.t0EBmRw2-lkp(a)intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0

reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/08f308b432fbb4f1eb2c05d94058fd365d79627a
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Srinivasa-Rao-Mandadapu/Add-pin-control-support-for-lpass-sc7280/20211129-180254 git checkout 08f308b432fbb4f1eb2c05d94058fd365d79627a
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm SHELL=/bin/bash arch/arm/common/ drivers/pinctrl/qcom/

If you fix the issue, kindly add following tag as appropriate

All errors (new ones prefixed by >>):

drivers/pinctrl/qcom/pinctrl-lpass-lpi.c: In function 'lpi_gpio_set_mux':
drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:113:9: error: implicit declaration of function 'u32p_replace_bits' [-Werror=implicit-function-declaration]

     113 |         u32p_replace_bits(&val, i, LPI_GPIO_FUNCTION_MASK);
         |         ^~~~~~~~~~~~~~~~~
   drivers/pinctrl/qcom/pinctrl-lpass-lpi.c: In function 'lpi_config_get':
>> drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:138:16: error: implicit declaration of function 'FIELD_GET' [-Werror=implicit-function-declaration]
     138 |         pull = FIELD_GET(LPI_GPIO_PULL_MASK, ctl_reg);
         |                ^~~~~~~~~
   drivers/pinctrl/qcom/pinctrl-lpass-lpi.c: In function 'lpi_config_set':
   drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:244:23: error: implicit declaration of function 'u32_encode_bits' [-Werror=implicit-function-declaration]
     244 |                 val = u32_encode_bits(value ? 1 : 0, LPI_GPIO_VALUE_OUT_MASK);
         |                       ^~~~~~~~~~~~~~~
   In file included from drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:15:
   At top level:
   drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:133:27: warning: 'gpio13_pins' defined but not used [-Wunused-const-variable=]
     133 | static const unsigned int gpio13_pins[] = { 13 };
         |                           ^~~~~~~~~~~
   drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:132:27: warning: 'gpio12_pins' defined but not used [-Wunused-const-variable=]
     132 | static const unsigned int gpio12_pins[] = { 12 };
         |                           ^~~~~~~~~~~
   drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:131:27: warning: 'gpio11_pins' defined but not used [-Wunused-const-variable=]
     131 | static const unsigned int gpio11_pins[] = { 11 };
         |                           ^~~~~~~~~~~
   drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:130:27: warning: 'gpio10_pins' defined but not used [-Wunused-const-variable=]
     130 | static const unsigned int gpio10_pins[] = { 10 };
         |                           ^~~~~~~~~~~
   drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:129:27: warning: 'gpio9_pins' defined but not used [-Wunused-const-variable=]
     129 | static const unsigned int gpio9_pins[] = { 9 };
         |                           ^~~~~~~~~~
   drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:128:27: warning: 'gpio8_pins' defined but not used [-Wunused-const-variable=]
     128 | static const unsigned int gpio8_pins[] = { 8 };
         |                           ^~~~~~~~~~
   drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:127:27: warning: 'gpio7_pins' defined but not used [-Wunused-const-variable=]
     127 | static const unsigned int gpio7_pins[] = { 7 };
         |                           ^~~~~~~~~~
   drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:126:27: warning: 'gpio6_pins' defined but not used [-Wunused-const-variable=]
     126 | static const unsigned int gpio6_pins[] = { 6 };
         |                           ^~~~~~~~~~
   drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:125:27: warning: 'gpio5_pins' defined but not used [-Wunused-const-variable=]
     125 | static const unsigned int gpio5_pins[] = { 5 };
         |                           ^~~~~~~~~~
   drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:124:27: warning: 'gpio4_pins' defined but not used [-Wunused-const-variable=]
     124 | static const unsigned int gpio4_pins[] = { 4 };
         |                           ^~~~~~~~~~
   drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:123:27: warning: 'gpio3_pins' defined but not used [-Wunused-const-variable=]
     123 | static const unsigned int gpio3_pins[] = { 3 };
         |                           ^~~~~~~~~~
   drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:122:27: warning: 'gpio2_pins' defined but not used [-Wunused-const-variable=]
     122 | static const unsigned int gpio2_pins[] = { 2 };
         |                           ^~~~~~~~~~
   drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:121:27: warning: 'gpio1_pins' defined but not used [-Wunused-const-variable=]
     121 | static const unsigned int gpio1_pins[] = { 1 };
         |                           ^~~~~~~~~~
   drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:120:27: warning: 'gpio0_pins' defined but not used [-Wunused-const-variable=]
     120 | static const unsigned int gpio0_pins[] = { 0 };
         |                           ^~~~~~~~~~

cc1: some warnings being treated as errors

vim +/FIELD_GET +138 drivers/pinctrl/qcom/pinctrl-lpass-lpi.c

6e261d1090d6db Srinivas Kandagatla 2020-12-02  125  
6e261d1090d6db Srinivas Kandagatla 2020-12-02  126  static int lpi_config_get(struct pinctrl_dev *pctldev,
6e261d1090d6db Srinivas Kandagatla 2020-12-02  127  			  unsigned int pin, unsigned long *config)
6e261d1090d6db Srinivas Kandagatla 2020-12-02  128  {
6e261d1090d6db Srinivas Kandagatla 2020-12-02  129  	unsigned int param = pinconf_to_config_param(*config);
6e261d1090d6db Srinivas Kandagatla 2020-12-02  130  	struct lpi_pinctrl *state = dev_get_drvdata(pctldev->dev);
6e261d1090d6db Srinivas Kandagatla 2020-12-02  131  	unsigned int arg = 0;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  132  	int is_out;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  133  	int pull;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  134  	u32 ctl_reg;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  135  
6e261d1090d6db Srinivas Kandagatla 2020-12-02  136  	ctl_reg = lpi_gpio_read(state, pin, LPI_GPIO_CFG_REG);
6e261d1090d6db Srinivas Kandagatla 2020-12-02  137  	is_out = ctl_reg & LPI_GPIO_OE_MASK;
6e261d1090d6db Srinivas Kandagatla 2020-12-02 @138  	pull = FIELD_GET(LPI_GPIO_PULL_MASK, ctl_reg);
6e261d1090d6db Srinivas Kandagatla 2020-12-02  139  
6e261d1090d6db Srinivas Kandagatla 2020-12-02  140  	switch (param) {
6e261d1090d6db Srinivas Kandagatla 2020-12-02  141  	case PIN_CONFIG_BIAS_DISABLE:
6e261d1090d6db Srinivas Kandagatla 2020-12-02  142  		if (pull == LPI_GPIO_BIAS_DISABLE)
6e261d1090d6db Srinivas Kandagatla 2020-12-02  143  			arg = 1;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  144  		break;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  145  	case PIN_CONFIG_BIAS_PULL_DOWN:
6e261d1090d6db Srinivas Kandagatla 2020-12-02  146  		if (pull == LPI_GPIO_PULL_DOWN)
6e261d1090d6db Srinivas Kandagatla 2020-12-02  147  			arg = 1;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  148  		break;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  149  	case PIN_CONFIG_BIAS_BUS_HOLD:
6e261d1090d6db Srinivas Kandagatla 2020-12-02  150  		if (pull == LPI_GPIO_KEEPER)
6e261d1090d6db Srinivas Kandagatla 2020-12-02  151  			arg = 1;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  152  		break;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  153  	case PIN_CONFIG_BIAS_PULL_UP:
6e261d1090d6db Srinivas Kandagatla 2020-12-02  154  		if (pull == LPI_GPIO_PULL_UP)
6e261d1090d6db Srinivas Kandagatla 2020-12-02  155  			arg = 1;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  156  		break;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  157  	case PIN_CONFIG_INPUT_ENABLE:
6e261d1090d6db Srinivas Kandagatla 2020-12-02  158  	case PIN_CONFIG_OUTPUT:
6e261d1090d6db Srinivas Kandagatla 2020-12-02  159  		if (is_out)
6e261d1090d6db Srinivas Kandagatla 2020-12-02  160  			arg = 1;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  161  		break;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  162  	default:
6e261d1090d6db Srinivas Kandagatla 2020-12-02  163  		return -EINVAL;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  164  	}
6e261d1090d6db Srinivas Kandagatla 2020-12-02  165  
6e261d1090d6db Srinivas Kandagatla 2020-12-02  166  	*config = pinconf_to_config_packed(param, arg);
6e261d1090d6db Srinivas Kandagatla 2020-12-02  167  	return 0;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  168  }
6e261d1090d6db Srinivas Kandagatla 2020-12-02  169  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

#8 lore raw

Re: [PATCH v3 3/5] pinctrl: qcom: Move chip specific functions to right files

In reply to Srinivasa Rao Mandadapu
Thank you for the patch! Yet something to improve:

Hi Srinivasa,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linusw-pinctrl/devel]
[also build test ERROR on v5.16-rc3 next-20211130]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Srinivasa-Rao-Mandadapu/Add-pin-control-support-for-lpass-sc7280/20211129-180254
base:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
config: arm-allyesconfig (https://download.01.org/0day-ci/archive/20211201/202112010233.r9AHDSfL-lkp(a)intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0

reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/08f308b432fbb4f1eb2c05d94058fd365d79627a
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Srinivasa-Rao-Mandadapu/Add-pin-control-support-for-lpass-sc7280/20211129-180254 git checkout 08f308b432fbb4f1eb2c05d94058fd365d79627a
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate

All errors (new ones prefixed by >>):

drivers/pinctrl/qcom/pinctrl-lpass-lpi.c: In function 'lpi_gpio_set_mux':

>> drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:113:9: error: implicit declaration of function 'u32p_replace_bits' [-Werror=implicit-function-declaration]
     113 |         u32p_replace_bits(&val, i, LPI_GPIO_FUNCTION_MASK);
         |         ^~~~~~~~~~~~~~~~~
   drivers/pinctrl/qcom/pinctrl-lpass-lpi.c: In function 'lpi_config_get':
>> drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:138:16: error: implicit declaration of function 'FIELD_GET' [-Werror=implicit-function-declaration]
     138 |         pull = FIELD_GET(LPI_GPIO_PULL_MASK, ctl_reg);
         |                ^~~~~~~~~
   drivers/pinctrl/qcom/pinctrl-lpass-lpi.c: In function 'lpi_config_set':
>> drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:244:23: error: implicit declaration of function 'u32_encode_bits' [-Werror=implicit-function-declaration]
     244 |                 val = u32_encode_bits(value ? 1 : 0, LPI_GPIO_VALUE_OUT_MASK);
         |                       ^~~~~~~~~~~~~~~
   In file included from drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:15:
   At top level:
   drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:133:27: warning: 'gpio13_pins' defined but not used [-Wunused-const-variable=]
     133 | static const unsigned int gpio13_pins[] = { 13 };
         |                           ^~~~~~~~~~~
   drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:132:27: warning: 'gpio12_pins' defined but not used [-Wunused-const-variable=]
     132 | static const unsigned int gpio12_pins[] = { 12 };
         |                           ^~~~~~~~~~~
   drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:131:27: warning: 'gpio11_pins' defined but not used [-Wunused-const-variable=]
     131 | static const unsigned int gpio11_pins[] = { 11 };
         |                           ^~~~~~~~~~~
   drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:130:27: warning: 'gpio10_pins' defined but not used [-Wunused-const-variable=]
     130 | static const unsigned int gpio10_pins[] = { 10 };
         |                           ^~~~~~~~~~~
   drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:129:27: warning: 'gpio9_pins' defined but not used [-Wunused-const-variable=]
     129 | static const unsigned int gpio9_pins[] = { 9 };
         |                           ^~~~~~~~~~
   drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:128:27: warning: 'gpio8_pins' defined but not used [-Wunused-const-variable=]
     128 | static const unsigned int gpio8_pins[] = { 8 };
         |                           ^~~~~~~~~~
   drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:127:27: warning: 'gpio7_pins' defined but not used [-Wunused-const-variable=]
     127 | static const unsigned int gpio7_pins[] = { 7 };
         |                           ^~~~~~~~~~
   drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:126:27: warning: 'gpio6_pins' defined but not used [-Wunused-const-variable=]
     126 | static const unsigned int gpio6_pins[] = { 6 };
         |                           ^~~~~~~~~~
   drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:125:27: warning: 'gpio5_pins' defined but not used [-Wunused-const-variable=]
     125 | static const unsigned int gpio5_pins[] = { 5 };
         |                           ^~~~~~~~~~
   drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:124:27: warning: 'gpio4_pins' defined but not used [-Wunused-const-variable=]
     124 | static const unsigned int gpio4_pins[] = { 4 };
         |                           ^~~~~~~~~~
   drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:123:27: warning: 'gpio3_pins' defined but not used [-Wunused-const-variable=]
     123 | static const unsigned int gpio3_pins[] = { 3 };
         |                           ^~~~~~~~~~
   drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:122:27: warning: 'gpio2_pins' defined but not used [-Wunused-const-variable=]
     122 | static const unsigned int gpio2_pins[] = { 2 };
         |                           ^~~~~~~~~~
   drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:121:27: warning: 'gpio1_pins' defined but not used [-Wunused-const-variable=]
     121 | static const unsigned int gpio1_pins[] = { 1 };
         |                           ^~~~~~~~~~
   drivers/pinctrl/qcom/pinctrl-lpass-lpi.h:120:27: warning: 'gpio0_pins' defined but not used [-Wunused-const-variable=]
     120 | static const unsigned int gpio0_pins[] = { 0 };
         |                           ^~~~~~~~~~

cc1: some warnings being treated as errors

vim +/u32p_replace_bits +113 drivers/pinctrl/qcom/pinctrl-lpass-lpi.c

6e261d1090d6db Srinivas Kandagatla 2020-12-02   95  
6e261d1090d6db Srinivas Kandagatla 2020-12-02   96  static int lpi_gpio_set_mux(struct pinctrl_dev *pctldev, unsigned int function,
6e261d1090d6db Srinivas Kandagatla 2020-12-02   97  			    unsigned int group_num)
6e261d1090d6db Srinivas Kandagatla 2020-12-02   98  {
6e261d1090d6db Srinivas Kandagatla 2020-12-02   99  	struct lpi_pinctrl *pctrl = pinctrl_dev_get_drvdata(pctldev);
6e261d1090d6db Srinivas Kandagatla 2020-12-02  100  	const struct lpi_pingroup *g = &pctrl->data->groups[group_num];
6e261d1090d6db Srinivas Kandagatla 2020-12-02  101  	u32 val;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  102  	int i, pin = g->pin;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  103  
6e261d1090d6db Srinivas Kandagatla 2020-12-02  104  	for (i = 0; i < g->nfuncs; i++) {
6e261d1090d6db Srinivas Kandagatla 2020-12-02  105  		if (g->funcs[i] == function)
6e261d1090d6db Srinivas Kandagatla 2020-12-02  106  			break;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  107  	}
6e261d1090d6db Srinivas Kandagatla 2020-12-02  108  
6e261d1090d6db Srinivas Kandagatla 2020-12-02  109  	if (WARN_ON(i == g->nfuncs))
6e261d1090d6db Srinivas Kandagatla 2020-12-02  110  		return -EINVAL;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  111  
6e261d1090d6db Srinivas Kandagatla 2020-12-02  112  	val = lpi_gpio_read(pctrl, pin, LPI_GPIO_CFG_REG);
6e261d1090d6db Srinivas Kandagatla 2020-12-02 @113  	u32p_replace_bits(&val, i, LPI_GPIO_FUNCTION_MASK);
6e261d1090d6db Srinivas Kandagatla 2020-12-02  114  	lpi_gpio_write(pctrl, pin, LPI_GPIO_CFG_REG, val);
6e261d1090d6db Srinivas Kandagatla 2020-12-02  115  
6e261d1090d6db Srinivas Kandagatla 2020-12-02  116  	return 0;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  117  }
6e261d1090d6db Srinivas Kandagatla 2020-12-02  118  
6e261d1090d6db Srinivas Kandagatla 2020-12-02  119  static const struct pinmux_ops lpi_gpio_pinmux_ops = {
6e261d1090d6db Srinivas Kandagatla 2020-12-02  120  	.get_functions_count	= lpi_gpio_get_functions_count,
6e261d1090d6db Srinivas Kandagatla 2020-12-02  121  	.get_function_name	= lpi_gpio_get_function_name,
6e261d1090d6db Srinivas Kandagatla 2020-12-02  122  	.get_function_groups	= lpi_gpio_get_function_groups,
6e261d1090d6db Srinivas Kandagatla 2020-12-02  123  	.set_mux		= lpi_gpio_set_mux,
6e261d1090d6db Srinivas Kandagatla 2020-12-02  124  };
6e261d1090d6db Srinivas Kandagatla 2020-12-02  125  
6e261d1090d6db Srinivas Kandagatla 2020-12-02  126  static int lpi_config_get(struct pinctrl_dev *pctldev,
6e261d1090d6db Srinivas Kandagatla 2020-12-02  127  			  unsigned int pin, unsigned long *config)
6e261d1090d6db Srinivas Kandagatla 2020-12-02  128  {
6e261d1090d6db Srinivas Kandagatla 2020-12-02  129  	unsigned int param = pinconf_to_config_param(*config);
6e261d1090d6db Srinivas Kandagatla 2020-12-02  130  	struct lpi_pinctrl *state = dev_get_drvdata(pctldev->dev);
6e261d1090d6db Srinivas Kandagatla 2020-12-02  131  	unsigned int arg = 0;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  132  	int is_out;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  133  	int pull;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  134  	u32 ctl_reg;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  135  
6e261d1090d6db Srinivas Kandagatla 2020-12-02  136  	ctl_reg = lpi_gpio_read(state, pin, LPI_GPIO_CFG_REG);
6e261d1090d6db Srinivas Kandagatla 2020-12-02  137  	is_out = ctl_reg & LPI_GPIO_OE_MASK;
6e261d1090d6db Srinivas Kandagatla 2020-12-02 @138  	pull = FIELD_GET(LPI_GPIO_PULL_MASK, ctl_reg);
6e261d1090d6db Srinivas Kandagatla 2020-12-02  139  
6e261d1090d6db Srinivas Kandagatla 2020-12-02  140  	switch (param) {
6e261d1090d6db Srinivas Kandagatla 2020-12-02  141  	case PIN_CONFIG_BIAS_DISABLE:
6e261d1090d6db Srinivas Kandagatla 2020-12-02  142  		if (pull == LPI_GPIO_BIAS_DISABLE)
6e261d1090d6db Srinivas Kandagatla 2020-12-02  143  			arg = 1;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  144  		break;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  145  	case PIN_CONFIG_BIAS_PULL_DOWN:
6e261d1090d6db Srinivas Kandagatla 2020-12-02  146  		if (pull == LPI_GPIO_PULL_DOWN)
6e261d1090d6db Srinivas Kandagatla 2020-12-02  147  			arg = 1;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  148  		break;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  149  	case PIN_CONFIG_BIAS_BUS_HOLD:
6e261d1090d6db Srinivas Kandagatla 2020-12-02  150  		if (pull == LPI_GPIO_KEEPER)
6e261d1090d6db Srinivas Kandagatla 2020-12-02  151  			arg = 1;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  152  		break;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  153  	case PIN_CONFIG_BIAS_PULL_UP:
6e261d1090d6db Srinivas Kandagatla 2020-12-02  154  		if (pull == LPI_GPIO_PULL_UP)
6e261d1090d6db Srinivas Kandagatla 2020-12-02  155  			arg = 1;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  156  		break;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  157  	case PIN_CONFIG_INPUT_ENABLE:
6e261d1090d6db Srinivas Kandagatla 2020-12-02  158  	case PIN_CONFIG_OUTPUT:
6e261d1090d6db Srinivas Kandagatla 2020-12-02  159  		if (is_out)
6e261d1090d6db Srinivas Kandagatla 2020-12-02  160  			arg = 1;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  161  		break;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  162  	default:
6e261d1090d6db Srinivas Kandagatla 2020-12-02  163  		return -EINVAL;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  164  	}
6e261d1090d6db Srinivas Kandagatla 2020-12-02  165  
6e261d1090d6db Srinivas Kandagatla 2020-12-02  166  	*config = pinconf_to_config_packed(param, arg);
6e261d1090d6db Srinivas Kandagatla 2020-12-02  167  	return 0;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  168  }
6e261d1090d6db Srinivas Kandagatla 2020-12-02  169  
6e261d1090d6db Srinivas Kandagatla 2020-12-02  170  static int lpi_config_set(struct pinctrl_dev *pctldev, unsigned int group,
6e261d1090d6db Srinivas Kandagatla 2020-12-02  171  			  unsigned long *configs, unsigned int nconfs)
6e261d1090d6db Srinivas Kandagatla 2020-12-02  172  {
6e261d1090d6db Srinivas Kandagatla 2020-12-02  173  	struct lpi_pinctrl *pctrl = dev_get_drvdata(pctldev->dev);
2a9be38099e338 Jonathan Marek      2021-03-04  174  	unsigned int param, arg, pullup = LPI_GPIO_BIAS_DISABLE, strength = 2;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  175  	bool value, output_enabled = false;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  176  	const struct lpi_pingroup *g;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  177  	unsigned long sval;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  178  	int i, slew_offset;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  179  	u32 val;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  180  
6e261d1090d6db Srinivas Kandagatla 2020-12-02  181  	g = &pctrl->data->groups[group];
6e261d1090d6db Srinivas Kandagatla 2020-12-02  182  	for (i = 0; i < nconfs; i++) {
6e261d1090d6db Srinivas Kandagatla 2020-12-02  183  		param = pinconf_to_config_param(configs[i]);
6e261d1090d6db Srinivas Kandagatla 2020-12-02  184  		arg = pinconf_to_config_argument(configs[i]);
6e261d1090d6db Srinivas Kandagatla 2020-12-02  185  
6e261d1090d6db Srinivas Kandagatla 2020-12-02  186  		switch (param) {
6e261d1090d6db Srinivas Kandagatla 2020-12-02  187  		case PIN_CONFIG_BIAS_DISABLE:
6e261d1090d6db Srinivas Kandagatla 2020-12-02  188  			pullup = LPI_GPIO_BIAS_DISABLE;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  189  			break;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  190  		case PIN_CONFIG_BIAS_PULL_DOWN:
6e261d1090d6db Srinivas Kandagatla 2020-12-02  191  			pullup = LPI_GPIO_PULL_DOWN;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  192  			break;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  193  		case PIN_CONFIG_BIAS_BUS_HOLD:
6e261d1090d6db Srinivas Kandagatla 2020-12-02  194  			pullup = LPI_GPIO_KEEPER;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  195  			break;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  196  		case PIN_CONFIG_BIAS_PULL_UP:
6e261d1090d6db Srinivas Kandagatla 2020-12-02  197  			pullup = LPI_GPIO_PULL_UP;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  198  			break;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  199  		case PIN_CONFIG_INPUT_ENABLE:
6e261d1090d6db Srinivas Kandagatla 2020-12-02  200  			output_enabled = false;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  201  			break;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  202  		case PIN_CONFIG_OUTPUT:
6e261d1090d6db Srinivas Kandagatla 2020-12-02  203  			output_enabled = true;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  204  			value = arg;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  205  			break;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  206  		case PIN_CONFIG_DRIVE_STRENGTH:
6e261d1090d6db Srinivas Kandagatla 2020-12-02  207  			strength = arg;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  208  			break;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  209  		case PIN_CONFIG_SLEW_RATE:
6e261d1090d6db Srinivas Kandagatla 2020-12-02  210  			if (arg > LPI_SLEW_RATE_MAX) {
6e261d1090d6db Srinivas Kandagatla 2020-12-02  211  				dev_err(pctldev->dev, "invalid slew rate %u for pin: %d\n",
6e261d1090d6db Srinivas Kandagatla 2020-12-02  212  					arg, group);
6e261d1090d6db Srinivas Kandagatla 2020-12-02  213  				return -EINVAL;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  214  			}
6e261d1090d6db Srinivas Kandagatla 2020-12-02  215  
6e261d1090d6db Srinivas Kandagatla 2020-12-02  216  			slew_offset = g->slew_offset;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  217  			if (slew_offset == NO_SLEW)
6e261d1090d6db Srinivas Kandagatla 2020-12-02  218  				break;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  219  
6e261d1090d6db Srinivas Kandagatla 2020-12-02  220  			mutex_lock(&pctrl->slew_access_lock);
6e261d1090d6db Srinivas Kandagatla 2020-12-02  221  
6e261d1090d6db Srinivas Kandagatla 2020-12-02  222  			sval = ioread32(pctrl->slew_base + LPI_SLEW_RATE_CTL_REG);
6e261d1090d6db Srinivas Kandagatla 2020-12-02  223  			sval &= ~(LPI_SLEW_RATE_MASK << slew_offset);
6e261d1090d6db Srinivas Kandagatla 2020-12-02  224  			sval |= arg << slew_offset;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  225  			iowrite32(sval, pctrl->slew_base + LPI_SLEW_RATE_CTL_REG);
6e261d1090d6db Srinivas Kandagatla 2020-12-02  226  
6e261d1090d6db Srinivas Kandagatla 2020-12-02  227  			mutex_unlock(&pctrl->slew_access_lock);
6e261d1090d6db Srinivas Kandagatla 2020-12-02  228  			break;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  229  		default:
6e261d1090d6db Srinivas Kandagatla 2020-12-02  230  			return -EINVAL;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  231  		}
6e261d1090d6db Srinivas Kandagatla 2020-12-02  232  	}
6e261d1090d6db Srinivas Kandagatla 2020-12-02  233  
6e261d1090d6db Srinivas Kandagatla 2020-12-02  234  	val = lpi_gpio_read(pctrl, group, LPI_GPIO_CFG_REG);
6e261d1090d6db Srinivas Kandagatla 2020-12-02  235  
6e261d1090d6db Srinivas Kandagatla 2020-12-02  236  	u32p_replace_bits(&val, pullup, LPI_GPIO_PULL_MASK);
6e261d1090d6db Srinivas Kandagatla 2020-12-02  237  	u32p_replace_bits(&val, LPI_GPIO_DS_TO_VAL(strength),
6e261d1090d6db Srinivas Kandagatla 2020-12-02  238  			  LPI_GPIO_OUT_STRENGTH_MASK);
6e261d1090d6db Srinivas Kandagatla 2020-12-02  239  	u32p_replace_bits(&val, output_enabled, LPI_GPIO_OE_MASK);
6e261d1090d6db Srinivas Kandagatla 2020-12-02  240  
6e261d1090d6db Srinivas Kandagatla 2020-12-02  241  	lpi_gpio_write(pctrl, group, LPI_GPIO_CFG_REG, val);
6e261d1090d6db Srinivas Kandagatla 2020-12-02  242  
6e261d1090d6db Srinivas Kandagatla 2020-12-02  243  	if (output_enabled) {
6e261d1090d6db Srinivas Kandagatla 2020-12-02 @244  		val = u32_encode_bits(value ? 1 : 0, LPI_GPIO_VALUE_OUT_MASK);
6e261d1090d6db Srinivas Kandagatla 2020-12-02  245  		lpi_gpio_write(pctrl, group, LPI_GPIO_VALUE_REG, val);
6e261d1090d6db Srinivas Kandagatla 2020-12-02  246  	}
6e261d1090d6db Srinivas Kandagatla 2020-12-02  247  
6e261d1090d6db Srinivas Kandagatla 2020-12-02  248  	return 0;
6e261d1090d6db Srinivas Kandagatla 2020-12-02  249  }
6e261d1090d6db Srinivas Kandagatla 2020-12-02  250  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

#9 lore raw

Re: [PATCH v3 3/5] pinctrl: qcom: Move chip specific functions to right files

In reply to Srinivasa Rao Mandadapu
Quoted 22 lines · Srinivasa Rao Mandadapu

Update lpass lpi pin control driver to accommodate new lpass variant SoC specific drivers.
Move sm8250 SoC specific functions to pinctrl-sm8250-lpass-lpi.c file and common declarations to pinctrl-lpass-lpi.h header file.

---
  drivers/pinctrl/qcom/Makefile                   |   1 +
  drivers/pinctrl/qcom/pinctrl-lpass-lpi.c        | 251 +-----------------------
  drivers/pinctrl/qcom/pinctrl-lpass-lpi.h        | 139 +++++++++++++
  drivers/pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c | 125 ++++++++++++
  4 files changed, 271 insertions(+), 245 deletions(-)

create mode 100644 drivers/pinctrl/qcom/pinctrl-lpass-lpi.h create mode 100644 drivers/pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c

drivers/pinctrl/qcom/Makefile +0 -0
index 7a12e8c..74568cf 100644

drivers/pinctrl/qcom/Makefile obj-$(CONFIG_PINCTRL_SM8150) += pinctrl-sm8150.o · line 40

Quoted 4 lines
drivers/pinctrl/qcom/Makefile +1 -0
@@ -37,3 +37,4 @@ obj-$(CONFIG_PINCTRL_SM8150) += pinctrl-sm8150.o
  obj-$(CONFIG_PINCTRL_SM8250) += pinctrl-sm8250.o
  obj-$(CONFIG_PINCTRL_SM8350) += pinctrl-sm8350.o
  obj-$(CONFIG_PINCTRL_LPASS_LPI) += pinctrl-lpass-lpi.o
+obj-$(CONFIG_PINCTRL_LPASS_LPI) += pinctrl-sm8250-lpass-lpi.o

This is confusing, either we make new CONFIG_PINCTRL_SM8250_LPASS_LPI here and use it for pinctrl-sm8250-lpass-lpi.o

drivers/pinctrl/qcom/pinctrl-lpass-lpi.c line 8

Quoted 10 lines
drivers/pinctrl/qcom/pinctrl-lpass-lpi.c +0 -2
index 2f19ab4..2641489 100644
@@ -4,237 +4,16 @@
   * Copyright (c) 2020 Linaro Ltd.
   */
 
-#include <linux/bitops.h>
-#include <linux/bitfield.h>

Looks like some of these are removed without a reason.

Quoted 15 lines
drivers/pinctrl/qcom/pinctrl-lpass-lpi.c +1 -6
  #include <linux/clk.h>
  #include <linux/gpio/driver.h>
-#include <linux/io.h>
-#include <linux/module.h>
  #include <linux/of_device.h>
-#include <linux/of.h>
  #include <linux/pinctrl/pinconf-generic.h>
  #include <linux/pinctrl/pinconf.h>
  #include <linux/pinctrl/pinmux.h>
-#include <linux/platform_device.h>
-#include <linux/slab.h>
-#include <linux/types.h>
  #include "../core.h"
  #include "../pinctrl-utils.h"
+#include "pinctrl-lpass-lpi.h"

...

drivers/pinctrl/qcom/pinctrl-lpass-lpi.c static int lpi_pinctrl_remove(struct platform_device *pdev) · line 695

Quoted 4 lines
drivers/pinctrl/qcom/pinctrl-lpass-lpi.c +0 -4
-
-module_platform_driver(lpi_pinctrl_driver);
-MODULE_DESCRIPTION("QTI LPI GPIO pin control driver");
-MODULE_LICENSE("GPL");

if you build this as Modules your build would fail without MODULE_LICENSE().

Quoted 89 lines
drivers/pinctrl/qcom/pinctrl-lpass-lpi.h new file +83 -0
new file mode 100644
index 0000000..b0afb40
@@ -0,0 +1,139 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * Copyright (c) 2016-2019, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2020 Linaro Ltd.
+ */
+#ifndef __PINCTRL_LPASS_LPI_H__
+#define __PINCTRL_LPASS_LPI_H__
+
+#define LPI_SLEW_RATE_CTL_REG	0xa000
+#define LPI_TLMM_REG_OFFSET		0x1000
+#define LPI_SLEW_RATE_MAX		0x03
+#define LPI_SLEW_BITS_SIZE		0x02
+#define LPI_SLEW_RATE_MASK		GENMASK(1, 0)
+#define LPI_GPIO_CFG_REG		0x00
+#define LPI_GPIO_PULL_MASK		GENMASK(1, 0)
+#define LPI_GPIO_FUNCTION_MASK		GENMASK(5, 2)
+#define LPI_GPIO_OUT_STRENGTH_MASK	GENMASK(8, 6)
+#define LPI_GPIO_OE_MASK		BIT(9)
+#define LPI_GPIO_VALUE_REG		0x04
+#define LPI_GPIO_VALUE_IN_MASK		BIT(0)
+#define LPI_GPIO_VALUE_OUT_MASK		BIT(1)
+
+#define LPI_GPIO_BIAS_DISABLE		0x0
+#define LPI_GPIO_PULL_DOWN		0x1
+#define LPI_GPIO_KEEPER			0x2
+#define LPI_GPIO_PULL_UP		0x3
+#define LPI_GPIO_DS_TO_VAL(v)		(v / 2 - 1)
+#define NO_SLEW				-1
+
+#define LPI_FUNCTION(fname)			                \
+	[LPI_MUX_##fname] = {		                \
+		.name = #fname,				\
+		.groups = fname##_groups,               \
+		.ngroups = ARRAY_SIZE(fname##_groups),	\
+	}
+
+#define LPI_PINGROUP(id, soff, f1, f2, f3, f4)		\
+	{						\
+		.name = "gpio" #id,			\
+		.pins = gpio##id##_pins,		\
+		.pin = id,				\
+		.slew_offset = soff,			\
+		.npins = ARRAY_SIZE(gpio##id##_pins),	\
+		.funcs = (int[]){			\
+			LPI_MUX_gpio,			\
+			LPI_MUX_##f1,			\
+			LPI_MUX_##f2,			\
+			LPI_MUX_##f3,			\
+			LPI_MUX_##f4,			\
+		},					\
+		.nfuncs = 5,				\
+	}
+
+struct lpi_pingroup {
+	const char *name;
+	const unsigned int *pins;
+	unsigned int npins;
+	unsigned int pin;
+	/* Bit offset in slew register for SoundWire pins only */
+	int slew_offset;
+	unsigned int *funcs;
+	unsigned int nfuncs;
+};
+
+struct lpi_function {
+	const char *name;
+	const char * const *groups;
+	unsigned int ngroups;
+};
+
+struct lpi_pinctrl_variant_data {
+	const struct pinctrl_pin_desc *pins;
+	int npins;
+	const struct lpi_pingroup *groups;
+	int ngroups;
+	const struct lpi_function *functions;
+	int nfunctions;
+};
+
+#define MAX_LPI_NUM_CLKS	2
+
+struct lpi_pinctrl {
+	struct device *dev;

drivers/pinctrl/qcom/pinctrl-lpass-lpi.h line 93

Quoted 10 lines
drivers/pinctrl/qcom/pinctrl-lpass-lpi.h new file +10 -0
+	struct pinctrl_dev *ctrl;
+	struct gpio_chip chip;
+	struct pinctrl_desc desc;
+	char __iomem *tlmm_base;
+	char __iomem *slew_base;
+	struct clk_bulk_data clks[MAX_LPI_NUM_CLKS];
+	struct mutex slew_access_lock;
+	const struct lpi_pinctrl_variant_data *data;
+};
+

From here
<<<

Quoted 40 lines
drivers/pinctrl/qcom/pinctrl-lpass-lpi.h new file +40 -0
+enum lpass_lpi_functions {
+	LPI_MUX_dmic1_clk,
+	LPI_MUX_dmic1_data,
+	LPI_MUX_dmic2_clk,
+	LPI_MUX_dmic2_data,
+	LPI_MUX_dmic3_clk,
+	LPI_MUX_dmic3_data,
+	LPI_MUX_i2s1_clk,
+	LPI_MUX_i2s1_data,
+	LPI_MUX_i2s1_ws,
+	LPI_MUX_i2s2_clk,
+	LPI_MUX_i2s2_data,
+	LPI_MUX_i2s2_ws,
+	LPI_MUX_qua_mi2s_data,
+	LPI_MUX_qua_mi2s_sclk,
+	LPI_MUX_qua_mi2s_ws,
+	LPI_MUX_swr_rx_clk,
+	LPI_MUX_swr_rx_data,
+	LPI_MUX_swr_tx_clk,
+	LPI_MUX_swr_tx_data,
+	LPI_MUX_wsa_swr_clk,
+	LPI_MUX_wsa_swr_data,
+	LPI_MUX_gpio,
+	LPI_MUX__,
+};
+
+static const unsigned int gpio0_pins[] = { 0 };
+static const unsigned int gpio1_pins[] = { 1 };
+static const unsigned int gpio2_pins[] = { 2 };
+static const unsigned int gpio3_pins[] = { 3 };
+static const unsigned int gpio4_pins[] = { 4 };
+static const unsigned int gpio5_pins[] = { 5 };
+static const unsigned int gpio6_pins[] = { 6 };
+static const unsigned int gpio7_pins[] = { 7 };
+static const unsigned int gpio8_pins[] = { 8 };
+static const unsigned int gpio9_pins[] = { 9 };
+static const unsigned int gpio10_pins[] = { 10 };
+static const unsigned int gpio11_pins[] = { 11 };
+static const unsigned int gpio12_pins[] = { 12 };
+static const unsigned int gpio13_pins[] = { 13 };
Quoted 1 line
Quoted 1 line
Quoted 1 line

to here are specific to sm8250, so it should not be in header file to start with.

Quoted 14 lines
drivers/pinctrl/qcom/pinctrl-lpass-lpi.h new file +6 -0
+
+int lpi_pinctrl_probe(struct platform_device *pdev);
+int lpi_pinctrl_remove(struct platform_device *pdev);
+
+#endif /*__PINCTRL_LPASS_LPI_H__*/
+
drivers/pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c new file +2 -0
new file mode 100644
index 0000000..3eba8b3
@@ -0,0 +1,125 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*

...

drivers/pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c line 123

Quoted 12 lines
drivers/pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c new file +12 -0
+
+static struct platform_driver lpi_pinctrl_driver = {
+	.driver = {
+		   .name = "qcom-sm8250-lpass-lpi-pinctrl",
+		   .of_match_table = lpi_pinctrl_of_match,
+	},
+	.probe = lpi_pinctrl_probe,
+	.remove = lpi_pinctrl_remove,
+};
+
+module_platform_driver(lpi_pinctrl_driver);
+MODULE_DESCRIPTION("QTI LPI GPIO pin control driver");

may be :
"SM8250 LPI GPIO pin control driver"

--srini

Quoted 3 lines
drivers/pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c new file +2 -0
+MODULE_LICENSE("GPL");
+
#10 lore raw

Re: [PATCH v3 3/5] pinctrl: qcom: Move chip specific functions to right files

On 12/1/2021 4:11 PM, Srinivas Kandagatla wrote:
Thanks for your time Srini!!!

Quoted 20 lines · Srinivasa Rao Mandadapu
Quoted 18 lines

Update lpass lpi pin control driver to accommodate new lpass variant SoC specific drivers.
Move sm8250 SoC specific functions to pinctrl-sm8250-lpass-lpi.c file and common declarations to pinctrl-lpass-lpi.h header file.

---
  drivers/pinctrl/qcom/Makefile                   |   1 + drivers/pinctrl/qcom/pinctrl-lpass-lpi.c        | 251

+-----------------------
  drivers/pinctrl/qcom/pinctrl-lpass-lpi.h        | 139 +++++++++++++
  drivers/pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c | 125 ++++++++++++
  4 files changed, 271 insertions(+), 245 deletions(-)

  create mode 100644 drivers/pinctrl/qcom/pinctrl-lpass-lpi.h create mode 100644 drivers/pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c

Quoted 12 lines
Quoted 9 lines
drivers/pinctrl/qcom/Makefile +0 -0
index 7a12e8c..74568cf 100644
@@ -37,3 +37,4 @@ obj-$(CONFIG_PINCTRL_SM8150) += pinctrl-sm8150.o

  obj-$(CONFIG_PINCTRL_SM8250) += pinctrl-sm8250.o obj-$(CONFIG_PINCTRL_SM8350) += pinctrl-sm8350.o obj-$(CONFIG_PINCTRL_LPASS_LPI) += pinctrl-lpass-lpi.o +obj-$(CONFIG_PINCTRL_LPASS_LPI) += pinctrl-sm8250-lpass-lpi.o

This is confusing, either we make new CONFIG_PINCTRL_SM8250_LPASS_LPI here and use it for pinctrl-sm8250-lpass-lpi.o

Okay. Will add new config macro. Thought of changing it, but worried that existing platforms may get disturbed.

Quoted 13 lines
Quoted 10 lines
drivers/pinctrl/qcom/pinctrl-lpass-lpi.c +0 -0
index 2f19ab4..2641489 100644
@@ -4,237 +4,16 @@
    * Copyright (c) 2020 Linaro Ltd.
    */

  -#include <linux/bitops.h>
-#include <linux/bitfield.h>

Looks like some of these are removed without a reason.

Actually, as functions distributed to different files, moved few of them to corresponding files,

and observed few of them are not required. could you please suggest on this?

Quoted 20 lines
Quoted 16 lines

  #include <linux/clk.h>
  #include <linux/gpio/driver.h>

drivers/pinctrl/qcom/pinctrl-lpass-lpi.c +0 -2
-#include <linux/io.h>
-#include <linux/module.h>

  #include <linux/of_device.h>
-#include <linux/of.h>
  #include <linux/pinctrl/pinconf-generic.h>
  #include <linux/pinctrl/pinconf.h>
  #include <linux/pinctrl/pinmux.h>

drivers/pinctrl/qcom/pinctrl-lpass-lpi.c +0 -3
-#include <linux/platform_device.h>
-#include <linux/slab.h>
-#include <linux/types.h>

  #include "../core.h"
  #include "../pinctrl-utils.h"
+#include "pinctrl-lpass-lpi.h"

...

Quoted 6 lines

drivers/pinctrl/qcom/pinctrl-lpass-lpi.c static int lpi_pinctrl_remove(struct platform_device *pdev) · line 695

Quoted 4 lines
drivers/pinctrl/qcom/pinctrl-lpass-lpi.c +0 -4
-
-module_platform_driver(lpi_pinctrl_driver);
-MODULE_DESCRIPTION("QTI LPI GPIO pin control driver");
-MODULE_LICENSE("GPL");

if you build this as Modules your build would fail without MODULE_LICENSE().

Okay. Will change accordingly.

Quoted 146 lines
Quoted 91 lines
drivers/pinctrl/qcom/pinctrl-lpass-lpi.h new file +83 -0
new file mode 100644
index 0000000..b0afb40
@@ -0,0 +1,139 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * Copyright (c) 2016-2019, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2020 Linaro Ltd.
+ */
+#ifndef __PINCTRL_LPASS_LPI_H__
+#define __PINCTRL_LPASS_LPI_H__
+
+#define LPI_SLEW_RATE_CTL_REG    0xa000
+#define LPI_TLMM_REG_OFFSET        0x1000
+#define LPI_SLEW_RATE_MAX        0x03
+#define LPI_SLEW_BITS_SIZE        0x02
+#define LPI_SLEW_RATE_MASK        GENMASK(1, 0)
+#define LPI_GPIO_CFG_REG        0x00
+#define LPI_GPIO_PULL_MASK        GENMASK(1, 0)
+#define LPI_GPIO_FUNCTION_MASK        GENMASK(5, 2)
+#define LPI_GPIO_OUT_STRENGTH_MASK    GENMASK(8, 6)
+#define LPI_GPIO_OE_MASK        BIT(9)
+#define LPI_GPIO_VALUE_REG        0x04
+#define LPI_GPIO_VALUE_IN_MASK        BIT(0)
+#define LPI_GPIO_VALUE_OUT_MASK        BIT(1)
+
+#define LPI_GPIO_BIAS_DISABLE        0x0
+#define LPI_GPIO_PULL_DOWN        0x1
+#define LPI_GPIO_KEEPER            0x2
+#define LPI_GPIO_PULL_UP        0x3
+#define LPI_GPIO_DS_TO_VAL(v)        (v / 2 - 1)
+#define NO_SLEW                -1
+
+#define LPI_FUNCTION(fname)                            \
+    [LPI_MUX_##fname] = {                        \
+        .name = #fname,                \
+        .groups = fname##_groups,               \
+        .ngroups = ARRAY_SIZE(fname##_groups),    \
+    }
+
+#define LPI_PINGROUP(id, soff, f1, f2, f3, f4)        \
+    {                        \
+        .name = "gpio" #id,            \
+        .pins = gpio##id##_pins,        \
+        .pin = id,                \
+        .slew_offset = soff,            \
+        .npins = ARRAY_SIZE(gpio##id##_pins),    \
+        .funcs = (int[]){            \
+            LPI_MUX_gpio,            \
+            LPI_MUX_##f1,            \
+            LPI_MUX_##f2,            \
+            LPI_MUX_##f3,            \
+            LPI_MUX_##f4,            \
+        },                    \
+        .nfuncs = 5,                \
+    }
+
+struct lpi_pingroup {
+    const char *name;
+    const unsigned int *pins;
+    unsigned int npins;
+    unsigned int pin;
+    /* Bit offset in slew register for SoundWire pins only */
+    int slew_offset;
+    unsigned int *funcs;
+    unsigned int nfuncs;
+};
+
+struct lpi_function {
+    const char *name;
+    const char * const *groups;
+    unsigned int ngroups;
+};
+
+struct lpi_pinctrl_variant_data {
+    const struct pinctrl_pin_desc *pins;
+    int npins;
+    const struct lpi_pingroup *groups;
+    int ngroups;
+    const struct lpi_function *functions;
+    int nfunctions;
+};
+
+#define MAX_LPI_NUM_CLKS    2
+
+struct lpi_pinctrl {
+    struct device *dev;

drivers/pinctrl/qcom/pinctrl-lpass-lpi.h line 93

Quoted 10 lines
drivers/pinctrl/qcom/pinctrl-lpass-lpi.h new file +10 -0
+    struct pinctrl_dev *ctrl;
+    struct gpio_chip chip;
+    struct pinctrl_desc desc;
+    char __iomem *tlmm_base;
+    char __iomem *slew_base;
+    struct clk_bulk_data clks[MAX_LPI_NUM_CLKS];
+    struct mutex slew_access_lock;
+    const struct lpi_pinctrl_variant_data *data;
+};
+

From here
<<<

Quoted 40 lines
drivers/pinctrl/qcom/pinctrl-lpass-lpi.h new file +40 -0
+enum lpass_lpi_functions {
+    LPI_MUX_dmic1_clk,
+    LPI_MUX_dmic1_data,
+    LPI_MUX_dmic2_clk,
+    LPI_MUX_dmic2_data,
+    LPI_MUX_dmic3_clk,
+    LPI_MUX_dmic3_data,
+    LPI_MUX_i2s1_clk,
+    LPI_MUX_i2s1_data,
+    LPI_MUX_i2s1_ws,
+    LPI_MUX_i2s2_clk,
+    LPI_MUX_i2s2_data,
+    LPI_MUX_i2s2_ws,
+    LPI_MUX_qua_mi2s_data,
+    LPI_MUX_qua_mi2s_sclk,
+    LPI_MUX_qua_mi2s_ws,
+    LPI_MUX_swr_rx_clk,
+    LPI_MUX_swr_rx_data,
+    LPI_MUX_swr_tx_clk,
+    LPI_MUX_swr_tx_data,
+    LPI_MUX_wsa_swr_clk,
+    LPI_MUX_wsa_swr_data,
+    LPI_MUX_gpio,
+    LPI_MUX__,
+};
+
+static const unsigned int gpio0_pins[] = { 0 };
+static const unsigned int gpio1_pins[] = { 1 };
+static const unsigned int gpio2_pins[] = { 2 };
+static const unsigned int gpio3_pins[] = { 3 };
+static const unsigned int gpio4_pins[] = { 4 };
+static const unsigned int gpio5_pins[] = { 5 };
+static const unsigned int gpio6_pins[] = { 6 };
+static const unsigned int gpio7_pins[] = { 7 };
+static const unsigned int gpio8_pins[] = { 8 };
+static const unsigned int gpio9_pins[] = { 9 };
+static const unsigned int gpio10_pins[] = { 10 };
+static const unsigned int gpio11_pins[] = { 11 };
+static const unsigned int gpio12_pins[] = { 12 };
+static const unsigned int gpio13_pins[] = { 13 };
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

to here are specific to sm8250, so it should not be in header file to start with.

As these are common to all lpass variants.. I feel it's better to keep in Header file.

And if new pins comes in later variants, we can add them incrementally, and they will not impact existing pin numbers.

I think in upcoming variants number of pins will not decrease.

Quoted 19 lines
Quoted 16 lines
drivers/pinctrl/qcom/pinctrl-lpass-lpi.h new file +6 -0
+
+int lpi_pinctrl_probe(struct platform_device *pdev);
+int lpi_pinctrl_remove(struct platform_device *pdev);
+
+#endif /*__PINCTRL_LPASS_LPI_H__*/
+
drivers/pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c new file +2 -0
new file mode 100644
index 0000000..3eba8b3
@@ -0,0 +1,125 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*

...

Quoted 15 lines

drivers/pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c line 123

Quoted 12 lines
drivers/pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c new file +12 -0
+
+static struct platform_driver lpi_pinctrl_driver = {
+    .driver = {
+           .name = "qcom-sm8250-lpass-lpi-pinctrl",
+           .of_match_table = lpi_pinctrl_of_match,
+    },
+    .probe = lpi_pinctrl_probe,
+    .remove = lpi_pinctrl_remove,
+};
+
+module_platform_driver(lpi_pinctrl_driver);
+MODULE_DESCRIPTION("QTI LPI GPIO pin control driver");

may be :
"SM8250 LPI GPIO pin control driver"

Okay.. will change accordingly.

Quoted 5 lines

--srini

Quoted 3 lines
drivers/pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c new file +2 -0
+MODULE_LICENSE("GPL");
+
Signature · 2 lines
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
#11 lore raw

Re: [PATCH v3 3/5] pinctrl: qcom: Move chip specific functions to right files

Quoted 43 lines · Srinivasa Rao Mandadapu
Quoted 43 lines
Quoted 43 lines
drivers/pinctrl/qcom/pinctrl-lpass-lpi.h new file +40 -0
+enum lpass_lpi_functions {
+    LPI_MUX_dmic1_clk,
+    LPI_MUX_dmic1_data,
+    LPI_MUX_dmic2_clk,
+    LPI_MUX_dmic2_data,
+    LPI_MUX_dmic3_clk,
+    LPI_MUX_dmic3_data,
+    LPI_MUX_i2s1_clk,
+    LPI_MUX_i2s1_data,
+    LPI_MUX_i2s1_ws,
+    LPI_MUX_i2s2_clk,
+    LPI_MUX_i2s2_data,
+    LPI_MUX_i2s2_ws,
+    LPI_MUX_qua_mi2s_data,
+    LPI_MUX_qua_mi2s_sclk,
+    LPI_MUX_qua_mi2s_ws,
+    LPI_MUX_swr_rx_clk,
+    LPI_MUX_swr_rx_data,
+    LPI_MUX_swr_tx_clk,
+    LPI_MUX_swr_tx_data,
+    LPI_MUX_wsa_swr_clk,
+    LPI_MUX_wsa_swr_data,
+    LPI_MUX_gpio,
+    LPI_MUX__,
+};
+
+static const unsigned int gpio0_pins[] = { 0 };
+static const unsigned int gpio1_pins[] = { 1 };
+static const unsigned int gpio2_pins[] = { 2 };
+static const unsigned int gpio3_pins[] = { 3 };
+static const unsigned int gpio4_pins[] = { 4 };
+static const unsigned int gpio5_pins[] = { 5 };
+static const unsigned int gpio6_pins[] = { 6 };
+static const unsigned int gpio7_pins[] = { 7 };
+static const unsigned int gpio8_pins[] = { 8 };
+static const unsigned int gpio9_pins[] = { 9 };
+static const unsigned int gpio10_pins[] = { 10 };
+static const unsigned int gpio11_pins[] = { 11 };
+static const unsigned int gpio12_pins[] = { 12 };
+static const unsigned int gpio13_pins[] = { 13 };
Quoted 1 line
Quoted 1 line
Quoted 3 lines
Quoted 1 line

to here are specific to sm8250, so it should not be in header file to start with.

As these are common to all lpass variants.. I feel it's better to keep in Header file.

You realize that every include of this file will add these static variables to file, in this case to pinctrl-lpass-lpi.c, pinctrl-sm8250-lpass-lpi.c and pinctrl-sc7280-lpass-lpi.c so in first file(pinctrl-lpass-lpi.c) you never use those variables in second file (pinctrl-sm8250-lpass-lpi.c)you only use up to gpio13 and in third file pinctrl-sc7280-lpass-lpi.c you could use them.

so its really bad idea to add static variables in header files.

--srini

Quoted 5 lines

And if new pins comes in later variants, we can add them incrementally, and they will not impact existing pin numbers.

I think in upcoming variants number of pins will not decrease.

#12 lore raw

Re: [PATCH v3 3/5] pinctrl: qcom: Move chip specific functions to right files

On 12/1/2021 8:37 PM, Srinivas Kandagatla wrote:
Thanks for clarification Srini!!

Quoted 45 lines · Srinivasa Rao Mandadapu
Quoted 43 lines
Quoted 43 lines
Quoted 43 lines
drivers/pinctrl/qcom/pinctrl-lpass-lpi.h new file +40 -0
+enum lpass_lpi_functions {
+    LPI_MUX_dmic1_clk,
+    LPI_MUX_dmic1_data,
+    LPI_MUX_dmic2_clk,
+    LPI_MUX_dmic2_data,
+    LPI_MUX_dmic3_clk,
+    LPI_MUX_dmic3_data,
+    LPI_MUX_i2s1_clk,
+    LPI_MUX_i2s1_data,
+    LPI_MUX_i2s1_ws,
+    LPI_MUX_i2s2_clk,
+    LPI_MUX_i2s2_data,
+    LPI_MUX_i2s2_ws,
+    LPI_MUX_qua_mi2s_data,
+    LPI_MUX_qua_mi2s_sclk,
+    LPI_MUX_qua_mi2s_ws,
+    LPI_MUX_swr_rx_clk,
+    LPI_MUX_swr_rx_data,
+    LPI_MUX_swr_tx_clk,
+    LPI_MUX_swr_tx_data,
+    LPI_MUX_wsa_swr_clk,
+    LPI_MUX_wsa_swr_data,
+    LPI_MUX_gpio,
+    LPI_MUX__,
+};
+
+static const unsigned int gpio0_pins[] = { 0 };
+static const unsigned int gpio1_pins[] = { 1 };
+static const unsigned int gpio2_pins[] = { 2 };
+static const unsigned int gpio3_pins[] = { 3 };
+static const unsigned int gpio4_pins[] = { 4 };
+static const unsigned int gpio5_pins[] = { 5 };
+static const unsigned int gpio6_pins[] = { 6 };
+static const unsigned int gpio7_pins[] = { 7 };
+static const unsigned int gpio8_pins[] = { 8 };
+static const unsigned int gpio9_pins[] = { 9 };
+static const unsigned int gpio10_pins[] = { 10 };
+static const unsigned int gpio11_pins[] = { 11 };
+static const unsigned int gpio12_pins[] = { 12 };
+static const unsigned int gpio13_pins[] = { 13 };
Quoted 1 line
Quoted 1 line
Quoted 9 lines
Quoted 3 lines
Quoted 1 line

to here are specific to sm8250, so it should not be in header file to start with.

As these are common to all lpass variants.. I feel it's better to keep in Header file.

You realize that every include of this file will add these static variables to file, in this case to pinctrl-lpass-lpi.c, pinctrl-sm8250-lpass-lpi.c and pinctrl-sc7280-lpass-lpi.c so in first file(pinctrl-lpass-lpi.c) you never use those variables in second file (pinctrl-sm8250-lpass-lpi.c)you only use up to gpio13 and in third file pinctrl-sc7280-lpass-lpi.c you could use them.

so its really bad idea to add static variables in header files.

Okay. Understood. will move it SoC specific files.

Quoted 7 lines

--srini

Quoted 5 lines

And if new pins comes in later variants, we can add them incrementally, and they will not impact existing pin numbers.

I think in upcoming variants number of pins will not decrease.

Signature · 2 lines
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
#13 lore raw

PATCH v3 4/5 pinctrl: qcom: Update clock voting as optional

In reply to Srinivasa Rao Mandadapu

Update bulk clock voting to optional voting as ADSP bypass platform doesn't need macro and decodec clocks, these are maintained as power domains and operated from lpass audio core cc.

---
 drivers/pinctrl/qcom/pinctrl-lpass-lpi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/qcom/pinctrl-lpass-lpi.c +1 -1
index 2641489..d28135b 100644
@@ -394,7 +394,7 @@ int lpi_pinctrl_probe(struct platform_device *pdev)
 		return dev_err_probe(dev, PTR_ERR(pctrl->slew_base),
 				     "Slew resource not provided\n");
 
-	ret = devm_clk_bulk_get(dev, MAX_LPI_NUM_CLKS, pctrl->clks);
+	ret = devm_clk_bulk_get_optional(dev, MAX_LPI_NUM_CLKS, pctrl->clks);
 	if (ret)
 		return dev_err_probe(dev, ret, "Can't get clocks\n");
 
Signature · 2 lines
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
#14 lore raw

PATCH v3 5/5 pinctrl: qcom: Add SC7280 lpass pin configuration

In reply to Srinivasa Rao Mandadapu

Add pin control support for SC7280 LPASS LPI.

---
 drivers/pinctrl/qcom/Makefile                   |   1 +
 drivers/pinctrl/qcom/pinctrl-lpass-lpi.h        |   1 +
 drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c | 127 ++++++++++++++++++++++++
 3 files changed, 129 insertions(+)
 create mode 100644 drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c
drivers/pinctrl/qcom/Makefile +1 -0
index 74568cf..e07be79 100644
@@ -38,3 +38,4 @@ obj-$(CONFIG_PINCTRL_SM8250) += pinctrl-sm8250.o
 obj-$(CONFIG_PINCTRL_SM8350) += pinctrl-sm8350.o
 obj-$(CONFIG_PINCTRL_LPASS_LPI) += pinctrl-lpass-lpi.o
 obj-$(CONFIG_PINCTRL_LPASS_LPI) += pinctrl-sm8250-lpass-lpi.o
+obj-$(CONFIG_PINCTRL_LPASS_LPI) += pinctrl-sc7280-lpass-lpi.o
drivers/pinctrl/qcom/pinctrl-lpass-lpi.h +1 -0
index b0afb40..1b91585 100644
@@ -131,6 +131,7 @@ static const unsigned int gpio10_pins[] = { 10 };
 static const unsigned int gpio11_pins[] = { 11 };
 static const unsigned int gpio12_pins[] = { 12 };
 static const unsigned int gpio13_pins[] = { 13 };
+static const unsigned int gpio14_pins[] = { 14 };
 
 int lpi_pinctrl_probe(struct platform_device *pdev);
 int lpi_pinctrl_remove(struct platform_device *pdev);
drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c new file +127 -0

127 lines not on this page · raw message

Signature · 2 lines
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.