Skip to contentSkip to conversation

metadata/test: Remove bashism

PATCH In review Joerg Vehlow 2 participants 3 messages Dec 3, 2021 – Dec 8, 2021 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 metadata/test: Remove bashism

From: Joerg Vehlow <[email protected]>

---
 metadata/tests/test.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
metadata/tests/test.sh +1 -1
index c11f0e496..475d721df 100755
@@ -4,7 +4,7 @@ fail=0
 
 for i in *.c; do
 	../metaparse $i > tmp.json
-	if ! diff tmp.json $i.json &> /dev/null; then
+	if ! diff tmp.json $i.json >/dev/null 2>&1; then
 		echo "***"
 		echo "$i output differs!"
 		diff -u tmp.json $i.json
Signature · 5 lines
2.25.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw

PATCH 2/2 make: Build metaparse before running tests

From: Joerg Vehlow <[email protected]>

Running make test(-metadata) without make all did not build metaparse and so the metadata tests failed.

---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
index a94e0da9a..d4399bae6 100644
@@ -221,7 +221,7 @@ ifneq ($(build),$(host))
 endif
 	$(call _test,-s)
 
-test-metadata:
+test-metadata: metadata-all
 	$(MAKE) -C $(abs_srcdir)/metadata/ test
 
 ## Help
Signature · 5 lines
2.25.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#2 lore raw

Re: [LTP] [PATCH 2/2] make: Build metaparse before running tests

Hi!
Both patches pushed, thanks.

Signature · 5 lines
Cyril Hrubis
[email protected]

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp