drm: fsl-dcu: select CONFIG_DRM_GEM_CMA_HELPER
Subsystems (5)
PATCH 1/2 drm: fsl-dcu: select CONFIG_DRM_GEM_CMA_HELPER
From: Arnd Bergmann <[email protected]>
The fsl-dcu driver uses the gem_cma_helper code, but does noto enforce enabling this through Kconfig:
arm-linux-gnueabi-ld: drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.o:(.rodata+0x32c): undefined reference to `drm_gem_cma_prime_import_sg_table'
arm-linux-gnueabi-ld: drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.o:(.rodata+0x334): undefined reference to `drm_gem_cma_dumb_create'
arm-linux-gnueabi-ld: drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.o: in function `fsl_dcu_drm_plane_atomic_update':
fsl_dcu_drm_plane.c:(.text+0x144): undefined reference to `drm_fb_cma_get_gem_obj'
Add the same 'select' that is used in other such drivers.
--- drivers/gpu/drm/fsl-dcu/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/fsl-dcu/Kconfig +1 -0
@@ -3,6 +3,7 @@ config DRM_FSL_DCU tristate "DRM Support for Freescale DCU" depends on DRM && OF && ARM && COMMON_CLK select BACKLIGHT_CLASS_DEVICE + select DRM_GEM_CMA_HELPER select DRM_KMS_HELPER select DRM_PANEL select REGMAP_MMIO
Signature · 1 line
2.29.2
PATCH 2/2 drm: aspeed: select CONFIG_DRM_GEM_CMA_HELPER
From: Arnd Bergmann <[email protected]>
The aspeed driver uses the gem_cma_helper code, but does noto enforce enabling this through Kconfig:
x86_64-linux-ld: drivers/gpu/drm/aspeed/aspeed_gfx_drv.o:(.rodata+0x2c8): undefined reference to `drm_gem_cma_prime_import_sg_table'
x86_64-linux-ld: drivers/gpu/drm/aspeed/aspeed_gfx_drv.o:(.rodata+0x2d8): undefined reference to `drm_gem_cma_dumb_create'
x86_64-linux-ld: drivers/gpu/drm/aspeed/aspeed_gfx_crtc.o: in function `aspeed_gfx_pipe_update':
aspeed_gfx_crtc.c:(.text+0xe5): undefined reference to `drm_fb_cma_get_gem_obj'
Add the same 'select' that is used in other such drivers.
--- drivers/gpu/drm/aspeed/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/aspeed/Kconfig +1 -0
@@ -5,6 +5,7 @@ config DRM_ASPEED_GFX depends on (COMPILE_TEST || ARCH_ASPEED) depends on MMU select DRM_KMS_HELPER + select DRM_GEM_CMA_HELPER select DMA_CMA if HAVE_DMA_CONTIGUOUS select CMA if HAVE_DMA_CONTIGUOUS select MFD_SYSCON
Signature · 1 line
2.29.2
Thomas Zimmermann
maintainerRe: [PATCH 2/2] drm: aspeed: select CONFIG_DRM_GEM_CMA_HELPER
Hi Arnd
Am 04.12.21 um 18:46 schrieb Arnd Bergmann:
Quoted 10 lines
From: Arnd Bergmann <[email protected]>
The aspeed driver uses the
gem_cma_helpercode, but does noto enforce enabling this throughKconfig:x86_64-linux-ld: drivers/gpu/drm/aspeed/aspeed_gfx_drv.o:(.rodata+0x2c8): undefined reference to `drm_gem_cma_prime_import_sg_table'
x86_64-linux-ld: drivers/gpu/drm/aspeed/aspeed_gfx_drv.o:(.rodata+0x2d8): undefined reference to `drm_gem_cma_dumb_create'
x86_64-linux-ld:drivers/gpu/drm/aspeed/aspeed_gfx_crtc.o: in function `aspeed_gfx_pipe_update':
aspeed_gfx_crtc.c:(.text+0xe5): undefined reference to `drm_fb_cma_get_gem_obj'
Quoted 4 lines
Add the same 'select' that is used in other such drivers.
Fixes 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")Signed-off-by Arnd Bergmann <[email protected]>
Thanks! I've added both patches to drm-misc-next.
Best regards
Thomas
Signature · 13 lines
Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N?rnberg, Germany (HRB 36809, AG N?rnberg) Gesch?ftsf?hrer: Ivo Totev -------------- next part -------------- A non-text attachment was scrubbed... Name: OpenPGP_signature Type: application/pgp-signature Size: 840 bytes Desc: OpenPGP digital signature URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20211206/c06f158c/attachment.sig>