staging: rtl8712: Fix alignment checks
PATCH 1/1 staging: rtl8712: Fix alignment checks
Fixed two CHECKs of Alignment should match open parenthesis.
Signed-off-by Ngo Tak Fong <[email protected]>
--- drivers/staging/rtl8712/rtl8712_efuse.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-)
drivers/staging/rtl8712/rtl8712_efuse.c +6 -7
@@ -300,16 +300,15 @@ static u8 fix_header(struct _adapter *adapter, u8 header, u16 header_addr)for (i =0 ; i <PGPKG_MAX_WORDS ; i++) {if (BIT (i) & word_en) {if (BIT (i) & pkt.word_en) { -if (efuse_one_byte_read ( - adapter, addr, - &value)) +if (efuse_one_byte_read (adapter, + addr, + &value)) pkt.data[i *2 ] = value;else return false; -if (efuse_one_byte_read ( - adapter, - addr +1 , - &value)) +if (efuse_one_byte_read (adapter, + addr +1 , + &value)) pkt.data[i *2 +1 ] = value;else
Signature · 1 line
2.32.0
Quoted 12 lines · Ngo Tak Fong
Fixed two CHECKs of Alignment should match open parenthesis.
Signed-off-by Ngo Tak Fong <[email protected]>--- drivers/staging/rtl8712/rtl8712_efuse.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-)drivers/staging/rtl8712/rtl8712_efuse.c +0
-0
drivers/staging/rtl8712/rtl8712_efuse.c static u8 fix_header(struct _adapter *adapter, u8 header, u16 header_addr) · line 301
Quoted 2 lines
drivers/staging/rtl8712/rtl8712_efuse.c +0
-0@@ -300,16 +300,15 @@ static u8 fix_header(struct _adapter *adapter, u8 header, u16 header_addr)for (i =0 ; i <PGPKG_MAX_WORDS ; i++) {if (BIT (i) & word_en) {
The real problem is this code is jammed up against the right hand side of the screen. Just flip this condition around and pull the code in one tab.
if (!(BIT(i) & word_en) continue;
drivers/staging/rtl8712/rtl8712_efuse.c static u8 fix_header(struct _adapter *adapter, u8 header, u16 header_addr) · line 305
Quoted 7 lines
drivers/staging/rtl8712/rtl8712_efuse.c +3
-3if (BIT (i) & pkt.word_en) { -if (efuse_one_byte_read ( - adapter, addr, - &value)) +if (efuse_one_byte_read (adapter, + addr, + &value))
reards,
dan carpenter