Skip to contentSkip to conversation

dt-bindings: nvmem: Add missing 'reg' property

PATCH In review Rob Herring 4 participants 4 messages Dec 6, 2021 – Dec 9, 2021

Subsystems (3)
Device tree bindings Arm STM32 NVMEM framework
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: nvmem: Add missing 'reg' property

With 'unevaluatedProperties' support implemented, the following warnings are generated in the nvmem examples:

Documentation/devicetree/bindings/nvmem/st,stm32-romem.example.dt.yaml: efuse@1fff7800: Unevaluated properties are not allowed ('reg' was unexpected) Documentation/devicetree/bindings/nvmem/rmem.example.dt.yaml: nvram@10000000: Unevaluated properties are not allowed ('reg' was unexpected) Documentation/devicetree/bindings/nvmem/brcm,nvram.example.dt.yaml: nvram@1eff0000: Unevaluated properties are not allowed ('reg' was unexpected)

Add the missing 'reg' property definition.

Cc Srinivas Kandagatla <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Alexandre Torgue <[email protected]>
Cc Rafał Miłecki <[email protected]>
Cc Saenz Julienne <[email protected]>
Cc Fabrice Gasnier <[email protected]>
Cc [email protected]
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>
---
 Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml     | 3 +++
 Documentation/devicetree/bindings/nvmem/rmem.yaml           | 3 +++
 Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml | 3 +++
 3 files changed, 9 insertions(+)
Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml +3 -0
index 58ff6b0bdb1a..8c3f0cd22821 100644
@@ -24,6 +24,9 @@ properties:
   compatible:
     const: brcm,nvram
 
+  reg:
+    maxItems: 1
+
 unevaluatedProperties: false
 
 examples:
Documentation/devicetree/bindings/nvmem/rmem.yaml +3 -0
index 1d85a0a30846..a4a755dcfc43 100644
@@ -19,6 +19,9 @@ properties:
           - raspberrypi,bootloader-config
       - const: nvmem-rmem
 
+  reg:
+    maxItems: 1
+
   no-map:
     $ref: /schemas/types.yaml#/definitions/flag
     description:
Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml +3 -0
index a48c8fa56bce..448a2678dc62 100644
@@ -24,6 +24,9 @@ properties:
       - st,stm32f4-otp
       - st,stm32mp15-bsec
 
+  reg:
+    maxItems: 1
+
 patternProperties:
   "^.*@[0-9a-f]+$":
     type: object
Signature · 1 line
2.32.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 18 lines · Rob Herring

With 'unevaluatedProperties' support implemented, the following warnings are generated in the nvmem examples:

Documentation/devicetree/bindings/nvmem/st,stm32-romem.example.dt.yaml: efuse@1fff7800: Unevaluated properties are not allowed ('reg' was unexpected) Documentation/devicetree/bindings/nvmem/rmem.example.dt.yaml: nvram@10000000: Unevaluated properties are not allowed ('reg' was unexpected) Documentation/devicetree/bindings/nvmem/brcm,nvram.example.dt.yaml: nvram@1eff0000: Unevaluated properties are not allowed ('reg' was unexpected)

Add the missing 'reg' property definition.

Cc Srinivas Kandagatla <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Alexandre Torgue <[email protected]>
Cc Rafał Miłecki <[email protected]>
Cc Saenz Julienne <[email protected]>
Cc Fabrice Gasnier <[email protected]>
Cc [email protected]
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>
Quoted 5 lines
---
 Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml     | 3 +++
 Documentation/devicetree/bindings/nvmem/rmem.yaml           | 3 +++
 Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml | 3 +++
 3 files changed, 9 insertions(+)
Reviewed-by Thierry Reding <[email protected]>
Reviewed-by on v1 1/1
#2 lore raw
In reply to Rob Herring
Quoted 18 lines · Rob Herring

With 'unevaluatedProperties' support implemented, the following warnings are generated in the nvmem examples:

Documentation/devicetree/bindings/nvmem/st,stm32-romem.example.dt.yaml: efuse@1fff7800: Unevaluated properties are not allowed ('reg' was unexpected) Documentation/devicetree/bindings/nvmem/rmem.example.dt.yaml: nvram@10000000: Unevaluated properties are not allowed ('reg' was unexpected) Documentation/devicetree/bindings/nvmem/brcm,nvram.example.dt.yaml: nvram@1eff0000: Unevaluated properties are not allowed ('reg' was unexpected)

Add the missing 'reg' property definition.

Cc Srinivas Kandagatla <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Alexandre Torgue <[email protected]>
Cc Rafał Miłecki <[email protected]>
Cc Saenz Julienne <[email protected]>
Cc Fabrice Gasnier <[email protected]>
Cc [email protected]
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>
Quoted 5 lines
---
 Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml     | 3 +++
 Documentation/devicetree/bindings/nvmem/rmem.yaml           | 3 +++
 Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml | 3 +++
 3 files changed, 9 insertions(+)

Hi Rob,

For the stm32-romem, you can add my:

Reviewed-by Fabrice Gasnier <[email protected]>

Thanks,
Fabrice

Quoted 44 lines
Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml +3 -0
index 58ff6b0bdb1a..8c3f0cd22821 100644
@@ -24,6 +24,9 @@ properties:
   compatible:
     const: brcm,nvram
 
+  reg:
+    maxItems: 1
+
 unevaluatedProperties: false
 
 examples:
Documentation/devicetree/bindings/nvmem/rmem.yaml +3 -0
index 1d85a0a30846..a4a755dcfc43 100644
@@ -19,6 +19,9 @@ properties:
           - raspberrypi,bootloader-config
       - const: nvmem-rmem
 
+  reg:
+    maxItems: 1
+
   no-map:
     $ref: /schemas/types.yaml#/definitions/flag
     description:
Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml +3 -0
index a48c8fa56bce..448a2678dc62 100644
@@ -24,6 +24,9 @@ properties:
       - st,stm32f4-otp
       - st,stm32mp15-bsec
 
+  reg:
+    maxItems: 1
+
 patternProperties:
   "^.*@[0-9a-f]+$":
     type: object
#3 lore raw
In reply to Rob Herring
Quoted 9 lines · Rob Herring

With 'unevaluatedProperties' support implemented, the following warnings are generated in the nvmem examples:

Documentation/devicetree/bindings/nvmem/st,stm32-romem.example.dt.yaml: efuse@1fff7800: Unevaluated properties are not allowed ('reg' was unexpected) Documentation/devicetree/bindings/nvmem/rmem.example.dt.yaml: nvram@10000000: Unevaluated properties are not allowed ('reg' was unexpected) Documentation/devicetree/bindings/nvmem/brcm,nvram.example.dt.yaml: nvram@1eff0000: Unevaluated properties are not allowed ('reg' was unexpected)

Add the missing 'reg' property definition.

Quoted 9 lines
Cc Srinivas Kandagatla <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Alexandre Torgue <[email protected]>
Cc Rafał Miłecki <[email protected]>
Cc Saenz Julienne <[email protected]>
Cc Fabrice Gasnier <[email protected]>
Cc [email protected]
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>

Applied thanks,

--srini

Quoted 49 lines
---
  Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml     | 3 +++
  Documentation/devicetree/bindings/nvmem/rmem.yaml           | 3 +++
  Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml | 3 +++
  3 files changed, 9 insertions(+)
Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml +3 -0
index 58ff6b0bdb1a..8c3f0cd22821 100644
@@ -24,6 +24,9 @@ properties:
    compatible:
      const: brcm,nvram
 
+  reg:
+    maxItems: 1
+
  unevaluatedProperties: false
 
  examples:
Documentation/devicetree/bindings/nvmem/rmem.yaml +3 -0
index 1d85a0a30846..a4a755dcfc43 100644
@@ -19,6 +19,9 @@ properties:
            - raspberrypi,bootloader-config
        - const: nvmem-rmem
 
+  reg:
+    maxItems: 1
+
    no-map:
      $ref: /schemas/types.yaml#/definitions/flag
      description:
Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml +3 -0
index a48c8fa56bce..448a2678dc62 100644
@@ -24,6 +24,9 @@ properties:
        - st,stm32f4-otp
        - st,stm32mp15-bsec
 
+  reg:
+    maxItems: 1
+
  patternProperties:
    "^.*@[0-9a-f]+$":
      type: object