Skip to contentSkip to conversation

dt-bindings: memory-controllers: ti,gpmc: Drop incorrect unevaluatedProperties

PATCH In review Rob Herring 4 participants 6 messages Dec 6, 2021 – Dec 7, 2021

Subsystems (2)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: memory-controllers: ti,gpmc: Drop incorrect unevaluatedProperties

With 'unevaluatedProperties' support implemented, the TI GPMC example has a warning:

Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.example.dt.yaml: memory-controller@6e000000: onenand@0,0: Unevaluated properties are not allowed ('compatible', '#address-cells', '#size-cells', 'partition@0', 'partition@100000' were unexpected)

The child node definition for GPMC is not a complete binding, so specifying 'unevaluatedProperties: false' for it is not correct and should be dropped.

Fixup the unnecessary 'allOf' while we're here.

Cc Krzysztof Kozlowski <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc Roger Quadros <[email protected]>
---
 .../devicetree/bindings/memory-controllers/ti,gpmc.yaml      | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
Documentation/devicetree/bindings/memory-controllers/ti,gpmc.yaml +1 -4
index 25b42d68f9b3..85d024f01eba 100644
@@ -119,11 +119,8 @@ patternProperties:
       The child device node represents the device connected to the GPMC
       bus. The device can be a NAND chip, SRAM device, NOR device
       or an ASIC.
+    $ref: "ti,gpmc-child.yaml"
 
-    allOf:
-      - $ref: "ti,gpmc-child.yaml"
-
-    unevaluatedProperties: false
 
 required:
   - compatible
Signature · 1 line
2.32.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Rob Herring

With 'unevaluatedProperties' support implemented, the TI GPMC example has a warning:

Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.example.dt.yaml: memory-controller@6e000000: onenand@0,0: Unevaluated properties are not allowed ('compatible', '#address-cells', '#size-cells', 'partition@0', 'partition@100000' were unexpected)

The child node definition for GPMC is not a complete binding, so specifying 'unevaluatedProperties: false' for it is not correct and should be dropped.

Fixup the unnecessary 'allOf' while we're here.

Quoted 7 lines
Cc Krzysztof Kozlowski <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc Roger Quadros <[email protected]>
---
 .../devicetree/bindings/memory-controllers/ti,gpmc.yaml      | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
#2 lore raw
In reply to Rob Herring
Quoted 11 lines · Rob Herring

With 'unevaluatedProperties' support implemented, the TI GPMC example has a warning:

Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.example.dt.yaml: memory-controller@6e000000: onenand@0,0: Unevaluated properties are not allowed ('compatible', '#address-cells', '#size-cells', 'partition@0', 'partition@100000' were unexpected)

The child node definition for GPMC is not a complete binding, so specifying 'unevaluatedProperties: false' for it is not correct and should be dropped.

Fixup the unnecessary 'allOf' while we're here.

Quoted 8 lines
Cc Krzysztof Kozlowski <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc Roger Quadros <[email protected]>
---
 .../devicetree/bindings/memory-controllers/ti,gpmc.yaml      | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Looks good. Rob, do you want to take it via your tree or I should handle it?

Best regards,
Krzysztof

author maintainer
#3 lore raw
Quoted 22 lines · Krzysztof Kozlowski
Quoted 11 lines · Rob Herring

With 'unevaluatedProperties' support implemented, the TI GPMC example has a warning:

Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.example.dt.yaml: memory-controller@6e000000: onenand@0,0: Unevaluated properties are not allowed ('compatible', '#address-cells', '#size-cells', 'partition@0', 'partition@100000' were unexpected)

The child node definition for GPMC is not a complete binding, so specifying 'unevaluatedProperties: false' for it is not correct and should be dropped.

Fixup the unnecessary 'allOf' while we're here.

Quoted 8 lines
Cc Krzysztof Kozlowski <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc Roger Quadros <[email protected]>
---
 .../devicetree/bindings/memory-controllers/ti,gpmc.yaml      | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
Quoted 1 line

Looks good. Rob, do you want to take it via your tree or I should handle it?

I'll take it given there's also the somewhat related "dt-bindings:
mtd: ti,gpmc-nand: Add missing 'rb-gpios'"

Rob

#4 lore raw
Quoted 24 lines · Rob Herring
Quoted 22 lines · Krzysztof Kozlowski
Quoted 19 lines · Rob Herring

With 'unevaluatedProperties' support implemented, the TI GPMC example has a warning:

Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.example.dt.yaml: memory-controller@6e000000: onenand@0,0: Unevaluated properties are not allowed ('compatible', '#address-cells', '#size-cells', 'partition@0', 'partition@100000' were unexpected)

The child node definition for GPMC is not a complete binding, so specifying 'unevaluatedProperties: false' for it is not correct and should be dropped.

Fixup the unnecessary 'allOf' while we're here.

Cc Krzysztof Kozlowski <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc Roger Quadros <[email protected]>
---
 .../devicetree/bindings/memory-controllers/ti,gpmc.yaml      | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
Quoted 4 lines
Quoted 1 line

Looks good. Rob, do you want to take it via your tree or I should handle it?

I'll take it given there's also the somewhat related "dt-bindings:
mtd: ti,gpmc-nand: Add missing 'rb-gpios'"

Sure, then:

Best regards,
Krzysztof

Reviewed-by on v1 1/1
#5 lore raw
In reply to Rob Herring
Quoted 9 lines · Rob Herring

With 'unevaluatedProperties' support implemented, the TI GPMC example has a warning:

Documentation/devicetree/bindings/mtd/ti,gpmc-onenand.example.dt.yaml: memory-controller@6e000000: onenand@0,0: Unevaluated properties are not allowed ('compatible', '#address-cells', '#size-cells', 'partition@0', 'partition@100000' were unexpected)

The child node definition for GPMC is not a complete binding, so specifying 'unevaluatedProperties: false' for it is not correct and should be dropped.

Quoted 6 lines

Fixup the unnecessary 'allOf' while we're here.

Cc Krzysztof Kozlowski <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc Roger Quadros <[email protected]>

cheers,
-roger