Skip to contentSkip to conversation

dt-bindings: i2c: aspeed: Drop stray '#interrupt-cells'

PATCH Applied Rob Herring 3 participants 3 messages Dec 6, 2021 – Dec 16, 2021

Subsystems (4)
Device tree bindings I2C subsystem host drivers Arm/Aspeed machine support Arm/Aspeed I2C driver
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: i2c: aspeed: Drop stray '#interrupt-cells'

'#interrupt-cells' is not documented which causes a warning when 'unevaluatedProperties' is implemented. Unless the I2C controller is also an interrupt controller, '#interrupt-cells' is not valid. This doesn't appear to be the case from the driver, so just remove it from the example.

Cc Brendan Higgins <[email protected]>
Cc Benjamin Herrenschmidt <[email protected]>
Cc Joel Stanley <[email protected]>
Cc Andrew Jeffery <[email protected]>
Cc Rayn Chen <[email protected]>
Cc linux-i2c at vger.kernel.org
Cc openbmc at lists.ozlabs.org
Cc linux-arm-kernel at lists.infradead.org
Cc linux-aspeed at lists.ozlabs.org
Signed-off-by Rob Herring <[email protected]>
---
 Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml | 1 -
 1 file changed, 1 deletion(-)
Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml +0 -1
index ea643e6c3ef5..f597f73ccd87 100644
@@ -63,7 +63,6 @@ examples:
     i2c0: i2c-bus at 40 {
       #address-cells = <1>;
       #size-cells = <0>;
-      #interrupt-cells = <1>;
       compatible = "aspeed,ast2500-i2c-bus";
       reg = <0x40 0x40>;
       clocks = <&syscon ASPEED_CLK_APB>;
Signature · 1 line
2.32.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 16 lines · Rob Herring

'#interrupt-cells' is not documented which causes a warning when 'unevaluatedProperties' is implemented. Unless the I2C controller is also an interrupt controller, '#interrupt-cells' is not valid. This doesn't appear to be the case from the driver, so just remove it from the example.

Cc Brendan Higgins <[email protected]>
Cc Benjamin Herrenschmidt <[email protected]>
Cc Joel Stanley <[email protected]>
Cc Andrew Jeffery <[email protected]>
Cc Rayn Chen <[email protected]>
Cc linux-i2c at vger.kernel.org
Cc openbmc at lists.ozlabs.org
Cc linux-arm-kernel at lists.infradead.org
Cc linux-aspeed at lists.ozlabs.org
Signed-off-by Rob Herring <[email protected]>
Quoted 3 lines
---
 Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml | 1 -
 1 file changed, 1 deletion(-)

Interestingly I have a patch for this as well but it does the opposite and adds interrupt-controller and #interrupt-cells. Upon closer inspection I was tricked into this because the i2c-aspeed driver includes linux/irqchip/chained_irq.h and linux/irqdomain.h and therefore I assumed that it was indeed implementing an interrupt controller. But none of the symbols in those files are ever used, so your version seems to be correct.

Reviewed-by Thierry Reding <[email protected]>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20211207/233b17ff/attachment.sig>

Applied
#2 lore raw
In reply to Rob Herring
Quoted 6 lines · Rob Herring

'#interrupt-cells' is not documented which causes a warning when 'unevaluatedProperties' is implemented. Unless the I2C controller is also an interrupt controller, '#interrupt-cells' is not valid. This doesn't appear to be the case from the driver, so just remove it from the example.

Quoted 10 lines
Cc Brendan Higgins <[email protected]>
Cc Benjamin Herrenschmidt <[email protected]>
Cc Joel Stanley <[email protected]>
Cc Andrew Jeffery <[email protected]>
Cc Rayn Chen <[email protected]>
Cc linux-i2c at vger.kernel.org
Cc openbmc at lists.ozlabs.org
Cc linux-arm-kernel at lists.infradead.org
Cc linux-aspeed at lists.ozlabs.org
Signed-off-by Rob Herring <[email protected]>

Applied to for-next, thanks!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20211216/6e4b8ea2/attachment.sig>