x86/resctrl: remove redundant assignment to variable chunks
Subsystems (3)
PATCH 1/1 x86/resctrl: remove redundant assignment to variable chunks
The variable chunks is being shifted right and re-assinged the shifted value which is then returned. Since chunks is not being read afterwards the assignment is redundant and the >>= operator can be replaced with a shift >> operator instead.
--- arch/x86/kernel/cpu/resctrl/monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/cpu/resctrl/monitor.c +1 -1
@@ -282,7 +282,7 @@ static u64 mbm_overflow_count(u64 prev_msr, u64 cur_msr, unsigned int width)u64 shift =64 - width, chunks; chunks = (cur_msr << shift) - (prev_msr << shift); -return chunks >>= shift; +return chunks >> shift; }static u64 __mon_event_count (u32 rmid,struct rmid_read *rr)
Signature · 1 line
2.33.1
Quoted 15 lines · Colin Ian King
The variable chunks is being shifted right and re-assinged the shifted value which is then returned. Since chunks is not being read afterwards the assignment is redundant and the >>= operator can be replaced with a shift >> operator instead.
Signed-off-by Colin Ian King <[email protected]>--- arch/x86/kernel/cpu/resctrl/monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/x86/kernel/cpu/resctrl/monitor.c +0
-0
arch/x86/kernel/cpu/resctrl/monitor.c static u64 mbm_overflow_count(u64 prev_msr, u64 cur_msr, unsigned int width) · line 288
Quoted 8 lines
arch/x86/kernel/cpu/resctrl/monitor.c +1
-1@@ -282,7 +282,7 @@ static u64 mbm_overflow_count(u64 prev_msr, u64 cur_msr, unsigned int width)u64 shift =64 - width, chunks; chunks = (cur_msr << shift) - (prev_msr << shift); -return chunks >>= shift; +return chunks >> shift; }static u64 __mon_event_count (u32 rmid,struct rmid_read *rr)
Thanks.
-Fenghua
[tip: x86/cache] x86/resctrl: Remove redundant assignment to variable chunks
In reply to Colin Ian KingThe following commit has been merged into the x86/cache branch of tip:
The following commit has been merged into the x86/cache branch of tip:
Commit-ID: df0114f1f8711dbf481324c44cf5a8349130b913 Gitweb: https://git.kernel.org/tip/df0114f1f8711dbf481324c44cf5a8349130b913 Author: Colin Ian King <[email protected]> AuthorDate: Tue, 07 Dec 2021 22:37:35 Committer: Dave Hansen <[email protected]> CommitterDate: Thu, 09 Dec 2021 09:57:16 -08:00
x86/resctrl: Remove redundant assignment to variable chunks
The variable chunks is being shifted right and re-assinged the shifted value which is then returned. Since chunks is not being read afterwards the assignment is redundant and the >>= operator can be replaced with a shift >> operator instead.
--- arch/x86/kernel/cpu/resctrl/monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/cpu/resctrl/monitor.c +1 -1
@@ -282,7 +282,7 @@ static u64 mbm_overflow_count(u64 prev_msr, u64 cur_msr, unsigned int width)u64 shift =64 - width, chunks; chunks = (cur_msr << shift) - (prev_msr << shift); -return chunks >>= shift; +return chunks >> shift; }static u64 __mon_event_count (u32 rmid,struct rmid_read *rr)