include/linux/unaligned: Replace kernel.h with the necessary inclusions
PATCH 1/1 include/linux/unaligned: Replace kernel.h with the necessary inclusions
When kernel.h is used in the headers it adds a lot into dependency hell, especially when there are circular dependencies are involved.
Replace kernel.h inclusion with the list of what is really being used.
The rest of the changes are induced by the above and may not be split.
--- drivers/net/wireless/broadcom/brcm80211/brcmfmac/xtlv.c | 2 ++ include/linux/unaligned/packed_struct.h | 2 +- lib/lz4/lz4defs.h | 2 ++ 3 files changed, 5 insertions(+), 1 deletion(-)
drivers/net/wireless/broadcom/brcm80211/brcmfmac/xtlv.c +2 -0
@@ -4,6 +4,8 @@*/ #include <asm/unaligned.h> + +#include <linux/math.h> #include <linux/string.h> #include <linux/bug.h>
include/linux/unaligned/packed_struct.h +1 -1
@@ -1,7 +1,7 @@#ifndef _LINUX_UNALIGNED_PACKED_STRUCT_H#define _LINUX_UNALIGNED_PACKED_STRUCT_H -#include <linux/kernel.h> +#include <linux/types.h> struct __una_u16 {u16 x; } __packed;struct __una_u32 {u32 x; } __packed;
lib/lz4/lz4defs.h +2 -0
@@ -36,6 +36,8 @@*/ #include <asm/unaligned.h> + +#include <linux/bitops.h> #include <linux/string.h> /* memset, memcpy */ #define FORCE_INLINE __always_inline
Signature · 1 line
2.33.0
Quoted 6 lines · Andy Shevchenko
When
kernel.his used in the headers it adds a lot into dependency hell, especially when there are circular dependencies are involved.Replace
kernel.hinclusion with the list of what is really being used.The rest of the changes are induced by the above and may not be split.
For brcmfmac change:
Quoted 6 lines
Signed-off-by Andy Shevchenko <[email protected]>--- drivers/net/wireless/broadcom/brcm80211/brcmfmac/xtlv.c | 2 ++ include/linux/unaligned/packed_struct.h | 2 +- lib/lz4/lz4defs.h | 2 ++ 3 files changed, 5 insertions(+), 1 deletion(-)
Quoted 5 lines · Andy Shevchenko
When
kernel.his used in the headers it adds a lot into dependency hell, especially when there are circular dependencies are involved.Replace
kernel.hinclusion with the list of what is really being used.
Quoted 8 lines
The rest of the changes are induced by the above and may not be split.
Signed-off-by Andy Shevchenko <[email protected]>--- drivers/net/wireless/broadcom/brcm80211/brcmfmac/xtlv.c | 2 ++ include/linux/unaligned/packed_struct.h | 2 +- lib/lz4/lz4defs.h | 2 ++ 3 files changed, 5 insertions(+), 1 deletion(-)
I assume this will go via some other tree:
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches